| commit | 86d3d63a4670b3f452f7ae8917d01c93e2473713 | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Tue Apr 22 08:56:11 2025 -0700 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 22 08:56:11 2025 -0700 |
| tree | bbcfc94220dbbbb2c214e1efd8e88e6322f32feb | |
| parent | 564e9384c0f16969a49ee253afc79cf28c909d56 [diff] |
[analyzer] Fix dead code range for `do` loop.
Prior to this change, a `do` loop such as this one:
do {
return;
} while (true);
would be flagged with two DEAD_CODE warnings: one covering the text `}
while (true);` (which makes sense), and one covering the text `do {`
(which doesn't make sense at all, since the top of the `do` loop is
reachable).
Digging through the code and git history, I've found no good reason
for the DEAD_CODE warning at `do {` to exist. It looks like it was
added as part of a bug fix from an external contributor and not
spotted during code review
(https://dart-review.googlesource.com/c/sdk/+/266389).
With the unnecessary dead code range removed, some of the tests of the
analysis server's `remove_dead_code` fix become simpler (they don't
need to use an `errorFilter` to select which dead code range to act
on). Others become unnecessary (since they were verifying that
`remove_dead_code` properly handled the bogus dead code range). Others
simply needed their `errorFilter` changed to select the appropriate
dead code range.
Making this fix paves the way for improving the `remove_dead_code`
fix, which I want to do as part of shipping the `sound-flow-analysis`
feature.
Change-Id: Iee0bc187441bc4be76a8fa57198155dff3731bc8
Bug: https://github.com/dart-lang/sdk/issues/60438
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.