tree bbcfc94220dbbbb2c214e1efd8e88e6322f32feb
parent 564e9384c0f16969a49ee253afc79cf28c909d56
author Paul Berry <paulberry@google.com> 1745337371 -0700
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> 1745337371 -0700

[analyzer] Fix dead code range for `do` loop.

Prior to this change, a `do` loop such as this one:

    do {
      return;
    } while (true);

would be flagged with two DEAD_CODE warnings: one covering the text `}
while (true);` (which makes sense), and one covering the text `do {`
(which doesn't make sense at all, since the top of the `do` loop is
reachable).

Digging through the code and git history, I've found no good reason
for the DEAD_CODE warning at `do {` to exist. It looks like it was
added as part of a bug fix from an external contributor and not
spotted during code review
(https://dart-review.googlesource.com/c/sdk/+/266389).

With the unnecessary dead code range removed, some of the tests of the
analysis server's `remove_dead_code` fix become simpler (they don't
need to use an `errorFilter` to select which dead code range to act
on). Others become unnecessary (since they were verifying that
`remove_dead_code` properly handled the bogus dead code range). Others
simply needed their `errorFilter` changed to select the appropriate
dead code range.

Making this fix paves the way for improving the `remove_dead_code`
fix, which I want to do as part of shipping the `sound-flow-analysis`
feature.

Change-Id: Iee0bc187441bc4be76a8fa57198155dff3731bc8
Bug: https://github.com/dart-lang/sdk/issues/60438
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>