Revert accidental change to analyzer

Revert the change accidentally included in https://dart-review.googlesource.com/c/sdk/+/84001

Change-Id: I207253eecbe4024b30a1331901db07b596d617c0
Reviewed-on: https://dart-review.googlesource.com/c/84411
Auto-Submit: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
diff --git a/pkg/analyzer/lib/src/generated/static_type_analyzer.dart b/pkg/analyzer/lib/src/generated/static_type_analyzer.dart
index 127ec63..dfc94e4 100644
--- a/pkg/analyzer/lib/src/generated/static_type_analyzer.dart
+++ b/pkg/analyzer/lib/src/generated/static_type_analyzer.dart
@@ -1609,7 +1609,7 @@
       DartType returnType = null;
       if (typeStr == '-dynamic') {
         returnType = _typeProvider.bottomType;
-      } else if (typeStr != null) {
+      } else {
         var components = typeStr.split('|');
         if (components.remove('Null')) {
           typeStr = components.join('|');