[vm/linearscan] Account for definitions with no SSA name when processing PairLocation outputs.
ToSecondPairVreg(kNoVirtualRegister) should be kNoVirtualRegister not 0.
Revert fe28a2939ad24a99e712f0ac3b343aad86b417bd which updated statuses for
crashing tests.
Fixes https://github.com/dart-lang/sdk/issues/33329
Bug: https://github.com/dart-lang/sdk/issues/33329
Change-Id: I48e95bcb6f95555ec9ac51adc1f61619fbf40139
Reviewed-on: https://dart-review.googlesource.com/58461
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
diff --git a/runtime/vm/compiler/backend/linearscan.cc b/runtime/vm/compiler/backend/linearscan.cc
index f96a09d..76c0335 100644
--- a/runtime/vm/compiler/backend/linearscan.cc
+++ b/runtime/vm/compiler/backend/linearscan.cc
@@ -39,7 +39,9 @@
// SSA index to the second.
static intptr_t ToSecondPairVreg(intptr_t vreg) {
// Map vreg to its pair vreg.
- return vreg + kPairVirtualRegisterOffset;
+ ASSERT((vreg == kNoVirtualRegister) || vreg >= 0);
+ return (vreg == kNoVirtualRegister) ? kNoVirtualRegister
+ : (vreg + kPairVirtualRegisterOffset);
}
static intptr_t MinPosition(intptr_t a, intptr_t b) {
diff --git a/tests/language_2/language_2_kernel.status b/tests/language_2/language_2_kernel.status
index 4d11898..92bc089 100644
--- a/tests/language_2/language_2_kernel.status
+++ b/tests/language_2/language_2_kernel.status
@@ -602,11 +602,6 @@
void_type_usage_test/paren_void_init: MissingCompileTimeError # Issue 32804
void_type_usage_test/paren_while: MissingCompileTimeError # Issue 32804
-[ $arch == simarm && $compiler == dartkp && $strong ]
-cast_test/12: Crash # Issue 33329
-cast_test/15: Crash # Issue 33329
-cast_test/none: Crash # Issue 33329
-
[ $arch != simarm && $arch != simarm64 && $arch != simdbc64 && $compiler == dartk && $runtime == vm && $strong ]
export_ambiguous_main_test: Crash # Issue 32618
