[vm] Remove redundant Profiler::DumpStackTrace().
Every FATAL/ASSERT/UNREACHABLE already does this.
Change-Id: Ibc638767e0b58d04f8e453ff7bc1b70858ff4716
Reviewed-on: https://dart-review.googlesource.com/60323
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
diff --git a/runtime/vm/os_thread_android.cc b/runtime/vm/os_thread_android.cc
index 16eaa14..5eab0b8 100644
--- a/runtime/vm/os_thread_android.cc
+++ b/runtime/vm/os_thread_android.cc
@@ -17,15 +17,12 @@
#include "platform/signal_blocker.h"
#include "platform/utils.h"
-#include "vm/profiler.h"
-
namespace dart {
#define VALIDATE_PTHREAD_RESULT(result) \
if (result != 0) { \
const int kBufferSize = 1024; \
char error_message[kBufferSize]; \
- NOT_IN_PRODUCT(Profiler::DumpStackTrace()); \
Utils::StrError(result, error_message, kBufferSize); \
FATAL2("pthread error: %d (%s)", result, error_message); \
}
@@ -37,7 +34,6 @@
if (result != 0) { \
const int kBufferSize = 1024; \
char error_message[kBufferSize]; \
- NOT_IN_PRODUCT(Profiler::DumpStackTrace()); \
Utils::StrError(result, error_message, kBufferSize); \
FATAL3("[%s] pthread error: %d (%s)", name_, result, error_message); \
}
diff --git a/runtime/vm/os_thread_linux.cc b/runtime/vm/os_thread_linux.cc
index 03ccfd6..4b8da4d 100644
--- a/runtime/vm/os_thread_linux.cc
+++ b/runtime/vm/os_thread_linux.cc
@@ -19,15 +19,12 @@
#include "platform/signal_blocker.h"
#include "platform/utils.h"
-#include "vm/profiler.h"
-
namespace dart {
#define VALIDATE_PTHREAD_RESULT(result) \
if (result != 0) { \
const int kBufferSize = 1024; \
char error_buf[kBufferSize]; \
- NOT_IN_PRODUCT(Profiler::DumpStackTrace()); \
FATAL2("pthread error: %d (%s)", result, \
Utils::StrError(result, error_buf, kBufferSize)); \
}
@@ -40,7 +37,6 @@
if (result != 0) { \
const int kBufferSize = 1024; \
char error_buf[kBufferSize]; \
- NOT_IN_PRODUCT(Profiler::DumpStackTrace()); \
FATAL3("[%s] pthread error: %d (%s)", name_, result, \
Utils::StrError(result, error_buf, kBufferSize)); \
}
diff --git a/runtime/vm/os_thread_macos.cc b/runtime/vm/os_thread_macos.cc
index 8867693..39f0047 100644
--- a/runtime/vm/os_thread_macos.cc
+++ b/runtime/vm/os_thread_macos.cc
@@ -23,15 +23,12 @@
#include "platform/safe_stack.h"
#include "platform/utils.h"
-#include "vm/profiler.h"
-
namespace dart {
#define VALIDATE_PTHREAD_RESULT(result) \
if (result != 0) { \
const int kBufferSize = 1024; \
char error_message[kBufferSize]; \
- NOT_IN_PRODUCT(Profiler::DumpStackTrace()); \
Utils::StrError(result, error_message, kBufferSize); \
FATAL2("pthread error: %d (%s)", result, error_message); \
}
@@ -43,7 +40,6 @@
if (result != 0) { \
const int kBufferSize = 1024; \
char error_message[kBufferSize]; \
- NOT_IN_PRODUCT(Profiler::DumpStackTrace()); \
Utils::StrError(result, error_message, kBufferSize); \
FATAL3("[%s] pthread error: %d (%s)", name_, result, error_message); \
}
diff --git a/runtime/vm/virtual_memory_android.cc b/runtime/vm/virtual_memory_android.cc
index 5f0b0de..ff39c23 100644
--- a/runtime/vm/virtual_memory_android.cc
+++ b/runtime/vm/virtual_memory_android.cc
@@ -15,7 +15,6 @@
#include "platform/utils.h"
#include "vm/isolate.h"
-#include "vm/profiler.h"
namespace dart {
@@ -39,7 +38,6 @@
int error = errno;
const int kBufferSize = 1024;
char error_buf[kBufferSize];
- NOT_IN_PRODUCT(Profiler::DumpStackTrace());
FATAL2("munmap error: %d (%s)", error,
Utils::StrError(error, error_buf, kBufferSize));
}
@@ -132,7 +130,6 @@
int error = errno;
const int kBufferSize = 1024;
char error_buf[kBufferSize];
- NOT_IN_PRODUCT(Profiler::DumpStackTrace());
FATAL2("mprotect error: %d (%s)", error,
Utils::StrError(error, error_buf, kBufferSize));
}
diff --git a/runtime/vm/virtual_memory_linux.cc b/runtime/vm/virtual_memory_linux.cc
index f07eb8e..80fb7c7 100644
--- a/runtime/vm/virtual_memory_linux.cc
+++ b/runtime/vm/virtual_memory_linux.cc
@@ -15,7 +15,6 @@
#include "platform/utils.h"
#include "vm/isolate.h"
-#include "vm/profiler.h"
namespace dart {
@@ -39,7 +38,6 @@
int error = errno;
const int kBufferSize = 1024;
char error_buf[kBufferSize];
- NOT_IN_PRODUCT(Profiler::DumpStackTrace());
FATAL2("munmap error: %d (%s)", error,
Utils::StrError(error, error_buf, kBufferSize));
}
@@ -132,7 +130,6 @@
int error = errno;
const int kBufferSize = 1024;
char error_buf[kBufferSize];
- NOT_IN_PRODUCT(Profiler::DumpStackTrace());
FATAL2("mprotect error: %d (%s)", error,
Utils::StrError(error, error_buf, kBufferSize));
}
diff --git a/runtime/vm/virtual_memory_macos.cc b/runtime/vm/virtual_memory_macos.cc
index dbb680e..e9dcc4b 100644
--- a/runtime/vm/virtual_memory_macos.cc
+++ b/runtime/vm/virtual_memory_macos.cc
@@ -15,7 +15,6 @@
#include "platform/utils.h"
#include "vm/isolate.h"
-#include "vm/profiler.h"
namespace dart {
@@ -39,7 +38,6 @@
int error = errno;
const int kBufferSize = 1024;
char error_buf[kBufferSize];
- NOT_IN_PRODUCT(Profiler::DumpStackTrace());
FATAL2("munmap error: %d (%s)", error,
Utils::StrError(error, error_buf, kBufferSize));
}
@@ -132,7 +130,6 @@
int error = errno;
const int kBufferSize = 1024;
char error_buf[kBufferSize];
- NOT_IN_PRODUCT(Profiler::DumpStackTrace());
FATAL2("mprotect error: %d (%s)", error,
Utils::StrError(error, error_buf, kBufferSize));
}
