| commit | 70bd05e662a64d2fa794663775d08c061a871ff7 | [log] [tgz] |
|---|---|---|
| author | Robert Nystrom <rnystrom@google.com> | Fri May 24 23:52:08 2019 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Fri May 24 23:52:08 2019 +0000 |
| tree | 5bcfde939a660d0a80e0abe5d04f6a193acca3f9 | |
| parent | eff6e953858520d48595f527e6a3633744c0e073 [diff] |
Stop ignoring runtime cast failures on function types. Change-Id: Id3485e04aafea988604663e893818672d98dc8b0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103662 Reviewed-by: Vijay Menon <vsm@google.com> Commit-Queue: Bob Nystrom <rnystrom@google.com>
diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart index 7ab4a81..22849df 100644 --- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart +++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
@@ -434,9 +434,8 @@ result = _ignoreTypeFailure(t1, typeFuture) || _ignoreTypeFailure(t1, typeArg); } else { - result = t1 is FunctionType && t2 is FunctionType || - isSubtypeOf(t2, unwrapType(Iterable)) && - isSubtypeOf(t1, unwrapType(Iterable)); + result = isSubtypeOf(t2, unwrapType(Iterable)) && + isSubtypeOf(t1, unwrapType(Iterable)); if (result) { _warn('Ignoring cast fail from ${typeName(t1)} to ${typeName(t2)}'); }