| // Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file |
| // for details. All rights reserved. Use of this source code is governed by a |
| // BSD-style license that can be found in the LICENSE file. |
| |
| import 'package:analyzer/dart/ast/ast.dart'; |
| import 'package:analyzer/dart/ast/token.dart'; |
| import 'package:analyzer/dart/ast/visitor.dart'; |
| import 'package:analyzer/dart/element/element.dart'; |
| import 'package:analyzer/dart/element/type.dart'; |
| |
| import '../analyzer.dart'; |
| import '../extensions.dart'; |
| import '../util/flutter_utils.dart'; |
| |
| const _desc = r'DO reference all public properties in debug methods.'; |
| |
| class DiagnosticDescribeAllProperties extends LintRule { |
| DiagnosticDescribeAllProperties() |
| : super( |
| name: LintNames.diagnostic_describe_all_properties, |
| description: _desc, |
| ); |
| |
| @override |
| LintCode get lintCode => LinterLintCode.diagnostic_describe_all_properties; |
| |
| @override |
| void registerNodeProcessors( |
| NodeLintRegistry registry, |
| LinterContext context, |
| ) { |
| var visitor = _Visitor(this, context.inheritanceManager); |
| registry.addClassDeclaration(this, visitor); |
| } |
| } |
| |
| class _IdentifierVisitor extends RecursiveAstVisitor<void> { |
| final List<Token> properties; |
| _IdentifierVisitor(this.properties); |
| |
| @override |
| visitSimpleIdentifier(SimpleIdentifier node) { |
| String debugName; |
| String name; |
| const debugPrefix = 'debug'; |
| if (node.name.startsWith(debugPrefix) && |
| node.name.length > debugPrefix.length) { |
| debugName = node.name; |
| name = |
| '${node.name[debugPrefix.length].toLowerCase()}' |
| '${node.name.substring(debugPrefix.length + 1)}'; |
| } else { |
| name = node.name; |
| debugName = |
| '$debugPrefix${node.name[0].toUpperCase()}${node.name.substring(1)}'; |
| } |
| properties.removeWhere( |
| (property) => property.lexeme == debugName || property.lexeme == name, |
| ); |
| |
| super.visitSimpleIdentifier(node); |
| } |
| } |
| |
| class _Visitor extends SimpleAstVisitor<void> { |
| final LintRule rule; |
| final InheritanceManager3 inheritanceManager; |
| |
| _Visitor(this.rule, this.inheritanceManager); |
| |
| void removeReferences(MethodDeclaration? method, List<Token> properties) { |
| method?.body.accept(_IdentifierVisitor(properties)); |
| } |
| |
| bool skipForDiagnostic({Element2? element, DartType? type, Token? name}) => |
| name.isPrivate || _isOverridingMember(element) || isWidgetProperty(type); |
| |
| @override |
| void visitClassDeclaration(ClassDeclaration node) { |
| // We only care about Diagnosticables. |
| var type = node.declaredFragment?.element.thisType; |
| if (!type.implementsInterface('Diagnosticable', '')) return; |
| |
| var properties = <Token>[]; |
| for (var member in node.members) { |
| if (member is MethodDeclaration && member.isGetter) { |
| if (!member.isStatic && |
| !skipForDiagnostic( |
| element: member.declaredFragment?.element, |
| name: member.name, |
| type: member.returnType?.type, |
| )) { |
| properties.add(member.name); |
| } |
| } else if (member is FieldDeclaration) { |
| for (var v in member.fields.variables) { |
| var declaredElement = v.declaredFragment?.element; |
| if (declaredElement != null && |
| !declaredElement.isStatic && |
| !skipForDiagnostic( |
| element: declaredElement, |
| name: v.name, |
| type: declaredElement.type, |
| )) { |
| properties.add(v.name); |
| } |
| } |
| } |
| } |
| |
| if (properties.isEmpty) return; |
| |
| var debugFillProperties = node.members.getMethod('debugFillProperties'); |
| var debugDescribeChildren = node.members.getMethod('debugDescribeChildren'); |
| |
| // Remove any defined in debugFillProperties. |
| removeReferences(debugFillProperties, properties); |
| |
| // Remove any defined in debugDescribeChildren. |
| removeReferences(debugDescribeChildren, properties); |
| |
| // Flag the rest. |
| properties.forEach(rule.reportAtToken); |
| } |
| |
| bool _isOverridingMember(Element2? member) { |
| if (member == null) return false; |
| |
| var classElement = member.thisOrAncestorOfType2<InterfaceElement2>(); |
| if (classElement == null) return false; |
| |
| var name = member.name3; |
| if (name == null) return false; |
| |
| return inheritanceManager.getInherited4(classElement, Name(null, name)) != |
| null; |
| } |
| } |