commit 6b8826f336ecd1293b4228f445c118c909ce5249
author Dmitry Stefantsov <dmitryas@google.com> Tue Jan 08 10:31:42 2019 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Tue Jan 08 10:31:42 2019 +0000
tree c4c68f691d9d78acfeb3a285ff4e4f4c57a5363f
parent c76c5a023dfe09f012b33011a1c1ff2a28b3d673

[kernel] Rename failure classes for TextSerializationVerifier

Change-Id: I51240e069a1a518fe35d25d2a44e8d7a84343946
Reviewed-on: https://dart-review.googlesource.com/c/88562
Reviewed-by: Kevin Millikin <kmillikin@google.com>

pkg/kernel/lib/text/text_serialization_verifier.dart

diff --git a/pkg/kernel/lib/text/text_serialization_verifier.dart b/pkg/kernel/lib/text/text_serialization_verifier.dart
index 30e5bb8..80a2f21 100644
--- a/pkg/kernel/lib/text/text_serialization_verifier.dart
+++ b/pkg/kernel/lib/text/text_serialization_verifier.dart
@@ -17,7 +17,7 @@
 
 const int noOffset = -1;
 
-abstract class RoundTripFailure {
+abstract class TextSerializationVerificationFailure {
   /// [Uri] of the file containing the expression that produced an error during
   /// the round trip.
   final Uri uri;
@@ -26,34 +26,35 @@
   /// during the round trip.
   final int offset;
 
-  RoundTripFailure(this.uri, this.offset);
+  TextSerializationVerificationFailure(this.uri, this.offset);
 }
 
-class RoundTripSerializationFailure extends RoundTripFailure {
+class TextSerializationFailure extends TextSerializationVerificationFailure {
   final String message;
 
-  RoundTripSerializationFailure(this.message, Uri uri, int offset)
+  TextSerializationFailure(this.message, Uri uri, int offset)
       : super(uri, offset);
 }
 
-class RoundTripDeserializationFailure extends RoundTripFailure {
+class TextDeserializationFailure extends TextSerializationVerificationFailure {
   final String message;
 
-  RoundTripDeserializationFailure(this.message, Uri uri, int offset)
+  TextDeserializationFailure(this.message, Uri uri, int offset)
       : super(uri, offset);
 }
 
-class RoundTripMismatchFailure extends RoundTripFailure {
+class TextRoundTripFailure extends TextSerializationVerificationFailure {
   final String initial;
   final String serialized;
 
-  RoundTripMismatchFailure(this.initial, this.serialized, Uri uri, int offset)
+  TextRoundTripFailure(this.initial, this.serialized, Uri uri, int offset)
       : super(uri, offset);
 }
 
 class TextSerializationVerifier implements Visitor<void> {
   /// List of errors produced during round trips on the visited nodes.
-  final List<RoundTripFailure> failures = <RoundTripFailure>[];
+  final List<TextSerializationVerificationFailure> failures =
+      <TextSerializationVerificationFailure>[];
 
   Uri lastSeenUri = noUri;
 
@@ -78,11 +79,11 @@
     try {
       result = serializer.readFrom(stream);
     } catch (exception) {
-      failures.add(new RoundTripDeserializationFailure(
-          exception.toString(), uri, offset));
+      failures.add(
+          new TextDeserializationFailure(exception.toString(), uri, offset));
     }
     if (stream.moveNext()) {
-      failures.add(new RoundTripDeserializationFailure(
+      failures.add(new TextDeserializationFailure(
           "unexpected trailing text", uri, offset));
     }
     return result;
@@ -94,8 +95,8 @@
     try {
       serializer.writeTo(buffer, node);
     } catch (exception) {
-      failures.add(
-          new RoundTripSerializationFailure(exception.toString(), uri, offset));
+      failures
+          .add(new TextSerializationFailure(exception.toString(), uri, offset));
     }
     return buffer.toString();
   }
@@ -113,8 +114,7 @@
         writeNode(deserialized, expressionSerializer, uri, offset);
 
     if (initial != serialized) {
-      failures
-          .add(new RoundTripMismatchFailure(initial, serialized, uri, offset));
+      failures.add(new TextRoundTripFailure(initial, serialized, uri, offset));
     }
   }
 
@@ -130,8 +130,7 @@
         writeNode(deserialized, dartTypeSerializer, uri, offset);
 
     if (initial != serialized) {
-      failures
-          .add(new RoundTripMismatchFailure(initial, serialized, uri, offset));
+      failures.add(new TextRoundTripFailure(initial, serialized, uri, offset));
     }
   }