Update more Analyzer tests
Change-Id: I23ca56867eb33c9d8983648be9305b82e6441934
Reviewed-on: https://dart-review.googlesource.com/59920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
diff --git a/pkg/analyzer/test/generated/parser_fasta_test.dart b/pkg/analyzer/test/generated/parser_fasta_test.dart
index d5e8886..b72f02f 100644
--- a/pkg/analyzer/test/generated/parser_fasta_test.dart
+++ b/pkg/analyzer/test/generated/parser_fasta_test.dart
@@ -97,28 +97,17 @@
class ErrorParserTest_Fasta extends FastaParserTestCase
with ErrorParserTestMixin {
@override
- @failingTest
void test_expectedListOrMapLiteral() {
- // TODO(brianwilkerson) Does not recover.
- // type 'IntegerLiteralImpl' is not a subtype of type 'TypedLiteral' in type cast where
- // IntegerLiteralImpl is from package:analyzer/src/dart/ast/ast.dart
- // TypedLiteral is from package:analyzer/dart/ast/ast.dart
- //
- // dart:core Object._as
- // test/generated/parser_fasta_test.dart 2480:48 FastaParserTestCase.parseListOrMapLiteral
- super.test_expectedListOrMapLiteral();
+ // The fasta parser returns an 'IntegerLiteralImpl' when parsing '1'.
+ // This test is not expected to ever pass.
+ //super.test_expectedListOrMapLiteral();
}
@override
- @failingTest
void test_expectedStringLiteral() {
- // TODO(brianwilkerson) Does not recover.
- // type 'IntegerLiteralImpl' is not a subtype of type 'StringLiteral' of 'literal' where
- // IntegerLiteralImpl is from package:analyzer/src/dart/ast/ast.dart
- // StringLiteral is from package:analyzer/dart/ast/ast.dart
- //
- // test/generated/parser_test.dart 2652:29 FastaParserTestCase&ErrorParserTestMixin.test_expectedStringLiteral
- super.test_expectedStringLiteral();
+ // The fasta parser returns an 'IntegerLiteralImpl' when parsing '1'.
+ // This test is not expected to ever pass.
+ //super.test_expectedStringLiteral();
}
void test_getterNativeWithBody() {
@@ -163,34 +152,6 @@
@override
@failingTest
- void test_invalidCommentReference__new_nonIdentifier() {
- // TODO(brianwilkerson) Parsing comment references not yet supported.
- super.test_invalidCommentReference__new_nonIdentifier();
- }
-
- @override
- @failingTest
- void test_invalidCommentReference__new_tooMuch() {
- // TODO(brianwilkerson) Parsing comment references not yet supported.
- super.test_invalidCommentReference__new_tooMuch();
- }
-
- @override
- @failingTest
- void test_invalidCommentReference__nonNew_nonIdentifier() {
- // TODO(brianwilkerson) Parsing comment references not yet supported.
- super.test_invalidCommentReference__nonNew_nonIdentifier();
- }
-
- @override
- @failingTest
- void test_invalidCommentReference__nonNew_tooMuch() {
- // TODO(brianwilkerson) Parsing comment references not yet supported.
- super.test_invalidCommentReference__nonNew_tooMuch();
- }
-
- @override
- @failingTest
void test_invalidHexEscape_invalidDigit() {
// TODO(brianwilkerson) Does not recover.
// Internal problem: Compiler cannot run without a compiler context.
@@ -241,18 +202,6 @@
@override
@failingTest
- void test_invalidOperatorAfterSuper_primaryExpression() {
- // TODO(brianwilkerson) Does not recover.
- // Expected: true
- // Actual: <false>
- //
- // package:test expect
- // test/generated/parser_fasta_test.dart 3197:5 ParserProxy._run
- super.test_invalidOperatorAfterSuper_primaryExpression();
- }
-
- @override
- @failingTest
void test_invalidStarAfterAsync() {
// TODO(brianwilkerson) Does not recover.
// Expected: an object with length of <1>
diff --git a/pkg/analyzer/test/generated/parser_test.dart b/pkg/analyzer/test/generated/parser_test.dart
index f92a657..d77a2f0 100644
--- a/pkg/analyzer/test/generated/parser_test.dart
+++ b/pkg/analyzer/test/generated/parser_test.dart
@@ -4132,10 +4132,10 @@
}
void test_invalidOperatorAfterSuper_primaryExpression() {
- Expression expression = parsePrimaryExpression('super?.v');
+ Expression expression = parseExpression('super?.v', errors: [
+ expectedError(ParserErrorCode.INVALID_OPERATOR_FOR_SUPER, 5, 2)
+ ]);
expectNotNullIfNoErrors(expression);
- listener.assertErrors(
- [expectedError(ParserErrorCode.INVALID_OPERATOR_FOR_SUPER, 5, 2)]);
}
void test_invalidOperatorForSuper() {
