commit 5c916afad946da147e9f256d1adebb2aa38b474d
author William Hesse <whesse@google.com> Mon Dec 17 13:30:15 2018 +0000
committer William Hesse <whesse@google.com> Mon Dec 17 13:30:15 2018 +0000
tree f547046b6181f7b7d48ba20c83890974185c5ca1
parent 52f7e9ed716f15555dc540d1aef3a53db5ba00eb

[testing] Stop ignoring flaky IE11 timeouts

BUG=dartbug.com/28955

Change-Id: I74b11ad41fd1061a847c0f5c2d58d63189033cdc
Reviewed-on: https://dart-review.googlesource.com/c/87405
Reviewed-by: Alexander Thomas <athom@google.com>

tools/testing/dart/command_output.dart

diff --git a/tools/testing/dart/command_output.dart b/tools/testing/dart/command_output.dart
index 95533cd..ed4a653 100644
--- a/tools/testing/dart/command_output.dart
+++ b/tools/testing/dart/command_output.dart
@@ -323,11 +323,6 @@
   Expectation result(TestCase testCase) {
     // Handle timeouts first.
     if (_result.didTimeout) {
-      if (testCase.configuration.runtime == Runtime.ie11) {
-        // TODO(28955): See http://dartbug.com/28955
-        DebugLogger.warning("Timeout of ie11 on test ${testCase.displayName}");
-        return Expectation.ignore;
-      }
       return Expectation.timeout;
     }
 
@@ -347,11 +342,6 @@
   Expectation realResult(TestCase testCase) {
     // Handle timeouts first.
     if (_result.didTimeout) {
-      if (testCase.configuration.runtime == Runtime.ie11) {
-        // TODO(28955): See http://dartbug.com/28955
-        DebugLogger.warning("Timeout of ie11 on test ${testCase.displayName}");
-        return Expectation.ignore;
-      }
       return Expectation.timeout;
     }
 
@@ -858,7 +848,6 @@
 
   /// Cloned code from member result(), with changes.
   /// Delete existing result() function and rename, when status files are gone.
-  /// This code can return Expectation.ignore - we may want to fix that.
   Expectation realResult(TestCase testCase) {
     if (hasCrashed) return Expectation.crash;
     if (hasTimedOut) return Expectation.timeout;
@@ -930,7 +919,6 @@
 
   /// Cloned code from member result(), with changes.
   /// Delete existing result() function and rename, when status files are gone.
-  /// This code can return Expectation.ignore - we may want to fix that.
   Expectation realResult(TestCase testCase) {
     // TODO(kustermann): Currently the batch mode runner (which can be found
     // in `test_runner.dart:BatchRunnerProcess`) does not really distinguish
@@ -996,7 +984,6 @@
 
   /// Cloned code from member result(), with changes.
   /// Delete existing result() function and rename, when status files are gone.
-  /// This code can return Expectation.ignore - we may want to fix that.
   Expectation realResult(TestCase testCase) {
     // Handle crashes and timeouts first.
     if (hasCrashed) return Expectation.crash;