commit 59df1ad2a76920e8776c1efee553ddbe1572e601
author Ben Konyi <bkonyi@google.com> Fri Aug 31 20:12:47 2018 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Fri Aug 31 20:12:47 2018 +0000
tree 982ba262c81016f1325ba147629dd9faf5a66246
parent b91ea9b7c5d8557603472f6c4fdb79abb74d0089

[ VM / dart:mirrors ] Mark private members of dart:* as non-reflectable (Issue #34194).

Change-Id: If3d79955c7bd336a54e3716d22e1c3c8ee2e07ee
Reviewed-on: https://dart-review.googlesource.com/72141
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>

runtime/vm/kernel_loader.cc

diff --git a/runtime/vm/kernel_loader.cc b/runtime/vm/kernel_loader.cc
index 17f062d..a7dd4cd 100644
--- a/runtime/vm/kernel_loader.cc
+++ b/runtime/vm/kernel_loader.cc
@@ -1385,6 +1385,12 @@
                               true,   // is_method
                               false,  // is_closure
                               &function_node_helper);
+
+    if (library.is_dart_scheme() &&
+        H.IsPrivate(constructor_helper.canonical_name_)) {
+      function.set_is_reflectable(false);
+    }
+
     if (constructor_helper.IsSynthetic()) {
       function.set_is_debuggable(false);
     }
@@ -1603,8 +1609,11 @@
     expression_evaluation_function_ = function.raw();
   }
   function.set_kernel_offset(procedure_offset);
-  function.set_is_reflectable(function.is_reflectable() &&
-                              library.raw() != Library::InternalLibrary());
+  if ((library.is_dart_scheme() &&
+       H.IsPrivate(procedure_helper.canonical_name_)) ||
+      (function.is_static() && (library.raw() == Library::InternalLibrary()))) {
+    function.set_is_reflectable(false);
+  }
 
   ActiveMemberScope active_member(&active_class_, &function);