[vm] Remove some dead code from the old front end.
Change-Id: I9c26cbc617b25dbd04e4dfd46a68307e88eec60e
Reviewed-on: https://dart-review.googlesource.com/c/92481
Reviewed-by: RĂ©gis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
diff --git a/runtime/vm/clustered_snapshot.cc b/runtime/vm/clustered_snapshot.cc
index 828aa45..8ae8739 100644
--- a/runtime/vm/clustered_snapshot.cc
+++ b/runtime/vm/clustered_snapshot.cc
@@ -1127,7 +1127,6 @@
s->Write<int32_t>(lib->ptr()->index_);
s->Write<uint16_t>(lib->ptr()->num_imports_);
s->Write<int8_t>(lib->ptr()->load_state_);
- s->Write<bool>(lib->ptr()->corelib_imported_);
s->Write<bool>(lib->ptr()->is_dart_scheme_);
s->Write<bool>(lib->ptr()->debuggable_);
if (s->kind() != Snapshot::kFullAOT) {
@@ -1169,7 +1168,6 @@
lib->ptr()->index_ = d->Read<int32_t>();
lib->ptr()->num_imports_ = d->Read<uint16_t>();
lib->ptr()->load_state_ = d->Read<int8_t>();
- lib->ptr()->corelib_imported_ = d->Read<bool>();
lib->ptr()->is_dart_scheme_ = d->Read<bool>();
lib->ptr()->debuggable_ = d->Read<bool>();
lib->ptr()->is_in_fullsnapshot_ = true;
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index e6b4217..53e3ea3 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -3978,11 +3978,6 @@
StorePointer(&raw_ptr()->interfaces_, value.raw());
}
-RawClass* Class::GetPatchClass() const {
- const Library& lib = Library::Handle(library());
- return lib.GetPatchClass(String::Handle(Name()));
-}
-
void Class::AddDirectImplementor(const Class& implementor,
bool is_mixin) const {
ASSERT(is_implemented());
@@ -4574,16 +4569,6 @@
return Field::null();
}
-RawLibraryPrefix* Class::LookupLibraryPrefix(const String& name) const {
- Zone* zone = Thread::Current()->zone();
- const Library& lib = Library::Handle(zone, library());
- const Object& obj = Object::Handle(zone, lib.LookupLocalObject(name));
- if (!obj.IsNull() && obj.IsLibraryPrefix()) {
- return LibraryPrefix::Cast(obj).raw();
- }
- return LibraryPrefix::null();
-}
-
const char* Class::ToCString() const {
const Library& lib = Library::Handle(library());
const char* library_name = lib.IsNull() ? "" : lib.ToCString();
@@ -9629,50 +9614,6 @@
return error.raw();
}
-void Library::AddPatchClass(const Class& cls) const {
- ASSERT(Thread::Current()->IsMutatorThread());
- ASSERT(cls.is_patch());
- ASSERT(GetPatchClass(String::Handle(cls.Name())) == Class::null());
- const GrowableObjectArray& patch_classes =
- GrowableObjectArray::Handle(this->patch_classes());
- patch_classes.Add(cls);
-}
-
-RawClass* Library::GetPatchClass(const String& name) const {
- ASSERT(Thread::Current()->IsMutatorThread());
- const GrowableObjectArray& patch_classes =
- GrowableObjectArray::Handle(this->patch_classes());
- Object& obj = Object::Handle();
- for (intptr_t i = 0; i < patch_classes.Length(); i++) {
- obj = patch_classes.At(i);
- if (obj.IsClass() &&
- (Class::Cast(obj).Name() == name.raw())) { // Names are canonicalized.
- return Class::RawCast(obj.raw());
- }
- }
- return Class::null();
-}
-
-void Library::RemovePatchClass(const Class& cls) const {
- ASSERT(Thread::Current()->IsMutatorThread());
- ASSERT(cls.is_patch());
- const GrowableObjectArray& patch_classes =
- GrowableObjectArray::Handle(this->patch_classes());
- const intptr_t num_classes = patch_classes.Length();
- intptr_t i = 0;
- while (i < num_classes) {
- if (cls.raw() == patch_classes.At(i)) break;
- i++;
- }
- if (i == num_classes) return;
- // Replace the entry with the script. We keep the script so that
- // Library::LoadedScripts() can find it without having to iterate
- // over the members of each class.
- ASSERT(i < num_classes); // We must have found a class.
- const Script& patch_script = Script::Handle(cls.script());
- patch_classes.SetAt(i, patch_script);
-}
-
static RawString* MakeClassMetaName(Thread* thread,
Zone* zone,
const Class& cls) {
@@ -10545,31 +10486,6 @@
return Namespace::RawCast(import_list.At(index));
}
-bool Library::ImportsCorelib() const {
- Zone* zone = Thread::Current()->zone();
- Library& imported = Library::Handle(zone);
- intptr_t count = num_imports();
- for (int i = 0; i < count; i++) {
- imported = ImportLibraryAt(i);
- if (imported.IsCoreLibrary()) {
- return true;
- }
- }
- LibraryPrefix& prefix = LibraryPrefix::Handle(zone);
- LibraryPrefixIterator it(*this);
- while (it.HasNext()) {
- prefix = it.GetNext();
- count = prefix.num_imports();
- for (int i = 0; i < count; i++) {
- imported = prefix.GetLibrary(i);
- if (imported.IsCoreLibrary()) {
- return true;
- }
- }
- }
- return false;
-}
-
void Library::DropDependenciesAndCaches() const {
StorePointer(&raw_ptr()->imports_, Object::empty_array().raw());
StorePointer(&raw_ptr()->exports_, Object::empty_array().raw());
@@ -10685,7 +10601,6 @@
result.set_native_entry_resolver(NULL);
result.set_native_entry_symbol_resolver(NULL);
result.set_is_in_fullsnapshot(false);
- result.StoreNonPointer(&result.raw_ptr()->corelib_imported_, true);
if (dart_private_scheme) {
// Never debug dart:_ libraries.
result.set_debuggable(false);
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 479827c..e37a4d8 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -950,14 +950,9 @@
// classes.
RawClass* SuperClass(bool original_classes = false) const;
- RawClass* GetPatchClass() const;
-
// Interfaces is an array of Types.
RawArray* interfaces() const { return raw_ptr()->interfaces_; }
void set_interfaces(const Array& value) const;
- static intptr_t interfaces_offset() {
- return OFFSET_OF(RawClass, interfaces_);
- }
// Returns the list of classes directly implementing this class.
RawGrowableObjectArray* direct_implementors() const {
@@ -1083,8 +1078,6 @@
RawField* LookupInstanceFieldAllowPrivate(const String& name) const;
RawField* LookupStaticFieldAllowPrivate(const String& name) const;
- RawLibraryPrefix* LookupLibraryPrefix(const String& name) const;
-
RawDouble* LookupCanonicalDouble(Zone* zone, double value) const;
RawMint* LookupCanonicalMint(Zone* zone, int64_t value) const;
@@ -3519,10 +3512,6 @@
void SetLoadError(const Instance& error) const;
RawInstance* TransitiveLoadError() const;
- void AddPatchClass(const Class& cls) const;
- RawClass* GetPatchClass(const String& name) const;
- void RemovePatchClass(const Class& cls) const;
-
static intptr_t InstanceSize() {
return RoundedAllocationSize(sizeof(RawLibrary));
}
@@ -3638,7 +3627,6 @@
intptr_t num_imports() const { return raw_ptr()->num_imports_; }
RawNamespace* ImportAt(intptr_t index) const;
RawLibrary* ImportLibraryAt(intptr_t index) const;
- bool ImportsCorelib() const;
void DropDependenciesAndCaches() const;
@@ -3684,8 +3672,6 @@
StoreNonPointer(&raw_ptr()->is_dart_scheme_, value);
}
- bool IsCoreLibrary() const { return raw() == CoreLibrary(); }
-
// Includes 'dart:async', 'dart:typed_data', etc.
bool IsAnyCoreLibrary() const;
diff --git a/runtime/vm/raw_object.h b/runtime/vm/raw_object.h
index a2b39dd..68f90fd 100644
--- a/runtime/vm/raw_object.h
+++ b/runtime/vm/raw_object.h
@@ -1160,7 +1160,6 @@
classid_t index_; // Library id number.
uint16_t num_imports_; // Number of entries in imports_.
int8_t load_state_; // Of type LibraryState.
- bool corelib_imported_;
bool is_dart_scheme_;
bool debuggable_; // True if debugger can stop in library.
bool is_in_fullsnapshot_; // True if library is in a full snapshot.