commit 3e9290df4f511a2d7c297aecee5b3c55c798139d
author Alexander Markov <alexmarkov@google.com> Thu Jun 09 14:21:33 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Thu Jun 09 14:21:33 2022 +0000
tree 85a4b2b51e6af24400f9cf2c0156024993f9ea61
parent 8d9009d610a21641154346b6b862c38f1e7a6fe5

[vm] Skip caching of function entry points in Thread in JIT mode

Cached entry points of core library functions are only used
in AOT mode (JIT mode uses Function/Code objects instead of entry
points in order to call those functions).

This change removes storing entry points into the Thread.
It fixes TSAN error which reports a data race between JIT compilation
which installs Code and caching of entry points when scheduling
a thread.

TEST=ci
Fixes https://github.com/dart-lang/sdk/issues/49194
Issue: https://github.com/dart-lang/sdk/issues/48378

Change-Id: Ib109118df414cd722001dad363e9e05a94ab0556
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247501
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>

runtime/vm/isolate.cc

diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 0429f80..d20cf54 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -614,12 +614,14 @@
     thread->isolate_ = nullptr;
     thread->isolate_group_ = this;
     thread->field_table_values_ = nullptr;
+#if defined(DART_PRECOMPILED_RUNTIME)
     if (object_store() != nullptr) {
 #define INIT_ENTRY_POINT(name)                                                 \
   thread->name##_entry_point_ = Function::EntryPointOf(object_store()->name());
       CACHED_FUNCTION_ENTRY_POINTS_LIST(INIT_ENTRY_POINT)
 #undef INIT_ENTRY_POINT
     }
+#endif  // defined(DART_PRECOMPILED_RUNTIME)
     ASSERT(heap() != nullptr);
     thread->heap_ = heap();
     thread->set_os_thread(os_thread);