commit 3bacc84c1e33860a43e64da5d4aabeb6ba84f919
author Stephen Adams <sra@google.com> Fri Jun 14 22:56:00 2019 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Fri Jun 14 22:56:00 2019 +0000
tree 63bf45ad5bab896f7edd29d5146286788010c05e
parent 177f4250125de04542c4c6054cea84dc380dabac

[js_runtime] Install general stubs

These stubs always throw so test should not pass for the wrong reason.

Change-Id: Ie9d00046d3c7e34b8b53798f1c20eb14807e8632
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106183
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>

sdk/lib/_internal/js_runtime/lib/rti.dart

diff --git a/sdk/lib/_internal/js_runtime/lib/rti.dart b/sdk/lib/_internal/js_runtime/lib/rti.dart
index a3480c2..5039386 100644
--- a/sdk/lib/_internal/js_runtime/lib/rti.dart
+++ b/sdk/lib/_internal/js_runtime/lib/rti.dart
@@ -5,7 +5,7 @@
 /// This library contains support for runtime type information.
 library rti;
 
-import 'dart:_foreign_helper' show JS;
+import 'dart:_foreign_helper' show JS, RAW_DART_FUNCTION_REF;
 import 'dart:_interceptors' show JSArray, JSUnmodifiableArray;
 
 /// An Rti object represents both a type (e.g `Map<int, String>`) and a type
@@ -220,6 +220,34 @@
   throw UnimplementedError('getRuntimeType');
 }
 
+/// Called from generated code.
+bool _generalIsTestImplementation(object) {
+  // This static method is installed on an Rti object as a JavaScript instance
+  // method. The Rti object is 'this'.
+  Rti testRti = _castToRti(JS('', 'this'));
+  throw UnimplementedError(
+      '${Error.safeToString(object)} is ${_rtiToString(testRti, null)}');
+}
+
+/// Called from generated code.
+_generalAsCheckImplementation(object) {
+  // This static method is installed on an Rti object as a JavaScript instance
+  // method. The Rti object is 'this'.
+  Rti testRti = _castToRti(JS('', 'this'));
+  throw UnimplementedError(
+      '${Error.safeToString(object)} as ${_rtiToString(testRti, null)}');
+}
+
+/// Called from generated code.
+_generalTypeCheckImplementation(object) {
+  // This static method is installed on an Rti object as a JavaScript instance
+  // method. The Rti object is 'this'.
+  Rti testRti = _castToRti(JS('', 'this'));
+  throw UnimplementedError(
+      '${Error.safeToString(object)} as ${_rtiToString(testRti, null)}'
+      ' (TypeError)');
+}
+
 String _rtiToString(Rti rti, List<String> genericContext) {
   int kind = Rti._getKind(rti);
 
@@ -382,12 +410,13 @@
     _cacheSet(evalCache(universe), key, rti);
 
     // Set up methods to type tests.
-    // TODO(sra): These are for `dynamic`. Install general functions and
-    // specializations.
-    var alwaysPasses = JS('', 'function(o) { return o; }');
-    Rti._setAsCheckFunction(rti, alwaysPasses);
-    Rti._setTypeCheckFunction(rti, alwaysPasses);
-    Rti._setIsTestFunction(rti, JS('', 'function(o) { return true; }'));
+    // TODO(sra): Install specializations.
+    Rti._setAsCheckFunction(
+        rti, RAW_DART_FUNCTION_REF(_generalAsCheckImplementation));
+    Rti._setTypeCheckFunction(
+        rti, RAW_DART_FUNCTION_REF(_generalTypeCheckImplementation));
+    Rti._setIsTestFunction(
+        rti, RAW_DART_FUNCTION_REF(_generalIsTestImplementation));
 
     return rti;
   }