Change how DDC writes text when summarize-text is enabled
The old way is very ineffecient (many small writes to the file system).
Initial build time for (redacted?) goes from ~40 seconds to ~19 seconds.
Change-Id: Id098f51f43627c5b0768ab9686caab26ba946caa
Reviewed-on: https://dart-review.googlesource.com/c/93411
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
diff --git a/pkg/dev_compiler/lib/src/kernel/command.dart b/pkg/dev_compiler/lib/src/kernel/command.dart
index e431f43..b3852c9 100644
--- a/pkg/dev_compiler/lib/src/kernel/command.dart
+++ b/pkg/dev_compiler/lib/src/kernel/command.dart
@@ -247,9 +247,9 @@
outFiles.add(sink.flush().then((_) => sink.close()));
}
if (argResults['summarize-text'] as bool) {
- var sink = File(output + '.txt').openWrite();
- kernel.Printer(sink, showExternal: false).writeComponentFile(component);
- outFiles.add(sink.flush().then((_) => sink.close()));
+ StringBuffer sb = new StringBuffer();
+ kernel.Printer(sb, showExternal: false).writeComponentFile(component);
+ outFiles.add(File(output + '.txt').writeAsString(sb.toString()));
}
var target = compilerState.options.target as DevCompilerTarget;
var compiler =
