commit 33485f8ef253174226f248e9da1f710a999b242d
author Ryan Macnak <rmacnak@google.com> Mon Oct 08 22:41:36 2018 +0000
committer Ryan Macnak <rmacnak@google.com> Mon Oct 08 22:41:36 2018 +0000
tree ac8134b88d21a12486bf80b42822cd14e5d9d781
parent 7f531b5112574b069c795f3138d94399400ee184

[standalone] Fix leak when the kernel service produces a compile-time error.

Bug: https://github.com/dart-lang/sdk/issues/32187
Change-Id: If845eec40fe013120455ac851395ee215a3ce0d2
Reviewed-on: https://dart-review.googlesource.com/c/78623
Reviewed-by: Siva Annamalai <asiva@google.com>

runtime/bin/dfe.cc

diff --git a/runtime/bin/dfe.cc b/runtime/bin/dfe.cc
index 5e58c20..7e18fef 100644
--- a/runtime/bin/dfe.cc
+++ b/runtime/bin/dfe.cc
@@ -209,14 +209,17 @@
       *exit_code = 0;
       break;
     case Dart_KernelCompilationStatus_Error:
+      free(result.kernel);
       *error = result.error;  // Copy error message.
       *exit_code = kCompilationErrorExitCode;
       break;
     case Dart_KernelCompilationStatus_Crash:
+      free(result.kernel);
       *error = result.error;  // Copy error message.
       *exit_code = kDartFrontendErrorExitCode;
       break;
     case Dart_KernelCompilationStatus_Unknown:
+      free(result.kernel);
       *error = result.error;  // Copy error message.
       *exit_code = kErrorExitCode;
       break;