Add comment to dartdevc's test compiler configuration
It explains the intent behind testing `--dart-sdk` vs just
`--dart-sdk-summary` and adds a TODO about how we can improve it.
Change-Id: Ib53027a6509e4df0df52632345c32d9bdfccd991
Reviewed-on: https://dart-review.googlesource.com/64764
Reviewed-by: Bob Nystrom <rnystrom@google.com>
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 439f46c..f3635c7 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -492,6 +492,15 @@
.absolute
.toNativePath();
+ // If we're testing a built SDK use the SDK path. This will test that we can
+ // find the summary file from that. For local development we don't have a
+ // built SDK yet, so point directly at the built summary file.
+ //
+ // TODO(jmesserly): ideally we'd test the `dartdevc` script/.bat file.
+ // That's the closest to what users/tools use. That script has its own way
+ // of computing `--dart-sdk` and passing it to DDC. For simplicitly that
+ // script should be passing `--dart-sdk-summary`, that way DDC doesn't need
+ // two options for the same thing.
var args = _useSdk
? ["--dart-sdk", "${_configuration.buildDirectory}/dart-sdk"]
: ["--dart-sdk-summary", sdkSummary];
