commit 2972ca61f8accbb1d98a23720d43e19c22a0e236
author Jens Johansen <jensj@google.com> Thu Jun 14 14:06:09 2018 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Thu Jun 14 14:06:09 2018 +0000
tree 86260c88e3fc288fd9bba534a47728eadc0ef4bb
parent c54a302495a560d19fe0a9df1d78b3947c7aabcc

Fix continue in invalidation logic

When invalidating changed files in frontend server, the state prior to
this CL was that a continue would jump to the next byte, not the next file
after it had seen that the file had changed. Thus it could possibly
invalidate the same file several times.

Change-Id: If6fb1042248d26a3ffe905b39fa3c3603198ca37
Reviewed-on: https://dart-review.googlesource.com/60245
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>

pkg/vm/lib/frontend_server.dart

diff --git a/pkg/vm/lib/frontend_server.dart b/pkg/vm/lib/frontend_server.dart
index 2993e42..9d5797b 100644
--- a/pkg/vm/lib/frontend_server.dart
+++ b/pkg/vm/lib/frontend_server.dart
@@ -385,25 +385,26 @@
       return null;
     }
 
+    nextUri:
     for (Uri uri in component.uriToSource.keys) {
-      if (uri == null || '$uri' == '') continue;
+      if (uri == null || '$uri' == '') continue nextUri;
 
       final List<int> oldBytes = component.uriToSource[uri].source;
       final FileSystemEntity entity =
           _compilerOptions.fileSystem.entityForUri(uri);
       if (!await entity.exists()) {
         _generator.invalidate(uri);
-        continue;
+        continue nextUri;
       }
       final List<int> newBytes = await entity.readAsBytes();
       if (oldBytes.length != newBytes.length) {
         _generator.invalidate(uri);
-        continue;
+        continue nextUri;
       }
       for (int i = 0; i < oldBytes.length; ++i) {
         if (oldBytes[i] != newBytes[i]) {
           _generator.invalidate(uri);
-          continue;
+          continue nextUri;
         }
       }
     }