Update a pair of analyzer tests
The static type of invocations of methods from class Object on
receivers with static type dynamic has changed. Clean up a pair of
analyzer tests that expected the previous behavior and were expected
to fail because the analyzer already implemented the intended
behavior.
Change-Id: I7a65fa4e46a0da51bcf1c183a7c30f0976baaef5
Reviewed-on: https://dart-review.googlesource.com/58205
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
diff --git a/pkg/analyzer/test/generated/strong_mode_kernel_test.dart b/pkg/analyzer/test/generated/strong_mode_kernel_test.dart
index 763d120..61abc60 100644
--- a/pkg/analyzer/test/generated/strong_mode_kernel_test.dart
+++ b/pkg/analyzer/test/generated/strong_mode_kernel_test.dart
@@ -275,18 +275,6 @@
bool get useCFE => true;
@override
- test_dynamicObjectGetter_hashCode() async {
- // Fails with non-kernel analyzer but works correctly with kernel.
- await super.test_dynamicObjectGetter_hashCode();
- }
-
- @override
- test_dynamicObjectMethod_toString() async {
- // Fails with non-kernel analyzer but works correctly with kernel.
- await super.test_dynamicObjectMethod_toString();
- }
-
- @override
test_futureOr_promotion3() async {
// Test passes even though the overridden method fails.
await super.test_futureOr_promotion3();
diff --git a/pkg/analyzer/test/generated/strong_mode_test.dart b/pkg/analyzer/test/generated/strong_mode_test.dart
index ab24845..1414b83 100644
--- a/pkg/analyzer/test/generated/strong_mode_test.dart
+++ b/pkg/analyzer/test/generated/strong_mode_test.dart
@@ -2814,7 +2814,6 @@
resetWith(options: options);
}
- @failingTest // https://github.com/dart-lang/sdk/issues/32173
test_dynamicObjectGetter_hashCode() async {
String code = r'''
main() {
@@ -2823,10 +2822,9 @@
}
''';
await resolveTestUnit(code);
- expectInitializerType('foo', 'dynamic', isNull);
+ expectInitializerType('foo', 'int', isNull);
}
- @failingTest // https://github.com/dart-lang/sdk/issues/32173
test_dynamicObjectMethod_toString() async {
String code = r'''
main() {
@@ -2835,7 +2833,7 @@
}
''';
await resolveTestUnit(code);
- expectInitializerType('foo', 'dynamic', isNull);
+ expectInitializerType('foo', 'String', isNull);
}
test_futureOr_promotion1() async {
