[gardening] Skip app-jitk tests which evaluate source and therefore need IKG
Change-Id: I80c834174ea95ff9272a1904d747f2b265b2b2c1
Reviewed-on: https://dart-review.googlesource.com/69304
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
diff --git a/runtime/observatory/tests/service/service_kernel.status b/runtime/observatory/tests/service/service_kernel.status
index 7ca721d..11d5ce2 100644
--- a/runtime/observatory/tests/service/service_kernel.status
+++ b/runtime/observatory/tests/service/service_kernel.status
@@ -4,7 +4,7 @@
[ $compiler == app_jitk ]
add_breakpoint_rpc_test: RuntimeError
-async_generator_breakpoint_test: RuntimeError
+async_generator_breakpoint_test: Skip # No incremental compiler available.
async_next_regession_18877_test: RuntimeError
async_next_test: RuntimeError
async_scope_test: RuntimeError
@@ -17,7 +17,7 @@
awaiter_async_stack_contents_2_test: RuntimeError
awaiter_async_stack_contents_test: RuntimeError
bad_reload_test: RuntimeError
-break_on_activation_test: RuntimeError
+break_on_activation_test: Skip # No incremental compiler available.
break_on_function_test: RuntimeError
breakpoint_in_parts_class_test: RuntimeError
breakpoint_two_args_checked_test: RuntimeError
@@ -26,35 +26,35 @@
causal_async_star_stack_contents_test: RuntimeError
causal_async_star_stack_presence_test: RuntimeError
complex_reload_test: RuntimeError
-debugger_inspect_test: Skip # Timeout
+debugger_inspect_test: Skip # No incremental compiler available.
debugger_location_second_test: RuntimeError
debugger_location_test: RuntimeError
debugging_inlined_finally_test: RuntimeError
debugging_test: RuntimeError
-developer_service_get_isolate_id_test: RuntimeError
-eval_internal_class_test: RuntimeError
-eval_test: RuntimeError
+developer_service_get_isolate_id_test: Skip # No incremental compiler available.
+eval_internal_class_test: Skip # No incremental compiler available.
+eval_regression_flutter20255_test: Skip # No incremental compiler available.
+eval_test: Skip # No incremental compiler available.
evaluate_activation_in_method_class_test: RuntimeError
-evaluate_activation_test/instance: RuntimeError
-evaluate_activation_test/none: RuntimeError
-evaluate_activation_test/scope: RuntimeError
-evaluate_async_closure_test: RuntimeError
+evaluate_activation_test: Skip # No incremental compiler available.
+evaluate_async_closure_test: Skip # No incremental compiler available.
evaluate_class_type_parameters_test: RuntimeError
evaluate_in_async_activation_test: RuntimeError
evaluate_in_async_star_activation_test: RuntimeError
evaluate_in_frame_rpc_test: RuntimeError
-evaluate_in_frame_with_scope_test: RuntimeError
+evaluate_in_frame_with_scope_test: Skip # No incremental compiler available.
evaluate_in_sync_star_activation_test: RuntimeError
-evaluate_with_scope_test: RuntimeError
-get_instances_rpc_test: RuntimeError
-get_object_rpc_test: RuntimeError
-get_retaining_path_rpc_test: RuntimeError
+evaluate_with_scope_test: Skip # No incremental compiler available.
+get_instances_rpc_test: Skip # No incremental compiler available.
+get_object_rpc_test: Skip # No incremental compiler available.
+get_retained_size_rpc_test: Skip # No incremental compiler available.
+get_retaining_path_rpc_test: Skip # No incremental compiler available.
get_source_report_test: RuntimeError
get_stack_rpc_test: RuntimeError
-get_user_level_retaining_path_rpc_test: RuntimeError
+get_user_level_retaining_path_rpc_test: Skip # No incremental compiler available.
get_vm_rpc_test: RuntimeError
get_vm_timeline_rpc_test: RuntimeError
-instance_field_order_rpc_test: RuntimeError
+instance_field_order_rpc_test: Skip # No incremental compiler available.
issue_25465_test: RuntimeError
issue_27238_test: RuntimeError
issue_27287_test: RuntimeError
@@ -83,7 +83,7 @@
next_through_simple_linear_2_test: RuntimeError
next_through_simple_linear_test: RuntimeError
parameters_in_scope_at_entry_test: RuntimeError
-pause_on_exceptions_test: Skip # Timeout
+pause_on_exceptions_test: Skip # No incremental compiler available.
pause_on_unhandled_async_exceptions2_test: RuntimeError
pause_on_unhandled_async_exceptions_test: RuntimeError
positive_token_pos_test: RuntimeError
@@ -219,7 +219,7 @@
[ $compiler == dartk && ($arch == simarm || $arch == simarm64 || $arch == simdbc64) ]
add_breakpoint_rpc_kernel_test: RuntimeError # Issue #33087
-async_generator_breakpoint_test: Pass, RuntimeError, Crash # dartbug.com/33175 for the crash
+async_generator_breakpoint_test: Skip # No incremental compiler available.
async_single_step_out_test: RuntimeError
bad_reload_test: Skip # Times out on sim architectures, also RuntimeError.
break_on_activation_test: RuntimeError # Issue #33087
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index a5efa33..0449837 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -10276,7 +10276,8 @@
if (kind() == RawScript::kKernelTag) {
const TypedData& line_starts_data = TypedData::Handle(line_starts());
- if (line_starts_data.IsNull()) {
+ const String& source = String::Handle(Source());
+ if (line_starts_data.IsNull() || source.IsNull()) {
// Scripts in the AOT snapshot do not have a line starts array.
*first_token_index = TokenPosition::kNoSource;
*last_token_index = TokenPosition::kNoSource;
@@ -10285,9 +10286,8 @@
#if !defined(DART_PRECOMPILED_RUNTIME)
kernel::KernelLineStartsReader line_starts_reader(
line_starts_data, Thread::Current()->zone());
- line_starts_reader.TokenRangeAtLine(String::Handle(Source()).Length(),
- line_number, first_token_index,
- last_token_index);
+ line_starts_reader.TokenRangeAtLine(source.Length(), line_number,
+ first_token_index, last_token_index);
#endif // !defined(DART_PRECOMPILED_RUNTIME)
return;
}
