Enforce override annotations in dart2js
Update the excludes in the test directory analysis options to match the
files that were not updated to add override annotations.
Update the excludes in `testing.json` to match the analysis options.
With a consistent analysis options test config the diagnostics in
editors will match what is enforced by the test.
Also clean up the no longer required `enableSuperMixins` config.
Change-Id: If0e23642c25e0b5c1aced6a5a8c8c05a6da538f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96836
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
diff --git a/pkg/compiler/analysis_options.yaml b/pkg/compiler/analysis_options.yaml
index af22f6b..deba0e5 100644
--- a/pkg/compiler/analysis_options.yaml
+++ b/pkg/compiler/analysis_options.yaml
@@ -10,3 +10,7 @@
deprecated_member_use: ignore
# Allow deprecated calls from within the same package
deprecated_member_use_from_same_package: ignore
+
+linter:
+ rules:
+ - annotate_overrides
diff --git a/pkg/compiler/testing.json b/pkg/compiler/testing.json
index d5fb717..498a45c 100644
--- a/pkg/compiler/testing.json
+++ b/pkg/compiler/testing.json
@@ -14,7 +14,9 @@
],
"exclude": [
- "^tests/compiler/dart2js/inference/data/super_invoke\\.dart"
+ "^tests/compiler/dart2js/.*/data/.*",
+ "^tests/compiler/dart2js/.*/model_data/.*",
+ "^tests/compiler/dart2js/deferred_loading/libs/.*"
]
}
}
diff --git a/tests/compiler/dart2js/analysis_options.yaml b/tests/compiler/dart2js/analysis_options.yaml
index 40dc4a9..efa1621 100644
--- a/tests/compiler/dart2js/analysis_options.yaml
+++ b/tests/compiler/dart2js/analysis_options.yaml
@@ -3,13 +3,15 @@
# BSD-style license that can be found in the LICENSE file.
analyzer:
- language:
- enableSuperMixins: false
-
errors:
todo: ignore
deprecated_member_use: ignore
exclude:
- - data/*
- - sourcemaps/data/*
+ - '**/data/*'
+ - '**/model_data/*'
+ - 'deferred_loading/libs/*'
+
+linter:
+ rules:
+ - annotate_overrides
