commit 283cabf1a1ae7c784f5e073cd1566e417a9ce1b4
author Jonas Termansen <sortie@google.com> Fri Mar 08 09:39:12 2019 +0000
committer Jonas Termansen <sortie@google.com> Fri Mar 08 09:39:12 2019 +0000
tree 0fc0812d116208f52ef4cd6b07c6b540117b2f5b
parent 299c6457cfc1b0132c4d29d9dfa0a82a3870f9c1

[infra] Reject unexpected extra arguments in approve_results.

Change-Id: I441572d5e6d99aa3f3ff3427f8562fa417405d09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95643
Reviewed-by: William Hesse <whesse@google.com>

tools/approve_results.dart

diff --git a/tools/approve_results.dart b/tools/approve_results.dart
index 2279db2..7f72a2d 100755
--- a/tools/approve_results.dart
+++ b/tools/approve_results.dart
@@ -305,6 +305,12 @@
     return;
   }
 
+  if (options.rest.isNotEmpty) {
+    stderr.writeln("Unexpected extra argument: ${options.rest.first}");
+    exitCode = 1;
+    return;
+  }
+
   // Locate gsutil.py.
   gsutilPy =
       Platform.script.resolve("../third_party/gsutil/gsutil.py").toFilePath();