commit 27df933bd10ccd5176937a85f4a8226debcb4ea8
author Paul Berry <paulberry@google.com> Mon May 13 12:51:30 2019 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Mon May 13 12:51:30 2019 +0000
tree 5c276e1b32fc135b500a06901ed7f45295189aec
parent f7e288e3ad63f844848996618b3f1e93e565a128

Fix some hints in the analyzer package.

Change-Id: I46dd91ef2a78dffc08f2fdb45d9646a966a3315d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102380
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>

pkg/analyzer/lib/src/summary2/ast_binary_writer.dart

diff --git a/pkg/analyzer/lib/src/summary2/ast_binary_writer.dart b/pkg/analyzer/lib/src/summary2/ast_binary_writer.dart
index e766a07..abc1356 100644
--- a/pkg/analyzer/lib/src/summary2/ast_binary_writer.dart
+++ b/pkg/analyzer/lib/src/summary2/ast_binary_writer.dart
@@ -257,6 +257,7 @@
 //      commentReference_identifier: identifier.accept(this),
 //      commentReference_newKeyword: _getToken(node.newKeyword),
 //    );
+    return null;
   }
 
   @override

pkg/analyzer/test/src/workspace/package_build_test.dart

diff --git a/pkg/analyzer/test/src/workspace/package_build_test.dart b/pkg/analyzer/test/src/workspace/package_build_test.dart
index 0f8017b..ef5bd9f 100644
--- a/pkg/analyzer/test/src/workspace/package_build_test.dart
+++ b/pkg/analyzer/test/src/workspace/package_build_test.dart
@@ -9,7 +9,6 @@
 import 'package:analyzer/src/test_utilities/resource_provider_mixin.dart';
 import 'package:analyzer/src/workspace/package_build.dart';
 import 'package:package_config/packages.dart';
-import 'package:path/path.dart' as path;
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
@@ -266,7 +265,6 @@
     newFile('/workspace/project/lib/file2.dart');
     var package = workspace
         .findPackageFor(convertPath('/workspace/project/lib/code.dart'));
-    var file2Path = convertPath('/workspace/project/lib/file2.dart');
     var file2Source = InSummarySource(
         Uri.parse('package:project/file2.dart'), '' /* summaryPath */);
     expect(package.contains(file2Source), isTrue);
@@ -277,7 +275,6 @@
     newFile('/workspace/project/lib/file2.dart');
     var package = workspace
         .findPackageFor(convertPath('/workspace/project/lib/code.dart'));
-    var file2Path = convertPath('/workspace/project2/lib/file2.dart');
     var file2Source = InSummarySource(
         Uri.parse('package:project2/file2.dart'), '' /* summaryPath */);
     expect(package.contains(file2Source), isFalse);