Analyze all the pkg/ code on the bots.
Bug: https://github.com/dart-lang/sdk/issues/29318
Change-Id: Iccb16ddbccbb43fa7a12eb818c2dde3a75700b97
Reviewed-on: https://dart-review.googlesource.com/64663
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: William Hesse <whesse@google.com>
diff --git a/pkg/analyzer_cli/analysis_options.yaml b/pkg/analyzer_cli/analysis_options.yaml
index 301f0e6..b8b8389 100644
--- a/pkg/analyzer_cli/analysis_options.yaml
+++ b/pkg/analyzer_cli/analysis_options.yaml
@@ -1,6 +1,6 @@
analyzer:
exclude:
- - 'test/data'
+ - test/data/**
linter:
rules:
#- annotate_overrides
diff --git a/pkg/analyzer_cli/test/data/analysis_options.yaml b/pkg/analyzer_cli/test/data/analysis_options.yaml
new file mode 100644
index 0000000..2cfcfa6
--- /dev/null
+++ b/pkg/analyzer_cli/test/data/analysis_options.yaml
@@ -0,0 +1,2 @@
+# This empty analysis options file creates a new analysis context in order to
+# isolate the tests from the settings in //pkg/analyzer_cli/analysis_options.yaml.
diff --git a/runtime/observatory/.analysis_options b/runtime/observatory/analysis_options.yaml
similarity index 100%
rename from runtime/observatory/.analysis_options
rename to runtime/observatory/analysis_options.yaml
diff --git a/runtime/observatory/lib/src/repositories/target.dart b/runtime/observatory/lib/src/repositories/target.dart
index ad06731..245542d 100644
--- a/runtime/observatory/lib/src/repositories/target.dart
+++ b/runtime/observatory/lib/src/repositories/target.dart
@@ -51,7 +51,7 @@
_store();
}
- Iterable<M.Target> list() => _list.toList<M.Target>();
+ Iterable<M.Target> list() => _list.toList();
void setCurrent(M.Target t) {
SC.WebSocketVMTarget target = t as SC.WebSocketVMTarget;
diff --git a/runtime/observatory/pubspec.yaml b/runtime/observatory/pubspec.yaml
new file mode 100644
index 0000000..c1dcd02
--- /dev/null
+++ b/runtime/observatory/pubspec.yaml
@@ -0,0 +1 @@
+name: observatory
diff --git a/tools/bots/test_matrix.json b/tools/bots/test_matrix.json
index b38d7b9..ab78eda 100644
--- a/tools/bots/test_matrix.json
+++ b/tools/bots/test_matrix.json
@@ -1929,30 +1929,145 @@
"script": "tools/build.py",
"arguments": ["create_sdk"]
},
+
{
- "name": "Analyze pkg/analysis_server",
+ "name": "analyze pkg/analysis_server",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
- "arguments": ["--no-hints","pkg/analysis_server"]
+ "arguments": ["pkg/analysis_server"]
},
{
- "name": "Analyze pkg/analyzer",
+ "name": "analyze pkg/analysis_server_client",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
- "arguments": ["--no-hints","pkg/analyzer"]
+ "arguments": ["pkg/analysis_server_client"]
},
{
- "name": "analyze tests",
- "arguments": [
- "--compiler=dart2analyzer",
- "--use-sdk"
- ]
+ "name": "analyze pkg/analyzer",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/analyzer"]
},
{
- "name": "analyze pkg tests",
- "arguments": [
- "--compiler=dart2analyzer",
- "--use-sdk",
- "pkg"
- ]
+ "name": "analyze pkg/analyzer_cli",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/analyzer_cli"]
+ },
+ {
+ "name": "analyze pkg/analyzer_plugin",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/analyzer_plugin"]
+ },
+ {
+ "name": "analyze pkg/async_helper",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/async_helper"]
+ },
+ {
+ "name": "analyze pkg/build_integration",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/build_integration"]
+ },
+ {
+ "name": "analyze pkg/compiler",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/compiler"]
+ },
+ {
+ "name": "analyze pkg/dart_internal",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/dart_internal"]
+ },
+ {
+ "name": "analyze pkg/dart_messages",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/dart_messages"]
+ },
+ {
+ "name": "analyze pkg/dev_compiler",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/dev_compiler"]
+ },
+ {
+ "name": "analyze pkg/expect",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/expect"]
+ },
+ {
+ "name": "analyze pkg/front_end",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/front_end"]
+ },
+ {
+ "name": "analyze pkg/js",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/js"]
+ },
+ {
+ "name": "analyze pkg/js_ast",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/js_ast"]
+ },
+ {
+ "name": "analyze pkg/kernel",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/kernel"]
+ },
+ {
+ "name": "analyze pkg/meta",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/meta"]
+ },
+ {
+ "name": "analyze pkg/microlytics",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/microlytics"]
+ },
+ {
+ "name": "analyze pkg/smith",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/smith"]
+ },
+ {
+ "name": "analyze pkg/sourcemap_testing",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/sourcemap_testing"]
+ },
+ {
+ "name": "analyze pkg/status_file",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/status_file"]
+ },
+ {
+ "name": "analyze pkg/telemetry",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/telemetry"]
+ },
+ {
+ "name": "analyze pkg/testing",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/testing"]
+ },
+ {
+ "name": "analyze pkg/vm",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["pkg/vm"]
+ },
+ {
+ "name": "analyze tools/gardening",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["tools/gardening"]
+ },
+ {
+ "name": "analyze tools/testing/dart",
+ "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
+ "arguments": ["tools/testing/dart"]
+ },
+
+ {
+ "name": "dartanalyzer --batch tests",
+ "arguments": [ "--compiler=dart2analyzer", "--use-sdk" ]
+ },
+ {
+ "name": "dartanalyzer --batch pkg tests",
+ "arguments": [ "--compiler=dart2analyzer", "--use-sdk", "pkg" ]
}
]
},
@@ -1971,7 +2086,6 @@
"name": "analyze pkg/analysis_server",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
"arguments": [
- "--no-hints",
"--use-fasta-parser",
"pkg/analysis_server"
]
@@ -1980,18 +2094,16 @@
"name": "analyze pkg/analyzer",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
"arguments": [
- "--no-hints",
"--use-fasta-parser",
"pkg/analyzer"
]
},
{
- "name": "analyze pkg/analyzer_cli/lib",
+ "name": "analyze pkg/analyzer_cli",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
"arguments": [
- "--no-hints",
"--use-fasta-parser",
- "pkg/analyzer_cli/lib"
+ "pkg/analyzer_cli"
]
},
{
