Recover correctly from this-parameter on non-constructors.
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2727313004 .
diff --git a/pkg/front_end/lib/src/fasta/builder/procedure_builder.dart b/pkg/front_end/lib/src/fasta/builder/procedure_builder.dart
index 64f19a7..fc62cee 100644
--- a/pkg/front_end/lib/src/fasta/builder/procedure_builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/procedure_builder.dart
@@ -69,7 +69,7 @@
if (formals == null) return parent;
Map<String, Builder> local = <String, Builder>{};
for (FormalParameterBuilder formal in formals) {
- if (!formal.hasThis) {
+ if (!isConstructor || !formal.hasThis) {
local[formal.name] = formal;
}
}
diff --git a/tests/co19/co19-kernel.status b/tests/co19/co19-kernel.status
index dbb4908..c7dda2b 100644
--- a/tests/co19/co19-kernel.status
+++ b/tests/co19/co19-kernel.status
@@ -29,12 +29,6 @@
Language/Classes/Constructors/Generative_Constructors/formal_parameter_t08: MissingCompileTimeError
Language/Classes/Constructors/Generative_Constructors/initializers_t12: MissingCompileTimeError
Language/Classes/Constructors/Generative_Constructors/initializing_formals_execution_t02: RuntimeError # Dartk Issue 28566
-Language/Classes/Constructors/Generative_Constructors/initializing_other_function_t01: DartkCrash
-Language/Classes/Constructors/Generative_Constructors/initializing_other_function_t02: DartkCrash
-Language/Classes/Constructors/Generative_Constructors/initializing_other_function_t03: DartkCrash
-Language/Classes/Constructors/Generative_Constructors/initializing_other_function_t04: DartkCrash
-Language/Classes/Constructors/Generative_Constructors/initializing_other_function_t05: DartkCrash
-Language/Classes/Constructors/Generative_Constructors/initializing_other_function_t06: DartkCrash
Language/Classes/Constructors/Generative_Constructors/redirection_t02: MissingCompileTimeError
Language/Classes/Constructors/Generative_Constructors/redirection_t03: MissingCompileTimeError
Language/Classes/Constructors/Generative_Constructors/redirection_t07: MissingCompileTimeError
@@ -355,8 +349,6 @@
Language/Functions/Formal_Parameters/Required_Formals/syntax_t07: MissingCompileTimeError
Language/Functions/Formal_Parameters/Required_Formals/syntax_t08: MissingCompileTimeError
Language/Functions/Formal_Parameters/Required_Formals/syntax_t09: MissingCompileTimeError
-Language/Functions/Formal_Parameters/Required_Formals/syntax_t10: DartkCrash
-Language/Functions/Formal_Parameters/Required_Formals/syntax_t11: DartkCrash
Language/Functions/Formal_Parameters/declare_as_constant_t01: MissingCompileTimeError
Language/Functions/Formal_Parameters/declare_as_constant_t02: MissingCompileTimeError
Language/Functions/Formal_Parameters/declare_as_constant_t03: MissingCompileTimeError
diff --git a/tests/language/language_kernel.status b/tests/language/language_kernel.status
index 718c90c..4d58159 100644
--- a/tests/language/language_kernel.status
+++ b/tests/language/language_kernel.status
@@ -532,10 +532,6 @@
number_identifier_test/02: MissingCompileTimeError
number_identifier_test/04: MissingCompileTimeError
on_catch_malformed_type_test: RuntimeError
-parameter_initializer1_negative_test: DartkCrash
-parameter_initializer2_negative_test: DartkCrash
-parameter_initializer3_negative_test: DartkCrash
-parameter_initializer4_negative_test: DartkCrash
parameter_initializer6_negative_test: Fail
part2_test: RuntimeError
prefix13_negative_test: Fail
@@ -553,7 +549,6 @@
regress_22438_test: RuntimeError
regress_22443_test: RuntimeError # Deferred Loading Issue 28335
regress_23408_test: RuntimeError # Deferred Loading Issue 28335
-regress_26855_test/0: DartkCrash
regress_27617_test/1: MissingCompileTimeError
regress_27957_test: RuntimeError
regress_28217_test/01: MissingCompileTimeError
