| commit | f37fdef1c2d1b5e08a64cdc4909091764094c3b7 | [log] [tgz] |
|---|---|---|
| author | Ryan Macnak <rmacnak@google.com> | Mon Aug 19 23:46:32 2019 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Mon Aug 19 23:46:32 2019 +0000 |
| tree | 0c5fcb8b63c2818c0be096f07e86f84103b4653d | |
| parent | 5087b993610ec8125a1f594617e9fa8d64ecc510 [diff] |
[vm, service] Fix out-of-bounds access when processing requestHeapSnapshot's arguments. As detected by the ASAN bots. Change-Id: Ia10ad883afe886d573f0fa32c2096f9e0ac07083 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113757 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc index 7981794..d212875 100644 --- a/runtime/vm/service.cc +++ b/runtime/vm/service.cc
@@ -4064,6 +4064,7 @@ static const MethodParameter* request_heap_snapshot_params[] = { RUNNABLE_ISOLATE_PARAMETER, + NULL, }; static bool RequestHeapSnapshot(Thread* thread, JSONStream* js) {