commit bb47e41ab203a8b571b3b18cf8a8ff89bb1048ce
author pq <pquitslund@google.com> Wed Apr 27 00:29:34 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Wed Apr 27 00:29:34 2022 +0000
tree a5db6174f4f0a00f49295f31ab619b43d4b5d8ff
parent 68fa0e96d0b0ed5547c02a91e0f845e8c1b1d826

rename local functions with `_`s

These will be flagged by the next linter release which updates `non_constant_identifier_names` to flag local functions.

Change-Id: I873400f61748a145f3c2a6630a21bcd1975c309c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242503
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>

pkg/native_stack_traces/lib/src/elf.dart

diff --git a/pkg/native_stack_traces/lib/src/elf.dart b/pkg/native_stack_traces/lib/src/elf.dart
index ac7cb50..c29b1e4 100644
--- a/pkg/native_stack_traces/lib/src/elf.dart
+++ b/pkg/native_stack_traces/lib/src/elf.dart
@@ -1045,7 +1045,7 @@
       entry.setName(sectionHeaderStringTable);
       sectionsByName.putIfAbsent(entry.name, () => {}).add(section);
     }
-    void _cacheSymbolNames(String stringTableTag, String symbolTableTag) {
+    void cacheSymbolNames(String stringTableTag, String symbolTableTag) {
       final stringTables = sectionsByName[stringTableTag]?.cast<StringTable>();
       if (stringTables == null) {
         return;
@@ -1068,8 +1068,8 @@
       }
     }
 
-    _cacheSymbolNames('.strtab', '.symtab');
-    _cacheSymbolNames('.dynstr', '.dynsym');
+    cacheSymbolNames('.strtab', '.symtab');
+    cacheSymbolNames('.dynstr', '.dynsym');
     // Set the wordSize and endian of the original reader before returning.
     elfReader.wordSize = reader.wordSize;
     elfReader.endian = reader.endian;