commit b99f016b148fc828a479535181615dfa02601e23
author Martin Kustermann <kustermann@google.com> Mon Apr 19 14:11:38 2021 +0000
committer Alexander Thomas <athom@google.com> Mon Apr 26 14:23:53 2021 +0200
tree fd691463f365fef9d7007ca26637cde23c6fcbf6
parent d9e96c1d4aa37ef790dbea3f434622b8ca1188d6

[vm] Fix constant in PcRelativeCall pattern on x64

This fixes windows build which has different integer size
so the literal constant makes a difference.

This is a follow-up to [0] which added a test that revealed this
issue.

[0] https://dart-review.googlesource.com/c/sdk/+/195682

TEST=Fixes vm/cc/PCRelativeCallPatterns on windows.

Change-Id: I82403753126e95b86ccca5de039fd703b61a119b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195921
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

runtime/vm/instructions_x64.h

diff --git a/runtime/vm/instructions_x64.h b/runtime/vm/instructions_x64.h
index ce23054..a65ba55 100644
--- a/runtime/vm/instructions_x64.h
+++ b/runtime/vm/instructions_x64.h
@@ -187,8 +187,8 @@
 
 class PcRelativeTailCallPattern : public PcRelativeTrampolineJumpPattern {
  public:
-  static constexpr intptr_t kLowerCallingRange = -(1ul << 31) + kLengthInBytes;
-  static constexpr intptr_t kUpperCallingRange = (1ul << 31) - 1;
+  static constexpr intptr_t kLowerCallingRange = -(DART_INT64_C(1) << 31) + kLengthInBytes;
+  static constexpr intptr_t kUpperCallingRange = (DART_INT64_C(1) << 31) - 1;
 
   explicit PcRelativeTailCallPattern(uword pc)
       : PcRelativeTrampolineJumpPattern(pc) {}