blob: 2bf24505a9e20a222e8cbf0b4d2fef695bfe57cf [file] [log] [blame]
// Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/visitor.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/error/error.dart';
import '../analyzer.dart';
const _desc =
r"Don't reassign references to parameters of functions or methods.";
bool _isDefaultFormalParameterWithDefaultValue(FormalParameter parameter) =>
parameter is DefaultFormalParameter && parameter.defaultValue != null;
bool _isFormalParameterReassigned(
FormalParameter parameter,
AssignmentExpression assignment,
) {
var leftHandSide = assignment.leftHandSide;
return leftHandSide is SimpleIdentifier &&
leftHandSide.element == parameter.declaredFragment?.element;
}
class ParameterAssignments extends LintRule {
ParameterAssignments()
: super(name: LintNames.parameter_assignments, description: _desc);
@override
DiagnosticCode get diagnosticCode => LinterLintCode.parameter_assignments;
@override
void registerNodeProcessors(
NodeLintRegistry registry,
LinterContext context,
) {
var visitor = _Visitor(this);
registry.addFunctionDeclaration(this, visitor);
registry.addMethodDeclaration(this, visitor);
}
}
class _DeclarationVisitor extends RecursiveAstVisitor<void> {
final FormalParameter parameter;
final LintRule rule;
final bool paramIsNotNullByDefault;
final bool paramDefaultsToNull;
bool hasBeenAssigned = false;
_DeclarationVisitor(
this.parameter,
this.rule, {
required this.paramIsNotNullByDefault,
required this.paramDefaultsToNull,
});
Element? get parameterElement => parameter.declaredFragment?.element;
void checkPatternElements(DartPattern node) {
NodeList<PatternField>? fields;
if (node is RecordPattern) fields = node.fields;
if (node is ObjectPattern) fields = node.fields;
if (fields != null) {
for (var field in fields) {
if (field.pattern.element == parameterElement) {
reportLint(node);
}
}
} else {
List<AstNode>? elements;
if (node is ListPattern) elements = node.elements;
if (node is MapPattern) elements = node.elements;
if (elements == null) return;
for (var element in elements) {
if (element is MapPatternEntry) {
element = element.value;
}
if (element.element == parameterElement) {
reportLint(node);
}
}
}
}
void reportLint(AstNode node) {
rule.reportAtNode(node, arguments: [parameter.name!.lexeme]);
}
@override
visitAssignmentExpression(AssignmentExpression node) {
if (paramIsNotNullByDefault) {
if (_isFormalParameterReassigned(parameter, node)) {
reportLint(node);
}
} else if (paramDefaultsToNull) {
if (_isFormalParameterReassigned(parameter, node)) {
if (hasBeenAssigned) {
reportLint(node);
}
hasBeenAssigned = true;
}
}
super.visitAssignmentExpression(node);
}
@override
visitPatternAssignment(PatternAssignment node) {
checkPatternElements(node.pattern);
super.visitPatternAssignment(node);
}
@override
visitPostfixExpression(PostfixExpression node) {
if (paramIsNotNullByDefault) {
var operand = node.operand;
if (operand is SimpleIdentifier && operand.element == parameterElement) {
reportLint(node);
}
}
super.visitPostfixExpression(node);
}
@override
visitPrefixExpression(PrefixExpression node) {
if (paramIsNotNullByDefault) {
var operand = node.operand;
if (operand is SimpleIdentifier && operand.element == parameterElement) {
reportLint(node);
}
}
super.visitPrefixExpression(node);
}
}
class _Visitor extends SimpleAstVisitor<void> {
final LintRule rule;
_Visitor(this.rule);
@override
void visitFunctionDeclaration(FunctionDeclaration node) {
_checkParameters(
node.functionExpression.parameters,
node.functionExpression.body,
);
}
@override
void visitMethodDeclaration(MethodDeclaration node) {
_checkParameters(node.parameters, node.body);
}
void _checkParameters(FormalParameterList? parameterList, FunctionBody body) {
if (parameterList == null) return;
for (var parameter in parameterList.parameters) {
var declaredElement = parameter.declaredFragment?.element;
if (declaredElement != null &&
body.isPotentiallyMutatedInScope2(declaredElement)) {
var paramIsNotNullByDefault =
parameter is SimpleFormalParameter ||
_isDefaultFormalParameterWithDefaultValue(parameter);
var paramDefaultsToNull =
parameter is DefaultFormalParameter &&
parameter.defaultValue == null;
if (paramDefaultsToNull || paramIsNotNullByDefault) {
body.accept(
_DeclarationVisitor(
parameter,
rule,
paramDefaultsToNull: paramDefaultsToNull,
paramIsNotNullByDefault: paramIsNotNullByDefault,
),
);
}
}
}
}
}
extension on AstNode {
Element? get element => switch (this) {
AssignedVariablePattern(:var element2) => element2,
_ => null,
};
}