commit ab9ccf1e4e685efcb2ab8b82fc37eac131fbc4c6
author Alexander Aprelev <aam@google.com> Thu Apr 22 21:53:56 2021 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Thu Apr 22 21:53:56 2021 +0000
tree 9157629b0513db7ec4c368378b095a431f9f816a
parent f72a31695ca99e9ea1da140e6bda767b786126ca

[vm] Use memory_order type argument provided for Array At/SetAt.


Issue https://github.com/dart-lang/sdk/issues/45170

TEST=ci

Change-Id: I8583a0df77914c4dc69a5b4565124a21a46421cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196562
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>

runtime/vm/object.h

diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 8a6fec2..a654826 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -9837,12 +9837,12 @@
 
   template <std::memory_order order = std::memory_order_relaxed>
   ObjectPtr At(intptr_t index) const {
-    return untag()->element(index);
+    return untag()->element<order>(index);
   }
   template <std::memory_order order = std::memory_order_relaxed>
   void SetAt(intptr_t index, const Object& value) const {
     // TODO(iposva): Add storing NoSafepointScope.
-    untag()->set_element(index, value.ptr());
+    untag()->set_element<order>(index, value.ptr());
   }
 
   // Access to the array with acquire release semantics.