Allow Dart DevTools to be embedded in Chrome DevTools.
Change-Id: Iff97f9dbc432ed926d668ac8339c32b679e316ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232482
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
diff --git a/pkg/dds/lib/devtools_server.dart b/pkg/dds/lib/devtools_server.dart
index 185876e..0a267d6 100644
--- a/pkg/dds/lib/devtools_server.dart
+++ b/pkg/dds/lib/devtools_server.dart
@@ -201,7 +201,7 @@
bool debugMode = false,
bool launchBrowser = false,
bool enableNotifications = false,
- bool allowEmbedding = false,
+ bool allowEmbedding = true,
bool headlessMode = false,
bool verboseMode = false,
String? hostname,
@@ -268,6 +268,9 @@
final _server = server!;
if (allowEmbedding) {
_server.defaultResponseHeaders.remove('x-frame-options', 'SAMEORIGIN');
+ // The origin-agent-cluster header is required to support the embedding of
+ // Dart DevTools in Chrome DevTools.
+ _server.defaultResponseHeaders.add('origin-agent-cluster', '?1');
}
// Ensure browsers don't cache older versions of the app.
