commit a3478da7faa334564642406bd58fe5413190508c
author Oleh Prypin <oprypin@google.com> Mon Apr 11 15:42:01 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Mon Apr 11 15:42:01 2022 +0000
tree 7f5a67751767c4dc553628cef04be689c0f280a0
parent 3d27f5cb79245720363d1b1c44d467b99e8f1d49

Resolve clang-tidy warnings 'readability-redundant-smartptr-get'

4 instances of the following issue: redundant get() call on smart pointer

Tested: Only through CI. There are no changes in behavior, all possible problems would be found through a compilation failure.
Change-Id: Ib11432baef83d3daebd800b365183e1ea6621136
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240540
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Oleh Prypin <oprypin@google.com>

runtime/bin/main.cc

diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index 52beba4..2196982 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -224,7 +224,7 @@
     result = DartUtils::ResolveScript(Dart_NewStringFromCString(script_uri));
     if (Dart_IsError(result)) goto failed;
 
-    if (isolate_group_data->kernel_buffer().get() != nullptr) {
+    if (isolate_group_data->kernel_buffer() != nullptr) {
       // Various core-library parts will send requests to the Loader to resolve
       // relative URIs and perform other related tasks. We need Loader to be
       // initialized for this to work because loading from Kernel binary

runtime/bin/secure_socket_filter.cc

diff --git a/runtime/bin/secure_socket_filter.cc b/runtime/bin/secure_socket_filter.cc
index a78b635..8a3fb56 100644
--- a/runtime/bin/secure_socket_filter.cc
+++ b/runtime/bin/secure_socket_filter.cc
@@ -583,8 +583,8 @@
                          DartUtils::GetNativeBooleanArgument(args, 2)));
   if (SSL_LOG_STATUS) {
     Syslog::Print("Mark %p as %strusted certificate\n",
-                  certificate_trust_state_.get()->x509(),
-                  certificate_trust_state_.get()->is_trusted() ? "" : "not ");
+                  certificate_trust_state_->x509(),
+                  certificate_trust_state_->is_trusted() ? "" : "not ");
   }
 }
 

runtime/vm/isolate.cc

diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 6541884..ae4909f 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -2647,7 +2647,7 @@
 
   // Post message before LowLevelShutdown that sends onExit message.
   // This ensures that exit message comes last.
-  if (bequest_.get() != nullptr) {
+  if (bequest_ != nullptr) {
     auto beneficiary = bequest_->beneficiary();
     auto handle = bequest_->TakeHandle();
     PortMap::PostMessage(

runtime/vm/isolate_reload.cc

diff --git a/runtime/vm/isolate_reload.cc b/runtime/vm/isolate_reload.cc
index a04ea6f..1386624 100644
--- a/runtime/vm/isolate_reload.cc
+++ b/runtime/vm/isolate_reload.cc
@@ -588,7 +588,7 @@
     NoActiveIsolateScope no_active_isolate_scope;
 
     ExternalTypedData& external_typed_data =
-        ExternalTypedData::Handle(Z, kernel_program.get()->typed_data()->ptr());
+        ExternalTypedData::Handle(Z, kernel_program->typed_data()->ptr());
     IsolateGroupSource* source = IsolateGroup::Current()->source();
     source->add_loaded_blob(Z, external_typed_data);