Revert "Pass absolute path to git (redux)."
This reverts commit 9d638b8a9a48c7bae854685f9413d2c40a4911a1.
BUG=
Review URL: https://codereview.chromium.org//11361158
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14661 260f80e4-7a28-3924-810f-c04153c831b5
diff --git a/utils/pub/git_source.dart b/utils/pub/git_source.dart
index 5d7e2d7..6327638 100644
--- a/utils/pub/git_source.dart
+++ b/utils/pub/git_source.dart
@@ -148,12 +148,6 @@
* remote repository. See the manpage for `git clone` for more information.
*/
Future _clone(String from, String to, {bool mirror: false}) {
- // TODO(rnystrom): For some mysterious reason, the Windows buildbots do not
- // have the right working directory when pub spawns git, so the relative
- // path fails. To work around it, just always pass in a full path. Should
- // figure out what's going on here.
- from = getFullPath(from);
-
// Git on Windows does not seem to automatically create the destination
// directory.
return ensureDir(to).chain((_) {
diff --git a/utils/pub/io.dart b/utils/pub/io.dart
index 212a30e..cccedfc17 100644
--- a/utils/pub/io.dart
+++ b/utils/pub/io.dart
@@ -373,18 +373,12 @@
});
}
-/// Given [entry] which may be a [String], [File], or [Directory] relative to
-/// the current working directory, returns its full canonicalized path.
-String getFullPath(entry) {
- var path = new Path(_getPath(entry));
-
- // Don't do anything if it's already absolute.
- if (path.isAbsolute) return path.toNativePath();
-
- // Using Path.join here instead of File().fullPathSync() because the former
- // does not require an actual file to exist at that path.
- return new Path.fromNative(workingDir).join(path).toNativePath();
-}
+/**
+ * Given [entry] which may be a [String], [File], or [Directory] relative to
+ * the current working directory, returns its full canonicalized path.
+ */
+// TODO(rnystrom): Should this be async?
+String getFullPath(entry) => new File(_getPath(entry)).fullPathSync();
// TODO(nweiz): make this configurable
/**
diff --git a/utils/tests/pub/pub.status b/utils/tests/pub/pub.status
index dceefef..86562b7 100644
--- a/utils/tests/pub/pub.status
+++ b/utils/tests/pub/pub.status
@@ -10,7 +10,8 @@
[ $runtime == drt || $runtime == dartium || $runtime == opera]
*: Skip
-# Git on Windows is embarrassingly slow.
+# Git on Windows is cripplingly slow (#5271).
+# Git tests do not work on Windows on buildbots (dartbug.com/6191).
[ $system == windows ]
-install/git/*: Slow, Pass
-update/git/*: Slow, Pass
+install/git/*: Skip
+update/git/*: Skip
