blob: 29b3920b0722f86837bf626cb9847791e130b65a [file] [log] [blame]
// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
library test.services.correction.assist;
import 'dart:async';
import 'package:analysis_server/plugin/edit/assist/assist_core.dart';
import 'package:analysis_server/plugin/edit/assist/assist_dart.dart';
import 'package:analysis_server/plugin/protocol/protocol.dart';
import 'package:analysis_server/src/plugin/server_plugin.dart';
import 'package:analysis_server/src/services/correction/assist.dart';
import 'package:analysis_server/src/services/correction/assist_internal.dart';
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/standard_resolution_map.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/source/package_map_resolver.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/source.dart';
import 'package:plugin/manager.dart';
import 'package:plugin/plugin.dart';
import 'package:test/test.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
import '../../abstract_single_unit.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(AssistProcessorTest);
defineReflectiveTests(AssistProcessorTest_Driver);
});
}
@reflectiveTest
class AssistProcessorTest extends AbstractSingleUnitTest {
int offset;
int length;
ServerPlugin plugin;
Assist assist;
SourceChange change;
String resultCode;
LinkedEditGroup linkedPositionGroup;
String flutterPkgLibPath = '/packages/flutter/lib';
String get _flutter_framework_code => '''
class Widget {}
class RenderObjectWidget extends Widget {}
class StatelessWidget extends Widget {}
class SingleChildRenderObjectWidget extends RenderObjectWidget {}
class Transform extends SingleChildRenderObjectWidget {}
class ClipRect extends SingleChildRenderObjectWidget { ClipRect.rect(){} }
class AspectRatio extends SingleChildRenderObjectWidget {}
class Container extends StatelessWidget { Container({child: null, width: null, height: null}){}}
class Center extends StatelessWidget { Center({child: null, key: null}){}}
class DefaultTextStyle extends StatelessWidget { DefaultTextStyle({child: null}){}}
class Row extends Widget { Row({children: null}){}}
class GestureDetector extends SingleChildRenderObjectWidget { GestureDetector({child: null, onTap: null}){}}
class Scaffold extends Widget { Scaffold({body: null}){}}
''';
/**
* Asserts that there is an [Assist] of the given [kind] at [offset] which
* produces the [expected] code when applied to [testCode].
*/
assertHasAssist(AssistKind kind, String expected) async {
assist = await _assertHasAssist(kind);
change = assist.change;
// apply to "file"
List<SourceFileEdit> fileEdits = change.edits;
expect(fileEdits, hasLength(1));
resultCode = SourceEdit.applySequence(testCode, change.edits[0].edits);
// verify
expect(resultCode, expected);
}
/**
* Calls [assertHasAssist] at the offset of [offsetSearch] in [testCode].
*/
assertHasAssistAt(
String offsetSearch, AssistKind kind, String expected) async {
offset = findOffset(offsetSearch);
await assertHasAssist(kind, expected);
}
/**
* Asserts that there is no [Assist] of the given [kind] at [offset].
*/
assertNoAssist(AssistKind kind) async {
List<Assist> assists = await _computeAssists();
for (Assist assist in assists) {
if (assist.kind == kind) {
throw fail('Unexpected assist $kind in\n${assists.join('\n')}');
}
}
}
/**
* Calls [assertNoAssist] at the offset of [offsetSearch] in [testCode].
*/
assertNoAssistAt(String offsetSearch, AssistKind kind) async {
offset = findOffset(offsetSearch);
await assertNoAssist(kind);
}
Position expectedPosition(String search) {
int offset = resultCode.indexOf(search);
return new Position(testFile, offset);
}
List<Position> expectedPositions(List<String> patterns) {
List<Position> positions = <Position>[];
patterns.forEach((String search) {
positions.add(expectedPosition(search));
});
return positions;
}
List<LinkedEditSuggestion> expectedSuggestions(
LinkedEditSuggestionKind kind, List<String> values) {
return values.map((value) {
return new LinkedEditSuggestion(value, kind);
}).toList();
}
void processRequiredPlugins() {
plugin = new ServerPlugin();
List<Plugin> plugins = <Plugin>[];
plugins.addAll(AnalysisEngine.instance.requiredPlugins);
plugins.add(plugin);
ExtensionManager manager = new ExtensionManager();
manager.processPlugins(plugins);
}
void setUp() {
super.setUp();
offset = 0;
length = 0;
}
test_addTypeAnnotation_BAD_privateType_closureParameter() async {
addSource(
'/my_lib.dart',
'''
library my_lib;
class A {}
class _B extends A {}
foo(f(_B p)) {}
''');
await resolveTestUnit('''
import 'my_lib.dart';
main() {
foo((test) {});
}
''');
await assertNoAssistAt('test)', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_BAD_privateType_declaredIdentifier() async {
addSource(
'/my_lib.dart',
'''
library my_lib;
class A {}
class _B extends A {}
List<_B> getValues() => [];
''');
await resolveTestUnit('''
import 'my_lib.dart';
class A<T> {
main() {
for (var item in getValues()) {
}
}
}
''');
await assertNoAssistAt('var item', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_BAD_privateType_list() async {
addSource(
'/my_lib.dart',
'''
library my_lib;
class A {}
class _B extends A {}
List<_B> getValues() => [];
''');
await resolveTestUnit('''
import 'my_lib.dart';
main() {
var v = getValues();
}
''');
await assertNoAssistAt('var ', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_BAD_privateType_variable() async {
addSource(
'/my_lib.dart',
'''
library my_lib;
class A {}
class _B extends A {}
_B getValue() => new _B();
''');
await resolveTestUnit('''
import 'my_lib.dart';
main() {
var v = getValue();
}
''');
await assertNoAssistAt('var ', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_classField_OK_final() async {
await resolveTestUnit('''
class A {
final f = 0;
}
''');
await assertHasAssistAt(
'final ',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
class A {
final int f = 0;
}
''');
}
test_addTypeAnnotation_classField_OK_int() async {
await resolveTestUnit('''
class A {
var f = 0;
}
''');
await await assertHasAssistAt(
'var ',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
class A {
int f = 0;
}
''');
}
test_addTypeAnnotation_declaredIdentifier_BAD_hasTypeAnnotation() async {
await resolveTestUnit('''
main(List<String> items) {
for (String item in items) {
}
}
''');
await assertNoAssistAt('item in', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_declaredIdentifier_BAD_inForEachBody() async {
await resolveTestUnit('''
main(List<String> items) {
for (var item in items) {
42;
}
}
''');
await assertNoAssistAt('42;', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_declaredIdentifier_BAD_unknownType() async {
verifyNoTestUnitErrors = false;
await resolveTestUnit('''
main() {
for (var item in unknownList) {
}
}
''');
await assertNoAssistAt('item in', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_declaredIdentifier_generic_OK() async {
await resolveTestUnit('''
class A<T> {
main(List<List<T>> items) {
for (var item in items) {
}
}
}
''');
await assertHasAssistAt(
'item in',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
class A<T> {
main(List<List<T>> items) {
for (List<T> item in items) {
}
}
}
''');
}
test_addTypeAnnotation_declaredIdentifier_OK() async {
await resolveTestUnit('''
main(List<String> items) {
for (var item in items) {
}
}
''');
// on identifier
await assertHasAssistAt(
'item in',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
main(List<String> items) {
for (String item in items) {
}
}
''');
// on "for"
await assertHasAssistAt(
'for (',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
main(List<String> items) {
for (String item in items) {
}
}
''');
}
test_addTypeAnnotation_declaredIdentifier_OK_addImport_dartUri() async {
addSource(
'/my_lib.dart',
r'''
import 'dart:async';
List<Future<int>> getFutures() => null;
''');
await resolveTestUnit('''
import 'my_lib.dart';
main() {
for (var future in getFutures()) {
}
}
''');
await assertHasAssistAt(
'future in',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
import 'dart:async';
import 'my_lib.dart';
main() {
for (Future<int> future in getFutures()) {
}
}
''');
}
test_addTypeAnnotation_declaredIdentifier_OK_final() async {
await resolveTestUnit('''
main(List<String> items) {
for (final item in items) {
}
}
''');
await assertHasAssistAt(
'item in',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
main(List<String> items) {
for (final String item in items) {
}
}
''');
}
test_addTypeAnnotation_local_BAD_bottom() async {
await resolveTestUnit('''
main() {
var v = throw 42;
}
''');
await assertNoAssistAt('var ', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_local_BAD_hasTypeAnnotation() async {
await resolveTestUnit('''
main() {
int v = 42;
}
''');
await assertNoAssistAt(' = 42', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_local_BAD_multiple() async {
await resolveTestUnit('''
main() {
var a = 1, b = '';
}
''');
await assertNoAssistAt('var ', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_local_BAD_noValue() async {
verifyNoTestUnitErrors = false;
await resolveTestUnit('''
main() {
var v;
}
''');
await assertNoAssistAt('var ', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_local_BAD_null() async {
await resolveTestUnit('''
main() {
var v = null;
}
''');
await assertNoAssistAt('var ', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_local_BAD_onInitializer() async {
await resolveTestUnit('''
main() {
var abc = 0;
}
''');
await assertNoAssistAt('0;', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_local_BAD_unknown() async {
verifyNoTestUnitErrors = false;
await resolveTestUnit('''
main() {
var v = unknownVar;
}
''');
await assertNoAssistAt('var ', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_local_generic_OK_literal() async {
await resolveTestUnit('''
class A {
main(List<int> items) {
var v = items;
}
}
''');
await assertHasAssistAt(
'v =',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
class A {
main(List<int> items) {
List<int> v = items;
}
}
''');
}
test_addTypeAnnotation_local_generic_OK_local() async {
await resolveTestUnit('''
class A<T> {
main(List<T> items) {
var v = items;
}
}
''');
await assertHasAssistAt(
'v =',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
class A<T> {
main(List<T> items) {
List<T> v = items;
}
}
''');
}
test_addTypeAnnotation_local_OK_addImport_dartUri() async {
addSource(
'/my_lib.dart',
r'''
import 'dart:async';
Future<int> getFutureInt() => null;
''');
await resolveTestUnit('''
import 'my_lib.dart';
main() {
var v = getFutureInt();
}
''');
await assertHasAssistAt(
'v =',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
import 'dart:async';
import 'my_lib.dart';
main() {
Future<int> v = getFutureInt();
}
''');
}
test_addTypeAnnotation_local_OK_addImport_notLibraryUnit() async {
// prepare library
addSource(
'/my_lib.dart',
r'''
import 'dart:async';
Future<int> getFutureInt() => null;
''');
// prepare code
String appCode = r'''
library my_app;
import 'my_lib.dart';
part 'test.dart';
''';
testCode = r'''
part of my_app;
main() {
var v = getFutureInt();
}
''';
// add sources
Source appSource = addSource('/app.dart', appCode);
testSource = addSource('/test.dart', testCode);
// resolve
if (enableNewAnalysisDriver) {
await resolveTestUnit(testCode);
} else {
context.resolveCompilationUnit2(appSource, appSource);
testUnit = context.resolveCompilationUnit2(testSource, appSource);
testUnitElement = testUnit.element;
testLibraryElement = testUnitElement.library;
}
// prepare the assist
offset = findOffset('v = ');
assist = await _assertHasAssist(DartAssistKind.ADD_TYPE_ANNOTATION);
change = assist.change;
// verify
{
var testFileEdit = change.getFileEdit('/app.dart');
var resultCode = SourceEdit.applySequence(appCode, testFileEdit.edits);
expect(
resultCode,
'''
library my_app;
import 'dart:async';
import 'my_lib.dart';
part 'test.dart';
''');
}
{
var testFileEdit = change.getFileEdit('/test.dart');
var resultCode = SourceEdit.applySequence(testCode, testFileEdit.edits);
expect(
resultCode,
'''
part of my_app;
main() {
Future<int> v = getFutureInt();
}
''');
}
}
test_addTypeAnnotation_local_OK_addImport_relUri() async {
addSource(
'/aa/bbb/lib_a.dart',
r'''
class MyClass {}
''');
addSource(
'/ccc/lib_b.dart',
r'''
import '../aa/bbb/lib_a.dart';
MyClass newMyClass() => null;
''');
await resolveTestUnit('''
import 'ccc/lib_b.dart';
main() {
var v = newMyClass();
}
''');
await assertHasAssistAt(
'v =',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
import 'aa/bbb/lib_a.dart';
import 'ccc/lib_b.dart';
main() {
MyClass v = newMyClass();
}
''');
}
test_addTypeAnnotation_local_OK_Function() async {
await resolveTestUnit('''
main() {
var v = () => 1;
}
''');
await assertHasAssistAt(
'v =',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
main() {
Function v = () => 1;
}
''');
}
test_addTypeAnnotation_local_OK_int() async {
await resolveTestUnit('''
main() {
var v = 0;
}
''');
await assertHasAssistAt(
'v =',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
main() {
int v = 0;
}
''');
}
test_addTypeAnnotation_local_OK_List() async {
await resolveTestUnit('''
main() {
var v = <String>[];
}
''');
await assertHasAssistAt(
'v =',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
main() {
List<String> v = <String>[];
}
''');
}
test_addTypeAnnotation_local_OK_localType() async {
await resolveTestUnit('''
class C {}
C f() => null;
main() {
var x = f();
}
''');
await assertHasAssistAt(
'x =',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
class C {}
C f() => null;
main() {
C x = f();
}
''');
}
test_addTypeAnnotation_local_OK_onName() async {
await resolveTestUnit('''
main() {
var abc = 0;
}
''');
await assertHasAssistAt(
'bc',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
main() {
int abc = 0;
}
''');
}
test_addTypeAnnotation_local_OK_onVar() async {
await resolveTestUnit('''
main() {
var v = 0;
}
''');
await assertHasAssistAt(
'var ',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
main() {
int v = 0;
}
''');
}
test_addTypeAnnotation_OK_privateType_sameLibrary() async {
await resolveTestUnit('''
class _A {}
_A getValue() => new _A();
main() {
var v = getValue();
}
''');
await assertHasAssistAt(
'var ',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
class _A {}
_A getValue() => new _A();
main() {
_A v = getValue();
}
''');
}
test_addTypeAnnotation_parameter_BAD_hasExplicitType() async {
await resolveTestUnit('''
foo(f(int p)) {}
main() {
foo((num test) {});
}
''');
await assertNoAssistAt('test', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_parameter_BAD_noPropagatedType() async {
await resolveTestUnit('''
foo(f(p)) {}
main() {
foo((test) {});
}
''');
await assertNoAssistAt('test', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_parameter_OK() async {
await resolveTestUnit('''
foo(f(int p)) {}
main() {
foo((test) {});
}
''');
await assertHasAssistAt(
'test',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
foo(f(int p)) {}
main() {
foo((int test) {});
}
''');
}
test_addTypeAnnotation_topLevelField_BAD_multiple() async {
await resolveTestUnit('''
var A = 1, V = '';
''');
await assertNoAssistAt('var ', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_topLevelField_BAD_noValue() async {
await resolveTestUnit('''
var V;
''');
await assertNoAssistAt('var ', DartAssistKind.ADD_TYPE_ANNOTATION);
}
test_addTypeAnnotation_topLevelField_OK_int() async {
await resolveTestUnit('''
var V = 0;
''');
await assertHasAssistAt(
'var ',
DartAssistKind.ADD_TYPE_ANNOTATION,
'''
int V = 0;
''');
}
test_assignToLocalVariable() async {
await resolveTestUnit('''
main() {
List<int> bytes;
readBytes();
}
List<int> readBytes() => <int>[];
''');
await assertHasAssistAt(
'readBytes();',
DartAssistKind.ASSIGN_TO_LOCAL_VARIABLE,
'''
main() {
List<int> bytes;
var readBytes = readBytes();
}
List<int> readBytes() => <int>[];
''');
_assertLinkedGroup(
change.linkedEditGroups[0],
['readBytes = '],
expectedSuggestions(LinkedEditSuggestionKind.VARIABLE,
['list', 'bytes2', 'readBytes']));
}
test_assignToLocalVariable_alreadyAssignment() async {
await resolveTestUnit('''
main() {
var vvv;
vvv = 42;
}
''');
await assertNoAssistAt('vvv =', DartAssistKind.ASSIGN_TO_LOCAL_VARIABLE);
}
test_assignToLocalVariable_inClosure() async {
await resolveTestUnit(r'''
main() {
print(() {
12345;
});
}
''');
await assertHasAssistAt(
'345',
DartAssistKind.ASSIGN_TO_LOCAL_VARIABLE,
'''
main() {
print(() {
var i = 12345;
});
}
''');
}
test_assignToLocalVariable_invocationArgument() async {
await resolveTestUnit(r'''
main() {
f(12345);
}
void f(p) {}
''');
await assertNoAssistAt('345', DartAssistKind.ASSIGN_TO_LOCAL_VARIABLE);
}
test_assignToLocalVariable_throw() async {
await resolveTestUnit('''
main() {
throw 42;
}
''');
await assertNoAssistAt('throw ', DartAssistKind.ASSIGN_TO_LOCAL_VARIABLE);
}
test_assignToLocalVariable_void() async {
await resolveTestUnit('''
main() {
f();
}
void f() {}
''');
await assertNoAssistAt('f();', DartAssistKind.ASSIGN_TO_LOCAL_VARIABLE);
}
test_convertDocumentationIntoBlock_BAD_alreadyBlock() async {
await resolveTestUnit('''
/**
* AAAAAAA
*/
class A {}
''');
await assertNoAssistAt(
'AAA', DartAssistKind.CONVERT_DOCUMENTATION_INTO_BLOCK);
}
test_convertDocumentationIntoBlock_BAD_notDocumentation() async {
await resolveTestUnit('''
// AAAA
class A {}
''');
await assertNoAssistAt(
'AAA', DartAssistKind.CONVERT_DOCUMENTATION_INTO_BLOCK);
}
test_convertDocumentationIntoBlock_OK_noSpaceBeforeText() async {
await resolveTestUnit('''
class A {
/// AAAAA
///BBBBB
///
/// CCCCC
mmm() {}
}
''');
await assertHasAssistAt(
'AAAAA',
DartAssistKind.CONVERT_DOCUMENTATION_INTO_BLOCK,
'''
class A {
/**
* AAAAA
*BBBBB
*
* CCCCC
*/
mmm() {}
}
''');
}
test_convertDocumentationIntoBlock_OK_onReference() async {
await resolveTestUnit('''
/// AAAAAAA [int] AAAAAAA
class A {}
''');
await assertHasAssistAt(
'nt]',
DartAssistKind.CONVERT_DOCUMENTATION_INTO_BLOCK,
'''
/**
* AAAAAAA [int] AAAAAAA
*/
class A {}
''');
}
test_convertDocumentationIntoBlock_OK_onText() async {
await resolveTestUnit('''
class A {
/// AAAAAAA [int] AAAAAAA
/// BBBBBBBB BBBB BBBB
/// CCC [A] CCCCCCCCCCC
mmm() {}
}
''');
await assertHasAssistAt(
'AAA [',
DartAssistKind.CONVERT_DOCUMENTATION_INTO_BLOCK,
'''
class A {
/**
* AAAAAAA [int] AAAAAAA
* BBBBBBBB BBBB BBBB
* CCC [A] CCCCCCCCCCC
*/
mmm() {}
}
''');
}
test_convertDocumentationIntoLine_BAD_alreadyLine() async {
await resolveTestUnit('''
/// AAAAAAA
class A {}
''');
await assertNoAssistAt(
'AAA', DartAssistKind.CONVERT_DOCUMENTATION_INTO_LINE);
}
test_convertDocumentationIntoLine_BAD_notDocumentation() async {
await resolveTestUnit('''
/* AAAA */
class A {}
''');
await assertNoAssistAt(
'AAA', DartAssistKind.CONVERT_DOCUMENTATION_INTO_LINE);
}
test_convertDocumentationIntoLine_OK_onReference() async {
await resolveTestUnit('''
/**
* AAAAAAA [int] AAAAAAA
*/
class A {}
''');
await assertHasAssistAt(
'nt]',
DartAssistKind.CONVERT_DOCUMENTATION_INTO_LINE,
'''
/// AAAAAAA [int] AAAAAAA
class A {}
''');
}
test_convertDocumentationIntoLine_OK_onText() async {
await resolveTestUnit('''
class A {
/**
* AAAAAAA [int] AAAAAAA
* BBBBBBBB BBBB BBBB
* CCC [A] CCCCCCCCCCC
*/
mmm() {}
}
''');
await assertHasAssistAt(
'AAA [',
DartAssistKind.CONVERT_DOCUMENTATION_INTO_LINE,
'''
class A {
/// AAAAAAA [int] AAAAAAA
/// BBBBBBBB BBBB BBBB
/// CCC [A] CCCCCCCCCCC
mmm() {}
}
''');
}
test_convertDocumentationIntoLine_OK_onText_hasFirstLine() async {
await resolveTestUnit('''
class A {
/** AAAAAAA [int] AAAAAAA
* BBBBBBBB BBBB BBBB
* CCC [A] CCCCCCCCCCC
*/
mmm() {}
}
''');
await assertHasAssistAt(
'AAA [',
DartAssistKind.CONVERT_DOCUMENTATION_INTO_LINE,
'''
class A {
/// AAAAAAA [int] AAAAAAA
/// BBBBBBBB BBBB BBBB
/// CCC [A] CCCCCCCCCCC
mmm() {}
}
''');
}
test_convertFlutterChild_OK_multiLine() async {
_configureFlutterPkg({
'src/widgets/framework.dart': _flutter_framework_code,
});
await resolveTestUnit('''
import 'package:flutter/src/widgets/framework.dart';
build() {
return new Scaffold(
// start
body: new Center(
/*caret*/child: new Container(
width: 200.0,
height: 300.0,
),
key: null,
),
// end
);
}
''');
_setCaretLocation();
await assertHasAssist(
DartAssistKind.CONVERT_FLUTTER_CHILD,
'''
import 'package:flutter/src/widgets/framework.dart';
build() {
return new Scaffold(
// start
body: new Center(
/*caret*/children: <Widget>[
new Container(
width: 200.0,
height: 300.0,
),
],
key: null,
),
// end
);
}
''');
}
test_convertFlutterChild_OK_newlineChild() async {
// This case could occur with deeply nested constructors, common in Flutter.
_configureFlutterPkg({
'src/widgets/framework.dart': _flutter_framework_code,
});
await resolveTestUnit('''
import 'package:flutter/src/widgets/framework.dart';
build() {
return new Scaffold(
// start
body: new Center(
/*caret*/child:
new Container(
width: 200.0,
height: 300.0,
),
key: null,
),
// end
);
}
''');
_setCaretLocation();
await assertHasAssist(
DartAssistKind.CONVERT_FLUTTER_CHILD,
'''
import 'package:flutter/src/widgets/framework.dart';
build() {
return new Scaffold(
// start
body: new Center(
/*caret*/children: <Widget>[
new Container(
width: 200.0,
height: 300.0,
),
],
key: null,
),
// end
);
}
''');
}
test_convertFlutterChild_OK_singleLine() async {
_configureFlutterPkg({
'src/widgets/framework.dart': _flutter_framework_code,
});
await resolveTestUnit('''
import 'package:flutter/src/widgets/framework.dart';
build() {
return new Scaffold(
// start
body: new Center(
/*caret*/child: new GestureDetector(),
key: null,
),
// end
);
}
''');
_setCaretLocation();
await assertHasAssist(
DartAssistKind.CONVERT_FLUTTER_CHILD,
'''
import 'package:flutter/src/widgets/framework.dart';
build() {
return new Scaffold(
// start
body: new Center(
/*caret*/children: <Widget>[new GestureDetector()],
key: null,
),
// end
);
}
''');
}
test_convertToBlockBody_BAD_noEnclosingFunction() async {
await resolveTestUnit('''
var v = 123;
''');
await assertNoAssistAt('v =', DartAssistKind.CONVERT_INTO_BLOCK_BODY);
}
test_convertToBlockBody_BAD_notExpressionBlock() async {
await resolveTestUnit('''
fff() {
return 123;
}
''');
await assertNoAssistAt('fff() {', DartAssistKind.CONVERT_INTO_BLOCK_BODY);
}
test_convertToBlockBody_OK_async() async {
await resolveTestUnit('''
class A {
mmm() async => 123;
}
''');
await assertHasAssistAt(
'mmm()',
DartAssistKind.CONVERT_INTO_BLOCK_BODY,
'''
class A {
mmm() async {
return 123;
}
}
''');
}
test_convertToBlockBody_OK_closure() async {
await resolveTestUnit('''
setup(x) {}
main() {
setup(() => 42);
}
''');
await assertHasAssistAt(
'() => 42',
DartAssistKind.CONVERT_INTO_BLOCK_BODY,
'''
setup(x) {}
main() {
setup(() {
return 42;
});
}
''');
{
Position exitPos = change.selection;
expect(exitPos, isNotNull);
expect(exitPos.file, testFile);
expect(exitPos.offset - 3, resultCode.indexOf('42;'));
}
}
test_convertToBlockBody_OK_closure_voidExpression() async {
await resolveTestUnit('''
setup(x) {}
main() {
setup(() => print('done'));
}
''');
await assertHasAssistAt(
'() => print',
DartAssistKind.CONVERT_INTO_BLOCK_BODY,
'''
setup(x) {}
main() {
setup(() {
print('done');
});
}
''');
{
Position exitPos = change.selection;
expect(exitPos, isNotNull);
expect(exitPos.file, testFile);
expect(exitPos.offset - 3, resultCode.indexOf("');"));
}
}
test_convertToBlockBody_OK_constructor() async {
await resolveTestUnit('''
class A {
factory A() => null;
}
''');
await assertHasAssistAt(
'A()',
DartAssistKind.CONVERT_INTO_BLOCK_BODY,
'''
class A {
factory A() {
return null;
}
}
''');
}
test_convertToBlockBody_OK_method() async {
await resolveTestUnit('''
class A {
mmm() => 123;
}
''');
await assertHasAssistAt(
'mmm()',
DartAssistKind.CONVERT_INTO_BLOCK_BODY,
'''
class A {
mmm() {
return 123;
}
}
''');
}
test_convertToBlockBody_OK_onName() async {
await resolveTestUnit('''
fff() => 123;
''');
await assertHasAssistAt(
'fff()',
DartAssistKind.CONVERT_INTO_BLOCK_BODY,
'''
fff() {
return 123;
}
''');
}
test_convertToBlockBody_OK_onValue() async {
await resolveTestUnit('''
fff() => 123;
''');
await assertHasAssistAt(
'23;',
DartAssistKind.CONVERT_INTO_BLOCK_BODY,
'''
fff() {
return 123;
}
''');
}
test_convertToExpressionBody_BAD_already() async {
await resolveTestUnit('''
fff() => 42;
''');
await assertNoAssistAt(
'fff()', DartAssistKind.CONVERT_INTO_EXPRESSION_BODY);
}
test_convertToExpressionBody_BAD_moreThanOneStatement() async {
await resolveTestUnit('''
fff() {
var v = 42;
return v;
}
''');
await assertNoAssistAt(
'fff()', DartAssistKind.CONVERT_INTO_EXPRESSION_BODY);
}
test_convertToExpressionBody_BAD_noEnclosingFunction() async {
await resolveTestUnit('''
var V = 42;
''');
await assertNoAssistAt('V = ', DartAssistKind.CONVERT_INTO_EXPRESSION_BODY);
}
test_convertToExpressionBody_BAD_noReturn() async {
await resolveTestUnit('''
fff() {
var v = 42;
}
''');
await assertNoAssistAt(
'fff()', DartAssistKind.CONVERT_INTO_EXPRESSION_BODY);
}
test_convertToExpressionBody_BAD_noReturnValue() async {
await resolveTestUnit('''
fff() {
return;
}
''');
await assertNoAssistAt(
'fff()', DartAssistKind.CONVERT_INTO_EXPRESSION_BODY);
}
test_convertToExpressionBody_OK_async() async {
await resolveTestUnit('''
class A {
mmm() async {
return 42;
}
}
''');
await assertHasAssistAt(
'mmm',
DartAssistKind.CONVERT_INTO_EXPRESSION_BODY,
'''
class A {
mmm() async => 42;
}
''');
}
test_convertToExpressionBody_OK_closure() async {
await resolveTestUnit('''
setup(x) {}
main() {
setup(() {
return 42;
});
}
''');
await assertHasAssistAt(
'42;',
DartAssistKind.CONVERT_INTO_EXPRESSION_BODY,
'''
setup(x) {}
main() {
setup(() => 42);
}
''');
}
test_convertToExpressionBody_OK_closure_voidExpression() async {
await resolveTestUnit('''
setup(x) {}
main() {
setup(() {
print('test');
});
}
''');
await assertHasAssistAt(
'print(',
DartAssistKind.CONVERT_INTO_EXPRESSION_BODY,
'''
setup(x) {}
main() {
setup(() => print('test'));
}
''');
}
test_convertToExpressionBody_OK_constructor() async {
await resolveTestUnit('''
class A {
factory A() {
return null;
}
}
''');
await assertHasAssistAt(
'A()',
DartAssistKind.CONVERT_INTO_EXPRESSION_BODY,
'''
class A {
factory A() => null;
}
''');
}
test_convertToExpressionBody_OK_function_onBlock() async {
await resolveTestUnit('''
fff() {
return 42;
}
''');
await assertHasAssistAt(
'{',
DartAssistKind.CONVERT_INTO_EXPRESSION_BODY,
'''
fff() => 42;
''');
}
test_convertToExpressionBody_OK_function_onName() async {
await resolveTestUnit('''
fff() {
return 42;
}
''');
await assertHasAssistAt(
'ff()',
DartAssistKind.CONVERT_INTO_EXPRESSION_BODY,
'''
fff() => 42;
''');
}
test_convertToExpressionBody_OK_method_onBlock() async {
await resolveTestUnit('''
class A {
m() { // marker
return 42;
}
}
''');
await assertHasAssistAt(
'{ // marker',
DartAssistKind.CONVERT_INTO_EXPRESSION_BODY,
'''
class A {
m() => 42;
}
''');
}
test_convertToExpressionBody_OK_topFunction_onReturnStatement() async {
await resolveTestUnit('''
fff() {
return 42;
}
''');
await assertHasAssistAt(
'return',
DartAssistKind.CONVERT_INTO_EXPRESSION_BODY,
'''
fff() => 42;
''');
}
test_convertToFieldParameter_BAD_additionalUse() async {
await resolveTestUnit('''
class A {
int aaa2;
int bbb2;
A(int aaa) : aaa2 = aaa, bbb2 = aaa;
}
''');
await assertNoAssistAt('aaa)', DartAssistKind.CONVERT_TO_FIELD_PARAMETER);
}
test_convertToFieldParameter_BAD_notPureAssignment() async {
await resolveTestUnit('''
class A {
int aaa2;
A(int aaa) : aaa2 = aaa * 2;
}
''');
await assertNoAssistAt('aaa)', DartAssistKind.CONVERT_TO_FIELD_PARAMETER);
}
test_convertToFieldParameter_OK_firstInitializer() async {
await resolveTestUnit('''
class A {
int aaa2;
int bbb2;
A(int aaa, int bbb) : aaa2 = aaa, bbb2 = bbb;
}
''');
await assertHasAssistAt(
'aaa, ',
DartAssistKind.CONVERT_TO_FIELD_PARAMETER,
'''
class A {
int aaa2;
int bbb2;
A(this.aaa2, int bbb) : bbb2 = bbb;
}
''');
}
test_convertToFieldParameter_OK_onParameterName_inInitializer() async {
await resolveTestUnit('''
class A {
int test2;
A(int test) : test2 = test {
}
}
''');
await assertHasAssistAt(
'test {',
DartAssistKind.CONVERT_TO_FIELD_PARAMETER,
'''
class A {
int test2;
A(this.test2) {
}
}
''');
}
test_convertToFieldParameter_OK_onParameterName_inParameters() async {
await resolveTestUnit('''
class A {
int test;
A(int test) : test = test {
}
}
''');
await assertHasAssistAt(
'test)',
DartAssistKind.CONVERT_TO_FIELD_PARAMETER,
'''
class A {
int test;
A(this.test) {
}
}
''');
}
test_convertToFieldParameter_OK_secondInitializer() async {
await resolveTestUnit('''
class A {
int aaa2;
int bbb2;
A(int aaa, int bbb) : aaa2 = aaa, bbb2 = bbb;
}
''');
await assertHasAssistAt(
'bbb)',
DartAssistKind.CONVERT_TO_FIELD_PARAMETER,
'''
class A {
int aaa2;
int bbb2;
A(int aaa, this.bbb2) : aaa2 = aaa;
}
''');
}
test_convertToFinalField_BAD_hasSetter_inThisClass() async {
await resolveTestUnit('''
class A {
int get foo => null;
void set foo(_) {}
}
''');
await assertNoAssistAt('get foo', DartAssistKind.CONVERT_INTO_FINAL_FIELD);
}
test_convertToFinalField_BAD_notExpressionBody() async {
await resolveTestUnit('''
class A {
int get foo {
int v = 1 + 2;
return v + 3;
}
}
''');
await assertNoAssistAt('get foo', DartAssistKind.CONVERT_INTO_FINAL_FIELD);
}
test_convertToFinalField_BAD_notGetter() async {
await resolveTestUnit('''
class A {
int foo() => 42;
}
''');
await assertNoAssistAt('foo', DartAssistKind.CONVERT_INTO_FINAL_FIELD);
}
test_convertToFinalField_OK_blockBody_onlyReturnStatement() async {
await resolveTestUnit('''
class A {
int get foo {
return 1 + 2;
}
}
''');
await assertHasAssistAt(
'get foo',
DartAssistKind.CONVERT_INTO_FINAL_FIELD,
'''
class A {
final int foo = 1 + 2;
}
''');
}
test_convertToFinalField_OK_hasOverride() async {
await resolveTestUnit('''
const myAnnotation = const Object();
class A {
@myAnnotation
int get foo => 42;
}
''');
await assertHasAssistAt(
'get foo',
DartAssistKind.CONVERT_INTO_FINAL_FIELD,
'''
const myAnnotation = const Object();
class A {
@myAnnotation
final int foo = 42;
}
''');
}
test_convertToFinalField_OK_hasSetter_inSuper() async {
await resolveTestUnit('''
class A {
void set foo(_) {}
}
class B extends A {
int get foo => null;
}
''');
await assertHasAssistAt(
'get foo',
DartAssistKind.CONVERT_INTO_FINAL_FIELD,
'''
class A {
void set foo(_) {}
}
class B extends A {
final int foo;
}
''');
}
test_convertToFinalField_OK_notNull() async {
await resolveTestUnit('''
class A {
int get foo => 1 + 2;
}
''');
await assertHasAssistAt(
'get foo',
DartAssistKind.CONVERT_INTO_FINAL_FIELD,
'''
class A {
final int foo = 1 + 2;
}
''');
}
test_convertToFinalField_OK_null() async {
await resolveTestUnit('''
class A {
int get foo => null;
}
''');
await assertHasAssistAt(
'get foo',
DartAssistKind.CONVERT_INTO_FINAL_FIELD,
'''
class A {
final int foo;
}
''');
}
test_convertToFinalField_OK_onName() async {
await resolveTestUnit('''
class A {
int get foo => 42;
}
''');
await assertHasAssistAt(
'foo',
DartAssistKind.CONVERT_INTO_FINAL_FIELD,
'''
class A {
final int foo = 42;
}
''');
}
test_convertToFinalField_OK_onReturnType_parameterized() async {
await resolveTestUnit('''
class A {
List<int> get foo => null;
}
''');
await assertHasAssistAt(
'nt> get',
DartAssistKind.CONVERT_INTO_FINAL_FIELD,
'''
class A {
final List<int> foo;
}
''');
}
test_convertToFinalField_OK_onReturnType_simple() async {
await resolveTestUnit('''
class A {
int get foo => 42;
}
''');
await assertHasAssistAt(
'int get',
DartAssistKind.CONVERT_INTO_FINAL_FIELD,
'''
class A {
final int foo = 42;
}
''');
}
test_convertToForIndex_BAD_bodyNotBlock() async {
await resolveTestUnit('''
main(List<String> items) {
for (String item in items) print(item);
}
''');
await assertNoAssistAt(
'for (String', DartAssistKind.CONVERT_INTO_FOR_INDEX);
}
test_convertToForIndex_BAD_doesNotDeclareVariable() async {
await resolveTestUnit('''
main(List<String> items) {
String item;
for (item in items) {
print(item);
}
}
''');
await assertNoAssistAt('for (item', DartAssistKind.CONVERT_INTO_FOR_INDEX);
}
test_convertToForIndex_BAD_iterableIsNotVariable() async {
await resolveTestUnit('''
main() {
for (String item in ['a', 'b', 'c']) {
print(item);
}
}
''');
await assertNoAssistAt(
'for (String', DartAssistKind.CONVERT_INTO_FOR_INDEX);
}
test_convertToForIndex_BAD_iterableNotList() async {
await resolveTestUnit('''
main(Iterable<String> items) {
for (String item in items) {
print(item);
}
}
''');
await assertNoAssistAt(
'for (String', DartAssistKind.CONVERT_INTO_FOR_INDEX);
}
test_convertToForIndex_BAD_usesIJK() async {
await resolveTestUnit('''
main(List<String> items) {
for (String item in items) {
print(item);
int i, j, k;
}
}
''');
await assertNoAssistAt(
'for (String', DartAssistKind.CONVERT_INTO_FOR_INDEX);
}
test_convertToForIndex_OK_onDeclaredIdentifier_name() async {
await resolveTestUnit('''
main(List<String> items) {
for (String item in items) {
print(item);
}
}
''');
await assertHasAssistAt(
'item in',
DartAssistKind.CONVERT_INTO_FOR_INDEX,
'''
main(List<String> items) {
for (int i = 0; i < items.length; i++) {
String item = items[i];
print(item);
}
}
''');
}
test_convertToForIndex_OK_onDeclaredIdentifier_type() async {
await resolveTestUnit('''
main(List<String> items) {
for (String item in items) {
print(item);
}
}
''');
await assertHasAssistAt(
'tring item',
DartAssistKind.CONVERT_INTO_FOR_INDEX,
'''
main(List<String> items) {
for (int i = 0; i < items.length; i++) {
String item = items[i];
print(item);
}
}
''');
}
test_convertToForIndex_OK_onFor() async {
await resolveTestUnit('''
main(List<String> items) {
for (String item in items) {
print(item);
}
}
''');
await assertHasAssistAt(
'for (String',
DartAssistKind.CONVERT_INTO_FOR_INDEX,
'''
main(List<String> items) {
for (int i = 0; i < items.length; i++) {
String item = items[i];
print(item);
}
}
''');
}
test_convertToForIndex_OK_usesI() async {
await resolveTestUnit('''
main(List<String> items) {
for (String item in items) {
int i = 0;
}
}
''');
await assertHasAssistAt(
'for (String',
DartAssistKind.CONVERT_INTO_FOR_INDEX,
'''
main(List<String> items) {
for (int j = 0; j < items.length; j++) {
String item = items[j];
int i = 0;
}
}
''');
}
test_convertToForIndex_OK_usesIJ() async {
await resolveTestUnit('''
main(List<String> items) {
for (String item in items) {
print(item);
int i = 0, j = 1;
}
}
''');
await assertHasAssistAt(
'for (String',
DartAssistKind.CONVERT_INTO_FOR_INDEX,
'''
main(List<String> items) {
for (int k = 0; k < items.length; k++) {
String item = items[k];
print(item);
int i = 0, j = 1;
}
}
''');
}
test_convertToGetter_BAD_noInitializer() async {
verifyNoTestUnitErrors = false;
await resolveTestUnit('''
class A {
final int foo;
}
''');
await assertNoAssistAt('foo', DartAssistKind.CONVERT_INTO_GETTER);
}
test_convertToGetter_BAD_notFinal() async {
await resolveTestUnit('''
class A {
int foo = 1;
}
''');
await assertNoAssistAt('foo', DartAssistKind.CONVERT_INTO_GETTER);
}
test_convertToGetter_BAD_notSingleField() async {
await resolveTestUnit('''
class A {
final int foo = 1, bar = 2;
}
''');
await assertNoAssistAt('foo', DartAssistKind.CONVERT_INTO_GETTER);
}
test_convertToGetter_OK() async {
await resolveTestUnit('''
const myAnnotation = const Object();
class A {
@myAnnotation
final int foo = 1 + 2;
}
''');
await assertHasAssistAt(
'foo =',
DartAssistKind.CONVERT_INTO_GETTER,
'''
const myAnnotation = const Object();
class A {
@myAnnotation
int get foo => 1 + 2;
}
''');
}
test_convertToGetter_OK_noType() async {
await resolveTestUnit('''
class A {
final foo = 42;
}
''');
await assertHasAssistAt(
'foo =',
DartAssistKind.CONVERT_INTO_GETTER,
'''
class A {
get foo => 42;
}
''');
}
test_convertToIsNot_BAD_is_alreadyIsNot() async {
await resolveTestUnit('''
main(p) {
p is! String;
}
''');
await assertNoAssistAt('is!', DartAssistKind.CONVERT_INTO_IS_NOT);
}
test_convertToIsNot_BAD_is_noEnclosingParenthesis() async {
await resolveTestUnit('''
main(p) {
p is String;
}
''');
await assertNoAssistAt('is String', DartAssistKind.CONVERT_INTO_IS_NOT);
}
test_convertToIsNot_BAD_is_noPrefix() async {
await resolveTestUnit('''
main(p) {
(p is String);
}
''');
await assertNoAssistAt('is String', DartAssistKind.CONVERT_INTO_IS_NOT);
}
test_convertToIsNot_BAD_is_notIsExpression() async {
await resolveTestUnit('''
main(p) {
123 + 456;
}
''');
await assertNoAssistAt('123 +', DartAssistKind.CONVERT_INTO_IS_NOT);
}
test_convertToIsNot_BAD_is_notTheNotOperator() async {
verifyNoTestUnitErrors = false;
await resolveTestUnit('''
main(p) {
++(p is String);
}
''');
await assertNoAssistAt('is String', DartAssistKind.CONVERT_INTO_IS_NOT);
}
test_convertToIsNot_BAD_not_alreadyIsNot() async {
await resolveTestUnit('''
main(p) {
!(p is! String);
}
''');
await assertNoAssistAt('!(p', DartAssistKind.CONVERT_INTO_IS_NOT);
}
test_convertToIsNot_BAD_not_noEnclosingParenthesis() async {
await resolveTestUnit('''
main(p) {
!p;
}
''');
await assertNoAssistAt('!p', DartAssistKind.CONVERT_INTO_IS_NOT);
}
test_convertToIsNot_BAD_not_notIsExpression() async {
await resolveTestUnit('''
main(p) {
!(p == null);
}
''');
await assertNoAssistAt('!(p', DartAssistKind.CONVERT_INTO_IS_NOT);
}
test_convertToIsNot_BAD_not_notTheNotOperator() async {
verifyNoTestUnitErrors = false;
await resolveTestUnit('''
main(p) {
++(p is String);
}
''');
await assertNoAssistAt('++(', DartAssistKind.CONVERT_INTO_IS_NOT);
}
test_convertToIsNot_OK_childOfIs_left() async {
await resolveTestUnit('''
main(p) {
!(p is String);
}
''');
await assertHasAssistAt(
'p is',
DartAssistKind.CONVERT_INTO_IS_NOT,
'''
main(p) {
p is! String;
}
''');
}
test_convertToIsNot_OK_childOfIs_right() async {
await resolveTestUnit('''
main(p) {
!(p is String);
}
''');
await assertHasAssistAt(
'String)',
DartAssistKind.CONVERT_INTO_IS_NOT,
'''
main(p) {
p is! String;
}
''');
}
test_convertToIsNot_OK_is() async {
await resolveTestUnit('''
main(p) {
!(p is String);
}
''');
await assertHasAssistAt(
'is String',
DartAssistKind.CONVERT_INTO_IS_NOT,
'''
main(p) {
p is! String;
}
''');
}
test_convertToIsNot_OK_is_higherPrecedencePrefix() async {
await resolveTestUnit('''
main(p) {
!!(p is String);
}
''');
await assertHasAssistAt(
'is String',
DartAssistKind.CONVERT_INTO_IS_NOT,
'''
main(p) {
!(p is! String);
}
''');
}
test_convertToIsNot_OK_is_not_higherPrecedencePrefix() async {
await resolveTestUnit('''
main(p) {
!!(p is String);
}
''');
await assertHasAssistAt(
'!(p',
DartAssistKind.CONVERT_INTO_IS_NOT,
'''
main(p) {
!(p is! String);
}
''');
}
test_convertToIsNot_OK_not() async {
await resolveTestUnit('''
main(p) {
!(p is String);
}
''');
await assertHasAssistAt(
'!(p',
DartAssistKind.CONVERT_INTO_IS_NOT,
'''
main(p) {
p is! String;
}
''');
}
test_convertToIsNot_OK_parentheses() async {
await resolveTestUnit('''
main(p) {
!(p is String);
}
''');
await assertHasAssistAt(
'(p is',
DartAssistKind.CONVERT_INTO_IS_NOT,
'''
main(p) {
p is! String;
}
''');
}
test_convertToIsNotEmpty_BAD_noBang() async {
verifyNoTestUnitErrors = false;
await resolveTestUnit('''
main(String str) {
~str.isEmpty;
}
''');
await assertNoAssistAt(
'isEmpty;', DartAssistKind.CONVERT_INTO_IS_NOT_EMPTY);
}
test_convertToIsNotEmpty_BAD_noIsNotEmpty() async {
await resolveTestUnit('''
class A {
bool get isEmpty => false;
}
main(A a) {
!a.isEmpty;
}
''');
await assertNoAssistAt(
'isEmpty;', DartAssistKind.CONVERT_INTO_IS_NOT_EMPTY);
}
test_convertToIsNotEmpty_BAD_notInPrefixExpression() async {
await resolveTestUnit('''
main(String str) {
str.isEmpty;
}
''');
await assertNoAssistAt(
'isEmpty;', DartAssistKind.CONVERT_INTO_IS_NOT_EMPTY);
}
test_convertToIsNotEmpty_BAD_notIsEmpty() async {
await resolveTestUnit('''
main(int p) {
!p.isEven;
}
''');
await assertNoAssistAt('isEven;', DartAssistKind.CONVERT_INTO_IS_NOT_EMPTY);
}
test_convertToIsNotEmpty_OK_on_isEmpty() async {
await resolveTestUnit('''
main(String str) {
!str.isEmpty;
}
''');
await assertHasAssistAt(
'isEmpty',
DartAssistKind.CONVERT_INTO_IS_NOT_EMPTY,
'''
main(String str) {
str.isNotEmpty;
}
''');
}
test_convertToIsNotEmpty_OK_on_str() async {
await resolveTestUnit('''
main(String str) {
!str.isEmpty;
}
''');
await assertHasAssistAt(
'str.',
DartAssistKind.CONVERT_INTO_IS_NOT_EMPTY,
'''
main(String str) {
str.isNotEmpty;
}
''');
}
test_convertToIsNotEmpty_OK_propertyAccess() async {
await resolveTestUnit('''
main(String str) {
!'text'.isEmpty;
}
''');
await assertHasAssistAt(
'isEmpty',
DartAssistKind.CONVERT_INTO_IS_NOT_EMPTY,
'''
main(String str) {
'text'.isNotEmpty;
}
''');
}
test_convertToNormalParameter_OK_dynamic() async {
await resolveTestUnit('''
class A {
var test;
A(this.test) {
}
}
''');
await assertHasAssistAt(
'test)',
DartAssistKind.CONVERT_TO_NORMAL_PARAMETER,
'''
class A {
var test;
A(test) : test = test {
}
}
''');
}
test_convertToNormalParameter_OK_firstInitializer() async {
await resolveTestUnit('''
class A {
int test;
A(this.test) {
}
}
''');
await assertHasAssistAt(
'test)',
DartAssistKind.CONVERT_TO_NORMAL_PARAMETER,
'''
class A {
int test;
A(int test) : test = test {
}
}
''');
}
test_convertToNormalParameter_OK_secondInitializer() async {
await resolveTestUnit('''
class A {
double aaa;
int bbb;
A(this.bbb) : aaa = 1.0;
}
''');
await assertHasAssistAt(
'bbb)',
DartAssistKind.CONVERT_TO_NORMAL_PARAMETER,
'''
class A {
double aaa;
int bbb;
A(int bbb) : aaa = 1.0, bbb = bbb;
}
''');
}
test_encapsulateField_BAD_alreadyPrivate() async {
await resolveTestUnit('''
class A {
int _test = 42;
}
main(A a) {
print(a._test);
}
''');
await assertNoAssistAt('_test =', DartAssistKind.ENCAPSULATE_FIELD);
}
test_encapsulateField_BAD_final() async {
await resolveTestUnit('''
class A {
final int test = 42;
}
''');
await assertNoAssistAt('test =', DartAssistKind.ENCAPSULATE_FIELD);
}
test_encapsulateField_BAD_multipleFields() async {
await resolveTestUnit('''
class A {
int aaa, bbb, ccc;
}
main(A a) {
print(a.bbb);
}
''');
await assertNoAssistAt('bbb, ', DartAssistKind.ENCAPSULATE_FIELD);
}
test_encapsulateField_BAD_notOnName() async {
await resolveTestUnit('''
class A {
int test = 1 + 2 + 3;
}
''');
await assertNoAssistAt('+ 2', DartAssistKind.ENCAPSULATE_FIELD);
}
test_encapsulateField_BAD_parseError() async {
verifyNoTestUnitErrors = false;
await resolveTestUnit('''
class A {
int; // marker
}
main(A a) {
print(a.test);
}
''');
await assertNoAssistAt('; // marker', DartAssistKind.ENCAPSULATE_FIELD);
}
test_encapsulateField_BAD_static() async {
await resolveTestUnit('''
class A {
static int test = 42;
}
''');
await assertNoAssistAt('test =', DartAssistKind.ENCAPSULATE_FIELD);
}
test_encapsulateField_OK_hasType() async {
await resolveTestUnit('''
class A {
int test = 42;
A(this.test);
}
main(A a) {
print(a.test);
}
''');
await assertHasAssistAt(
'test = 42',
DartAssistKind.ENCAPSULATE_FIELD,
'''
class A {
int _test = 42;
int get test => _test;
void set test(int test) {
_test = test;
}
A(this._test);
}
main(A a) {
print(a.test);
}
''');
}
test_encapsulateField_OK_noType() async {
await resolveTestUnit('''
class A {
var test = 42;
}
main(A a) {
print(a.test);
}
''');
await assertHasAssistAt(
'test = 42',
DartAssistKind.ENCAPSULATE_FIELD,
'''
class A {
var _test = 42;
get test => _test;
void set test(test) {
_test = test;
}
}
main(A a) {
print(a.test);
}
''');
}
test_exchangeBinaryExpressionArguments_BAD_extraLength() async {
await resolveTestUnit('''
main() {
111 + 222;
}
''');
length = 3;
await assertNoAssistAt('+ 222', DartAssistKind.EXCHANGE_OPERANDS);
}
test_exchangeBinaryExpressionArguments_BAD_onOperand() async {
await resolveTestUnit('''
main() {
111 + 222;
}
''');
length = 3;
await assertNoAssistAt('11 +', DartAssistKind.EXCHANGE_OPERANDS);
}
test_exchangeBinaryExpressionArguments_BAD_selectionWithBinary() async {
await resolveTestUnit('''
main() {
1 + 2 + 3;
}
''');
length = '1 + 2 + 3'.length;
await assertNoAssistAt('1 + 2 + 3', DartAssistKind.EXCHANGE_OPERANDS);
}
test_exchangeBinaryExpressionArguments_OK_compare() async {
const initialOperators = const ['<', '<=', '>', '>='];
const resultOperators = const ['>', '>=', '<', '<='];
for (int i = 0; i <= 0; i++) {
String initialOperator = initialOperators[i];
String resultOperator = resultOperators[i];
await resolveTestUnit('''
bool main(int a, int b) {
return a $initialOperator b;
}
''');
await assertHasAssistAt(
initialOperator,
DartAssistKind.EXCHANGE_OPERANDS,
'''
bool main(int a, int b) {
return b $resultOperator a;
}
''');
}
}
test_exchangeBinaryExpressionArguments_OK_extended_mixOperator_1() async {
await resolveTestUnit('''
main() {
1 * 2 * 3 + 4;
}
''');
await assertHasAssistAt(
'* 2',
DartAssistKind.EXCHANGE_OPERANDS,
'''
main() {
2 * 3 * 1 + 4;
}
''');
}
test_exchangeBinaryExpressionArguments_OK_extended_mixOperator_2() async {
await resolveTestUnit('''
main() {
1 + 2 - 3 + 4;
}
''');
await assertHasAssistAt(
'+ 2',
DartAssistKind.EXCHANGE_OPERANDS,
'''
main() {
2 + 1 - 3 + 4;
}
''');
}
test_exchangeBinaryExpressionArguments_OK_extended_sameOperator_afterFirst() async {
await resolveTestUnit('''
main() {
1 + 2 + 3;
}
''');
await assertHasAssistAt(
'+ 2',
DartAssistKind.EXCHANGE_OPERANDS,
'''
main() {
2 + 3 + 1;
}
''');
}
test_exchangeBinaryExpressionArguments_OK_extended_sameOperator_afterSecond() async {
await resolveTestUnit('''
main() {
1 + 2 + 3;
}
''');
await assertHasAssistAt(
'+ 3',
DartAssistKind.EXCHANGE_OPERANDS,
'''
main() {
3 + 1 + 2;
}
''');
}
test_exchangeBinaryExpressionArguments_OK_simple_afterOperator() async {
await resolveTestUnit('''
main() {
1 + 2;
}
''');
await assertHasAssistAt(
' 2',
DartAssistKind.EXCHANGE_OPERANDS,
'''
main() {
2 + 1;
}
''');
}
test_exchangeBinaryExpressionArguments_OK_simple_beforeOperator() async {
await resolveTestUnit('''
main() {
1 + 2;
}
''');
await assertHasAssistAt(
'+ 2',
DartAssistKind.EXCHANGE_OPERANDS,
'''
main() {
2 + 1;
}
''');
}
test_exchangeBinaryExpressionArguments_OK_simple_fullSelection() async {
await resolveTestUnit('''
main() {
1 + 2;
}
''');
length = '1 + 2'.length;
await assertHasAssistAt(
'1 + 2',
DartAssistKind.EXCHANGE_OPERANDS,
'''
main() {
2 + 1;
}
''');
}
test_exchangeBinaryExpressionArguments_OK_simple_withLength() async {
await resolveTestUnit('''
main() {
1 + 2;
}
''');
length = 2;
await assertHasAssistAt(
'+ 2',
DartAssistKind.EXCHANGE_OPERANDS,
'''
main() {
2 + 1;
}
''');
}
test_importAddShow_BAD_hasShow() async {
await resolveTestUnit('''
import 'dart:math' show PI;
main() {
PI;
}
''');
await assertNoAssistAt('import ', DartAssistKind.IMPORT_ADD_SHOW);
}
test_importAddShow_BAD_unresolvedUri() async {
verifyNoTestUnitErrors = false;
await resolveTestUnit('''
import '/no/such/lib.dart';
''');
await assertNoAssistAt('import ', DartAssistKind.IMPORT_ADD_SHOW);
}
test_importAddShow_BAD_unused() async {
await resolveTestUnit('''
import 'dart:math';
''');
await assertNoAssistAt('import ', DartAssistKind.IMPORT_ADD_SHOW);
}
test_importAddShow_OK_hasUnresolvedIdentifier() async {
await resolveTestUnit('''
import 'dart:math';
main(x) {
PI;
return x.foo();
}
''');
await assertHasAssistAt(
'import ',
DartAssistKind.IMPORT_ADD_SHOW,
'''
import 'dart:math' show PI;
main(x) {
PI;
return x.foo();
}
''');
}
test_importAddShow_OK_onDirective() async {
await resolveTestUnit('''
import 'dart:math';
main() {
PI;
E;
max(1, 2);
}
''');
await assertHasAssistAt(
'import ',
DartAssistKind.IMPORT_ADD_SHOW,
'''
import 'dart:math' show E, PI, max;
main() {
PI;
E;
max(1, 2);
}
''');
}
test_importAddShow_OK_onUri() async {
await resolveTestUnit('''
import 'dart:math';
main() {
PI;
E;
max(1, 2);
}
''');
await assertHasAssistAt(
'art:math',
DartAssistKind.IMPORT_ADD_SHOW,
'''
import 'dart:math' show E, PI, max;
main() {
PI;
E;
max(1, 2);
}
''');
}
test_introduceLocalTestedType_BAD_notBlock() async {
await resolveTestUnit('''
main(p) {
if (p is String)
print('not a block');
}
''');
await assertNoAssistAt('if (p', DartAssistKind.INTRODUCE_LOCAL_CAST_TYPE);
}
test_introduceLocalTestedType_BAD_notIsExpression() async {
await resolveTestUnit('''
main(p) {
if (p == null) {
}
}
''');
await assertNoAssistAt('if (p', DartAssistKind.INTRODUCE_LOCAL_CAST_TYPE);
}
test_introduceLocalTestedType_BAD_notStatement() async {
await resolveTestUnit('''
class C {
bool b;
C(v) : b = v is int;
}''');
await assertNoAssistAt('is int', DartAssistKind.INTRODUCE_LOCAL_CAST_TYPE);
}
test_introduceLocalTestedType_OK_if_is() async {
await resolveTestUnit('''
class MyTypeName {}
main(p) {
if (p is MyTypeName) {
}
p = null;
}
''');
String expected = '''
class MyTypeName {}
main(p) {
if (p is MyTypeName) {
MyTypeName myTypeName = p;
}
p = null;
}
''';
await assertHasAssistAt(
'is MyType', DartAssistKind.INTRODUCE_LOCAL_CAST_TYPE, expected);
_assertLinkedGroup(
change.linkedEditGroups[0],
['myTypeName = '],
expectedSuggestions(LinkedEditSuggestionKind.VARIABLE,
['myTypeName', 'typeName', 'name']));
// another good location
await assertHasAssistAt(
'if (p', DartAssistKind.INTRODUCE_LOCAL_CAST_TYPE, expected);
}
test_introduceLocalTestedType_OK_if_isNot() async {
await resolveTestUnit('''
class MyTypeName {}
main(p) {
if (p is! MyTypeName) {
return;
}
}
''');
String expected = '''
class MyTypeName {}
main(p) {
if (p is! MyTypeName) {
return;
}
MyTypeName myTypeName = p;
}
''';
await assertHasAssistAt(
'is! MyType', DartAssistKind.INTRODUCE_LOCAL_CAST_TYPE, expected);
_assertLinkedGroup(
change.linkedEditGroups[0],
['myTypeName = '],
expectedSuggestions(LinkedEditSuggestionKind.VARIABLE,
['myTypeName', 'typeName', 'name']));
// another good location
await assertHasAssistAt(
'if (p', DartAssistKind.INTRODUCE_LOCAL_CAST_TYPE, expected);
}
test_introduceLocalTestedType_OK_while() async {
await resolveTestUnit('''
main(p) {
while (p is String) {
}
p = null;
}
''');
String expected = '''
main(p) {
while (p is String) {
String s = p;
}
p = null;
}
''';
await assertHasAssistAt(
'is String', DartAssistKind.INTRODUCE_LOCAL_CAST_TYPE, expected);
await assertHasAssistAt(
'while (p', DartAssistKind.INTRODUCE_LOCAL_CAST_TYPE, expected);
}
test_invalidSelection() async {
await resolveTestUnit('');
offset = -1;
length = 0;
List<Assist> assists = await _computeAssists();
expect(assists, isEmpty);
}
test_invertIfStatement_blocks() async {
await resolveTestUnit('''
main() {
if (true) {
0;
} else {
1;
}
}
''');
await assertHasAssistAt(
'if (',
DartAssistKind.INVERT_IF_STATEMENT,
'''
main() {
if (false) {
1;
} else {
0;
}
}
''');
}
test_invertIfStatement_statements() async {
await resolveTestUnit('''
main() {
if (true)
0;
else
1;
}
''');
await assertHasAssistAt(
'if (',
DartAssistKind.INVERT_IF_STATEMENT,
'''
main() {
if (false)
1;
else
0;
}
''');
}
test_joinIfStatementInner_BAD_innerNotIf() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
print(0);
}
}
''');
await assertNoAssistAt('if (1 ==', DartAssistKind.JOIN_IF_WITH_INNER);
}
test_joinIfStatementInner_BAD_innerWithElse() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2) {
print(0);
} else {
print(1);
}
}
}
''');
await assertNoAssistAt('if (1 ==', DartAssistKind.JOIN_IF_WITH_INNER);
}
test_joinIfStatementInner_BAD_statementAfterInner() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2) {
print(2);
}
print(1);
}
}
''');
await assertNoAssistAt('if (1 ==', DartAssistKind.JOIN_IF_WITH_INNER);
}
test_joinIfStatementInner_BAD_statementBeforeInner() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
print(1);
if (2 == 2) {
print(2);
}
}
}
''');
await assertNoAssistAt('if (1 ==', DartAssistKind.JOIN_IF_WITH_INNER);
}
test_joinIfStatementInner_BAD_targetNotIf() async {
await resolveTestUnit('''
main() {
print(0);
}
''');
await assertNoAssistAt('print', DartAssistKind.JOIN_IF_WITH_INNER);
}
test_joinIfStatementInner_BAD_targetWithElse() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2) {
print(0);
}
} else {
print(1);
}
}
''');
await assertNoAssistAt('if (1 ==', DartAssistKind.JOIN_IF_WITH_INNER);
}
test_joinIfStatementInner_OK_conditionAndOr() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2 || 3 == 3) {
print(0);
}
}
}
''');
await assertHasAssistAt(
'if (1 ==',
DartAssistKind.JOIN_IF_WITH_INNER,
'''
main() {
if (1 == 1 && (2 == 2 || 3 == 3)) {
print(0);
}
}
''');
}
test_joinIfStatementInner_OK_conditionInvocation() async {
await resolveTestUnit('''
main() {
if (isCheck()) {
if (2 == 2) {
print(0);
}
}
}
bool isCheck() => false;
''');
await assertHasAssistAt(
'if (isCheck',
DartAssistKind.JOIN_IF_WITH_INNER,
'''
main() {
if (isCheck() && 2 == 2) {
print(0);
}
}
bool isCheck() => false;
''');
}
test_joinIfStatementInner_OK_conditionOrAnd() async {
await resolveTestUnit('''
main() {
if (1 == 1 || 2 == 2) {
if (3 == 3) {
print(0);
}
}
}
''');
await assertHasAssistAt(
'if (1 ==',
DartAssistKind.JOIN_IF_WITH_INNER,
'''
main() {
if ((1 == 1 || 2 == 2) && 3 == 3) {
print(0);
}
}
''');
}
test_joinIfStatementInner_OK_onCondition() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2) {
print(0);
}
}
}
''');
await assertHasAssistAt(
'1 ==',
DartAssistKind.JOIN_IF_WITH_INNER,
'''
main() {
if (1 == 1 && 2 == 2) {
print(0);
}
}
''');
}
test_joinIfStatementInner_OK_simpleConditions_block_block() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2) {
print(0);
}
}
}
''');
await assertHasAssistAt(
'if (1 ==',
DartAssistKind.JOIN_IF_WITH_INNER,
'''
main() {
if (1 == 1 && 2 == 2) {
print(0);
}
}
''');
}
test_joinIfStatementInner_OK_simpleConditions_block_single() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2)
print(0);
}
}
''');
await assertHasAssistAt(
'if (1 ==',
DartAssistKind.JOIN_IF_WITH_INNER,
'''
main() {
if (1 == 1 && 2 == 2) {
print(0);
}
}
''');
}
test_joinIfStatementInner_OK_simpleConditions_single_blockMulti() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2) {
print(1);
print(2);
print(3);
}
}
}
''');
await assertHasAssistAt(
'if (1 ==',
DartAssistKind.JOIN_IF_WITH_INNER,
'''
main() {
if (1 == 1 && 2 == 2) {
print(1);
print(2);
print(3);
}
}
''');
}
test_joinIfStatementInner_OK_simpleConditions_single_blockOne() async {
await resolveTestUnit('''
main() {
if (1 == 1)
if (2 == 2) {
print(0);
}
}
''');
await assertHasAssistAt(
'if (1 ==',
DartAssistKind.JOIN_IF_WITH_INNER,
'''
main() {
if (1 == 1 && 2 == 2) {
print(0);
}
}
''');
}
test_joinIfStatementOuter_BAD_outerNotIf() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
print(0);
}
}
''');
await assertNoAssistAt('if (1 == 1', DartAssistKind.JOIN_IF_WITH_OUTER);
}
test_joinIfStatementOuter_BAD_outerWithElse() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2) {
print(0);
}
} else {
print(1);
}
}
''');
await assertNoAssistAt('if (2 == 2', DartAssistKind.JOIN_IF_WITH_OUTER);
}
test_joinIfStatementOuter_BAD_statementAfterInner() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2) {
print(2);
}
print(1);
}
}
''');
await assertNoAssistAt('if (2 == 2', DartAssistKind.JOIN_IF_WITH_OUTER);
}
test_joinIfStatementOuter_BAD_statementBeforeInner() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
print(1);
if (2 == 2) {
print(2);
}
}
}
''');
await assertNoAssistAt('if (2 == 2', DartAssistKind.JOIN_IF_WITH_OUTER);
}
test_joinIfStatementOuter_BAD_targetNotIf() async {
await resolveTestUnit('''
main() {
print(0);
}
''');
await assertNoAssistAt('print', DartAssistKind.JOIN_IF_WITH_OUTER);
}
test_joinIfStatementOuter_BAD_targetWithElse() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2) {
print(0);
} else {
print(1);
}
}
}
''');
await assertNoAssistAt('if (2 == 2', DartAssistKind.JOIN_IF_WITH_OUTER);
}
test_joinIfStatementOuter_OK_conditionAndOr() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2 || 3 == 3) {
print(0);
}
}
}
''');
await assertHasAssistAt(
'if (2 ==',
DartAssistKind.JOIN_IF_WITH_OUTER,
'''
main() {
if (1 == 1 && (2 == 2 || 3 == 3)) {
print(0);
}
}
''');
}
test_joinIfStatementOuter_OK_conditionInvocation() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (isCheck()) {
print(0);
}
}
}
bool isCheck() => false;
''');
await assertHasAssistAt(
'if (isCheck',
DartAssistKind.JOIN_IF_WITH_OUTER,
'''
main() {
if (1 == 1 && isCheck()) {
print(0);
}
}
bool isCheck() => false;
''');
}
test_joinIfStatementOuter_OK_conditionOrAnd() async {
await resolveTestUnit('''
main() {
if (1 == 1 || 2 == 2) {
if (3 == 3) {
print(0);
}
}
}
''');
await assertHasAssistAt(
'if (3 == 3',
DartAssistKind.JOIN_IF_WITH_OUTER,
'''
main() {
if ((1 == 1 || 2 == 2) && 3 == 3) {
print(0);
}
}
''');
}
test_joinIfStatementOuter_OK_onCondition() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2) {
print(0);
}
}
}
''');
await assertHasAssistAt(
'if (2 == 2',
DartAssistKind.JOIN_IF_WITH_OUTER,
'''
main() {
if (1 == 1 && 2 == 2) {
print(0);
}
}
''');
}
test_joinIfStatementOuter_OK_simpleConditions_block_block() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2) {
print(0);
}
}
}
''');
await assertHasAssistAt(
'if (2 == 2',
DartAssistKind.JOIN_IF_WITH_OUTER,
'''
main() {
if (1 == 1 && 2 == 2) {
print(0);
}
}
''');
}
test_joinIfStatementOuter_OK_simpleConditions_block_single() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2)
print(0);
}
}
''');
await assertHasAssistAt(
'if (2 == 2',
DartAssistKind.JOIN_IF_WITH_OUTER,
'''
main() {
if (1 == 1 && 2 == 2) {
print(0);
}
}
''');
}
test_joinIfStatementOuter_OK_simpleConditions_single_blockMulti() async {
await resolveTestUnit('''
main() {
if (1 == 1) {
if (2 == 2) {
print(1);
print(2);
print(3);
}
}
}
''');
await assertHasAssistAt(
'if (2 == 2',
DartAssistKind.JOIN_IF_WITH_OUTER,
'''
main() {
if (1 == 1 && 2 == 2) {
print(1);
print(2);
print(3);
}
}
''');
}
test_joinIfStatementOuter_OK_simpleConditions_single_blockOne() async {
await resolveTestUnit('''
main() {
if (1 == 1)
if (2 == 2) {
print(0);
}
}
''');
await assertHasAssistAt(
'if (2 == 2',
DartAssistKind.JOIN_IF_WITH_OUTER,
'''
main() {
if (1 == 1 && 2 == 2) {
print(0);
}
}
''');
}
test_joinVariableDeclaration_onAssignment_BAD_hasInitializer() async {
await resolveTestUnit('''
main() {
var v = 1;
v = 2;
}
''');
await assertNoAssistAt('v = 2', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onAssignment_BAD_notAdjacent() async {
await resolveTestUnit('''
main() {
var v;
var bar;
v = 1;
}
''');
await assertNoAssistAt('v = 1', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onAssignment_BAD_notAssignment() async {
await resolveTestUnit('''
main() {
var v;
v += 1;
}
''');
await assertNoAssistAt('v += 1', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onAssignment_BAD_notDeclaration() async {
await resolveTestUnit('''
main(var v) {
v = 1;
}
''');
await assertNoAssistAt('v = 1', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onAssignment_BAD_notLeftArgument() async {
await resolveTestUnit('''
main() {
var v;
1 + v; // marker
}
''');
await assertNoAssistAt(
'v; // marker', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onAssignment_BAD_notOneVariable() async {
await resolveTestUnit('''
main() {
var v, v2;
v = 1;
}
''');
await assertNoAssistAt('v = 1', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onAssignment_BAD_notResolved() async {
verifyNoTestUnitErrors = false;
await resolveTestUnit('''
main() {
var v;
x = 1;
}
''');
await assertNoAssistAt('x = 1', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onAssignment_BAD_notSameBlock() async {
await resolveTestUnit('''
main() {
var v;
{
v = 1;
}
}
''');
await assertNoAssistAt('v = 1', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onAssignment_OK() async {
await resolveTestUnit('''
main() {
var v;
v = 1;
}
''');
await assertHasAssistAt(
'v =',
DartAssistKind.JOIN_VARIABLE_DECLARATION,
'''
main() {
var v = 1;
}
''');
}
test_joinVariableDeclaration_onDeclaration_BAD_hasInitializer() async {
await resolveTestUnit('''
main() {
var v = 1;
v = 2;
}
''');
await assertNoAssistAt('v = 1', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onDeclaration_BAD_lastStatement() async {
await resolveTestUnit('''
main() {
if (true)
var v;
}
''');
await assertNoAssistAt('v;', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onDeclaration_BAD_nextNotAssignmentExpression() async {
await resolveTestUnit('''
main() {
var v;
42;
}
''');
await assertNoAssistAt('v;', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onDeclaration_BAD_nextNotExpressionStatement() async {
await resolveTestUnit('''
main() {
var v;
if (true) return;
}
''');
await assertNoAssistAt('v;', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onDeclaration_BAD_nextNotPureAssignment() async {
await resolveTestUnit('''
main() {
var v;
v += 1;
}
''');
await assertNoAssistAt('v;', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onDeclaration_BAD_notOneVariable() async {
await resolveTestUnit('''
main() {
var v, v2;
v = 1;
}
''');
await assertNoAssistAt('v, ', DartAssistKind.JOIN_VARIABLE_DECLARATION);
}
test_joinVariableDeclaration_onDeclaration_OK_onName() async {
await resolveTestUnit('''
main() {
var v;
v = 1;
}
''');
await assertHasAssistAt(
'v;',
DartAssistKind.JOIN_VARIABLE_DECLARATION,
'''
main() {
var v = 1;
}
''');
}
test_joinVariableDeclaration_onDeclaration_OK_onType() async {
await resolveTestUnit('''
main() {
int v;
v = 1;
}
''');
await assertHasAssistAt(
'int v',
DartAssistKind.JOIN_VARIABLE_DECLARATION,
'''
main() {
int v = 1;
}
''');
}
test_joinVariableDeclaration_onDeclaration_OK_onVar() async {
await resolveTestUnit('''
main() {
var v;
v = 1;
}
''');
await assertHasAssistAt(
'var v',
DartAssistKind.JOIN_VARIABLE_DECLARATION,
'''
main() {
var v = 1;
}
''');
}
test_moveFlutterWidgetDown_OK() async {
_configureFlutterPkg({
'src/widgets/framework.dart': _flutter_framework_code,
});
await resolveTestUnit('''
import 'package:flutter/src/widgets/framework.dart';
build() {
return new Scaffold(
// start
body: new /*caret*/GestureDetector(
onTap: () => startResize(),
child: new Center(
child: new Container(
width: 200.0,
height: 300.0,
),
key: null,
),
),
// end
);
}
startResize() {}
''');
_setCaretLocation();
await assertHasAssist(
DartAssistKind.MOVE_FLUTTER_WIDGET_DOWN,
'''
import 'package:flutter/src/widgets/framework.dart';
build() {
return new Scaffold(
// start
body: new Center(
child: new /*caret*/GestureDetector(
onTap: () => startResize(),
child: new Container(
width: 200.0,
height: 300.0,
),
),
key: null,
),
// end
);
}
startResize() {}
''');
}
test_moveFlutterWidgetUp_OK() async {
_configureFlutterPkg({
'src/widgets/framework.dart': _flutter_framework_code,
});
await resolveTestUnit('''
import 'package:flutter/src/widgets/framework.dart';
build() {
return new Scaffold(
// start
body: new Center(
child: new /*caret*/GestureDetector(
onTap: () => startResize(),
child: new Container(
width: 200.0,
height: 300.0,
),
),
key: null,
),
// end
);
}
startResize() {}
''');
_setCaretLocation();
await assertHasAssist(
DartAssistKind.MOVE_FLUTTER_WIDGET_UP,
'''
import 'package:flutter/src/widgets/framework.dart';
build() {
return new Scaffold(
// start
body: new /*caret*/GestureDetector(
onTap: () => startResize(),
child: new Center(
child: new Container(
width: 200.0,
height: 300.0,
),
key: null,
),
),
// end
);
}
startResize() {}
''');
}
test_removeTypeAnnotation_classField_OK() async {
await resolveTestUnit('''
class A {
int v = 1;
}
''');
await assertHasAssistAt(
'v = ',
DartAssistKind.REMOVE_TYPE_ANNOTATION,
'''
class A {
var v = 1;
}
''');
}
test_removeTypeAnnotation_classField_OK_final() async {
await resolveTestUnit('''
class A {
final int v = 1;
}
''');
await assertHasAssistAt(
'v = ',
DartAssistKind.REMOVE_TYPE_ANNOTATION,
'''
class A {
final v = 1;
}
''');
}
test_removeTypeAnnotation_localVariable_BAD_onInitializer() async {
await resolveTestUnit('''
main() {
final int v = 1;
}
''');
await assertNoAssistAt('1;', DartAssistKind.REMOVE_TYPE_ANNOTATION);
}
test_removeTypeAnnotation_localVariable_OK() async {
await resolveTestUnit('''
main() {
int a = 1, b = 2;
}
''');
await assertHasAssistAt(
'int ',
DartAssistKind.REMOVE_TYPE_ANNOTATION,
'''
main() {
var a = 1, b = 2;
}
''');
}
test_removeTypeAnnotation_localVariable_OK_const() async {
await resolveTestUnit('''
main() {
const int v = 1;
}
''');
await assertHasAssistAt(
'int ',
DartAssistKind.REMOVE_TYPE_ANNOTATION,
'''
main() {
const v = 1;
}
''');
}
test_removeTypeAnnotation_localVariable_OK_final() async {
await resolveTestUnit('''
main() {
final int v = 1;
}
''');
await assertHasAssistAt(
'int ',
DartAssistKind.REMOVE_TYPE_ANNOTATION,
'''
main() {
final v = 1;
}
''');
}
test_removeTypeAnnotation_topLevelVariable_BAD_syntheticName() async {
verifyNoTestUnitErrors = false;
await resolveTestUnit('''
MyType
''');
await assertNoAssistAt('MyType', DartAssistKind.REMOVE_TYPE_ANNOTATION);
}
test_removeTypeAnnotation_topLevelVariable_OK() async {
await resolveTestUnit('''
int V = 1;
''');
await assertHasAssistAt(
'int ',
DartAssistKind.REMOVE_TYPE_ANNOTATION,
'''
var V = 1;
''');
}
test_removeTypeAnnotation_topLevelVariable_OK_final() async {
await resolveTestUnit('''
final int V = 1;
''');
await assertHasAssistAt(
'int ',
DartAssistKind.REMOVE_TYPE_ANNOTATION,
'''
final V = 1;
''');
}
test_reparentFlutterList_BAD_multiLine() async {
_configureFlutterPkg({
'src/widgets/framework.dart': _flutter_framework_code,
});
await resolveTestUnit('''
import 'package:flutter/src/widgets/framework.dart';
build() {
return new Container(
child: new Row(
children: [/*caret*/
// start
new Transform(),
new Object(),
new AspectRatio(),
// end
],
),
);
}
''');
_setCaretLocation();
await assertNoAssist(DartAssistKind.REPARENT_FLUTTER_LIST);
}
test_reparentFlutterList_BAD_singleLine() async {
_configureFlutterPkg({
'src/widgets/framework.dart': _flutter_framework_code,
});
await resolveTestUnit('''
import 'package:flutter/src/widgets/framework.dart';
class FakeFlutter {
main() {
var obj;
// start
return new Row(children: [/*caret*/ new Transform()]);
// end
}
}
''');
_setCaretLocation();
await assertNoAssist(DartAssistKind.REPARENT_FLUTTER_LIST);
}
test_reparentFlutterList_OK_multiLine() async {
_configureFlutterPkg({
'src/widgets/framework.dart': _flutter_framework_code,
});
await resolveTestUnit('''
import 'package:flutter/src/widgets/framework.dart';
build() {
return new Container(
child: new Row(
// start
children: [/*caret*/
new Transform(),
new Transform(),
new AspectRatio(),
],
// end
),
);
}
''');
_setCaretLocation();
await assertHasAssist(
DartAssistKind.REPARENT_FLUTTER_LIST,
'''
import 'package:flutter/src/widgets/framework.dart';
build() {
return new Container(
child: new Row(
// start
children: [
new widget(
children: [/*caret*/
new Transform(),
new Transform(),
new AspectRatio(),
],
),
],
// end
),
);
}
''');
}
test_reparentFlutterWidget_BAD_minimal() async {
_configureFlutterPkg({
'src/widgets/framework.dart': _flutter_framework_code,
});
await resolveTestUnit('''
/*caret*/x(){}
''');
_setCaretLocation();
await assertNoAssist(DartAssistKind.REPARENT_FLUTTER_WIDGET);
}
test_reparentFlutterWidget_BAD_singleLine() async {
_configureFlutterPkg({
'src/widgets/framework.dart': _flutter_framework_code,
});
await resolveTestUnit('''
import 'package:flutter/src/widgets/framework.dart';
class FakeFlutter {
main() {
var obj;
// start
return new Container(child: obj.xyz./*caret*/abc);
// end
}
}
''');
_setCaretLocation();
await assertNoAssist(DartAssistKind.REPARENT_FLUTTER_WIDGET);
}
test_reparentFlutterWidget_OK_multiLines() async {
_configureFlutterPkg({
'src/widgets/framework.dart': _flutter_framework_code,
});
await resolveTestUnit('''
import 'package:flutter/src/widgets/framework.dart';
class FakeFlutter {
main() {
return new Container(
// start
child: new /*caret*/DefaultTextStyle(
child: new Row(
children: <Widget>[
new Container(
),
],
),
),
// end
);
}
}
''');
_setCaretLocation();
await assertHasAssist(
DartAssistKind.REPARENT_FLUTTER_WIDGET,
'''
import 'package:flutter/src/widgets/framework.dart';
class FakeFlutter {
main() {
return new Container(
// start
child: new widget(
child: new /*caret*/DefaultTextStyle(
child: new Row(
children: <Widget>[
new Container(
),
],
),
),