commit 99b67ac0f3c00de167033683a0a0fd489cb8aa45
author Devon Carew <devoncarew@google.com> Fri May 20 18:44:12 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Fri May 20 18:44:12 2022 +0000
tree 3c2dd3ad2c68a8b1851a1bcd9f9b296810c7d3b0
parent abdf68588aa69953ce37d737f24b83c52def1a27

[deps] remove the dep on package:process

Change-Id: Id87554507d8f4557ea9870fcb656302927cb96c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245261
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>

DEPS

diff --git a/DEPS b/DEPS
index d2b7bd9..f9f7f1b 100644
--- a/DEPS
+++ b/DEPS
@@ -135,7 +135,6 @@
   "platform_rev": "1ffad63428bbd1b3ecaa15926bacfb724023648c",
   "ply_rev": "604b32590ffad5cbb82e4afef1d305512d06ae93",
   "pool_rev": "c40cc32eabecb9d60f1045d1403108d968805f9a",
-  "process_rev": "2546dfef7ba839b1514e0c9045344692eb47b771",
   "protobuf_rev": "b149f801cf7a5e959cf1dbf72d61068ac275f24b",
   "pub_rev": "51435efcd574b7bc18d47a5dd620cb9759dea8f8",
   "pub_semver_rev": "ea6c54019948dc03042c595ce9413e17aaf7aa38",
@@ -380,8 +379,6 @@
       Var("dart_git") + "pool.git" + "@" + Var("pool_rev"),
   Var("dart_root") + "/third_party/pkg/protobuf":
        Var("dart_git") + "protobuf.git" + "@" + Var("protobuf_rev"),
-  Var("dart_root") + "/third_party/pkg/process":
-       Var("dart_git") + "process.dart.git" + "@" + Var("process_rev"),
   Var("dart_root") + "/third_party/pkg/pub_semver":
       Var("dart_git") + "pub_semver.git" + "@" + Var("pub_semver_rev"),
   Var("dart_root") + "/third_party/pkg/pub":

pkg/vm_service/pubspec.yaml

diff --git a/pkg/vm_service/pubspec.yaml b/pkg/vm_service/pubspec.yaml
index f8855a0..9eda722 100644
--- a/pkg/vm_service/pubspec.yaml
+++ b/pkg/vm_service/pubspec.yaml
@@ -12,14 +12,12 @@
 dependencies:
 
 dev_dependencies:
-  async: ^2.5.0
+  async: any
   expect: any
   lints: any
-  markdown: ^5.0.0
+  markdown: any
   mockito: any
-  path: ^1.8.0
-  process: ^4.0.0
-  pub_semver: ^2.0.0
-  test: ^1.16.0
-  test_package:
-    path: 'test/test_package'
+  path: any
+  pub_semver: any
+  test: any
+  test_package: any

pkg/vm_service/test/common/test_helper.dart

diff --git a/pkg/vm_service/test/common/test_helper.dart b/pkg/vm_service/test/common/test_helper.dart
index 7561ce0..9f46c4d 100644
--- a/pkg/vm_service/test/common/test_helper.dart
+++ b/pkg/vm_service/test/common/test_helper.dart
@@ -8,7 +8,6 @@
 import 'dart:convert';
 import 'dart:io' as io;
 
-import 'package:process/process.dart';
 import 'package:test/test.dart';
 import 'package:vm_service/vm_service.dart';
 import 'package:vm_service/vm_service_io.dart';
@@ -170,11 +169,9 @@
       arguments.insert(0, '-D$k=$v');
     });
     print('** Launching $bashEnvironment$executable ${arguments.join(' ')}');
-    return LocalProcessManager().start(
-      [
-        executable,
-        ...arguments,
-      ],
+    return io.Process.start(
+      executable,
+      arguments,
       environment: environment,
     );
   }

pkg/vm_service/test/process_service_test.dart

diff --git a/pkg/vm_service/test/process_service_test.dart b/pkg/vm_service/test/process_service_test.dart
index 7fa9aba..14a4444 100644
--- a/pkg/vm_service/test/process_service_test.dart
+++ b/pkg/vm_service/test/process_service_test.dart
@@ -7,7 +7,6 @@
 import 'dart:developer';
 import 'dart:io' as io;
 
-import 'package:process/process.dart';
 import 'package:test/test.dart';
 import 'package:vm_service/vm_service.dart';
 
@@ -45,15 +44,12 @@
   }
 
   Future<ServiceExtensionResponse> setup(ignored_a, ignored_b) async {
-    final processManager = LocalProcessManager();
     try {
-      process1 = await processManager.start(
-        [io.Platform.resolvedExecutable, ...args],
-      );
-      process2 = await processManager.start([
+      process1 = await io.Process.start(io.Platform.resolvedExecutable, args);
+      process2 = await io.Process.start(
         io.Platform.resolvedExecutable,
-        ...(args..add('foobar')),
-      ]);
+        args..add('foobar'),
+      );
       final codeFilePath = dir.path + io.Platform.pathSeparator + "other_file";
       final codeFile = io.File(codeFilePath);
       await codeFile.writeAsString('''
@@ -63,11 +59,11 @@
             await stdin.drain();
           }
           ''');
-      process3 = await processManager.start(
+      process3 = await io.Process.start(
+        io.Platform.resolvedExecutable,
         [
-          io.Platform.resolvedExecutable,
           ...io.Platform.executableArguments,
-          codeFilePath
+          codeFilePath,
         ],
       );
     } catch (_) {