blob: 22cf5e055b1ec8cfe984b9a65bed6b3a5db6d23c [file] [log] [blame]
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// @dart = 2.9
import 'package:analysis_server/src/services/correction/assist.dart';
import 'package:analysis_server/src/services/linter/lint_names.dart';
import 'package:analyzer_plugin/utilities/assist/assist.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
import 'assist_processor.dart';
void main() {
defineReflectiveSuite(() {
defineReflectiveTests(ConvertToSpreadTest);
});
}
@reflectiveTest
class ConvertToSpreadTest extends AssistProcessorTest {
@override
AssistKind get kind => DartAssistKind.CONVERT_TO_SPREAD;
Future<void> test_addAll_condition_const() async {
await resolveTestCode('''
bool condition;
var things;
var l = ['a']..add/*caret*/All(condition ? things : const []);
''');
await assertHasAssist('''
bool condition;
var things;
var l = ['a', if (condition) ...things];
''');
}
Future<void> test_addAll_condition_nonConst() async {
await resolveTestCode('''
bool condition;
var things;
var l = ['a']..add/*caret*/All(condition ? things : []);
''');
await assertHasAssist('''
bool condition;
var things;
var l = ['a', if (condition) ...things];
''');
}
Future<void> test_addAll_expression() async {
await resolveTestCode('''
f() {
var ints = [1, 2, 3];
print(['a']..addAl/*caret*/l(ints.map((i) => i.toString()))..addAll(['c']));
}
''');
await assertHasAssist('''
f() {
var ints = [1, 2, 3];
print(['a', ...ints.map((i) => i.toString())]..addAll(['c']));
}
''');
}
Future<void> test_addAll_expression_noAssistWithLint() async {
createAnalysisOptionsFile(lints: [LintNames.prefer_spread_collections]);
verifyNoTestUnitErrors = false;
await resolveTestCode('''
f() {
var ints = [1, 2, 3];
print(['a']..addAl/*caret*/l(ints.map((i) => i.toString()))..addAll(['c']));
}
''');
await assertNoAssist();
}
Future<void> test_addAll_expression_toEmptyList() async {
await resolveTestCode('''
f() {
var ints = [1, 2, 3];
print([]..addAl/*caret*/l(ints.map((i) => i.toString()))..addAll(['c']));
}
''');
await assertHasAssist('''
f() {
var ints = [1, 2, 3];
print([...ints.map((i) => i.toString())]..addAll(['c']));
}
''');
}
Future<void> test_addAll_literal() async {
// This case is covered by the INLINE_INVOCATION assist.
await resolveTestCode('''
var l = ['a']..add/*caret*/All(['b'])..addAll(['c']);
''');
await assertNoAssist();
}
Future<void> test_addAll_nonLiteralTarget() async {
await resolveTestCode('''
var l1 = [];
var l2 = l1..addAl/*caret*/l(['b'])..addAll(['c']);
''');
await assertNoAssist();
}
Future<void> test_addAll_notFirst() async {
await resolveTestCode('''
var l = ['a']..addAll(['b'])../*caret*/addAll(['c']);
''');
await assertNoAssist();
}
Future<void> test_addAll_nullAware_const() async {
await resolveTestCode('''
var things;
var l = ['a']..add/*caret*/All(things ?? const []);
''');
await assertHasAssist('''
var things;
var l = ['a', ...?things];
''');
}
Future<void> test_addAll_nullAware_nonConst() async {
await resolveTestCode('''
var things;
var l = ['a']..add/*caret*/All(things ?? []);
''');
await assertHasAssist('''
var things;
var l = ['a', ...?things];
''');
}
}