commit 4b78f1b6c7dc4f8ca20431ddc65398f873c6c3e7
author Nate Biggs <natebiggs@google.com> Thu Aug 18 21:30:54 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Thu Aug 18 21:30:54 2022 +0000
tree f2b7dff202e40e9e698636f5832074d9f5e7d497
parent 17311c94d1dc4e8299aee72493cc8636d3f72654

Reland "[dart2js] Enable flag (canary -> shipping) to intern dart type values."

This reverts commit 0e1d24ae80d2411578ce07dac34a03028cae9d98.

Reason for revert: Interning bug fixed by https://dart-review.googlesource.com/c/sdk/+/255257

Original change's description:
> Revert "[dart2js] Enable flag (canary -> shipping) to intern dart type values."
>
> This reverts commit e833510bc5b34c3d6437265e42f34abae1f9f022.
>
> Reason for revert: breaks many tests in G3, see b/242822389
>
> Original change's description:
> > [dart2js] Enable flag (canary -> shipping) to intern dart type values.
> >
> > Change-Id: Iebac3a7c57665eccd100146f892b891a4591f554
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255201
> > Reviewed-by: Stephen Adams <sra@google.com>
> > Commit-Queue: Stephen Adams <sra@google.com>
>
> TBR=sra@google.com,natebiggs@google.com
>
> Change-Id: I9b2be8fc119f84f33181245cdfce416d13660daf
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255401
> Reviewed-by: Ilya Yanok <yanok@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Ilya Yanok <yanok@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I51336c2e53dd58fed6216e9a5c818f05e8795a8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255663
Reviewed-by: Nate Biggs <natebiggs@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>

pkg/compiler/lib/src/options.dart

diff --git a/pkg/compiler/lib/src/options.dart b/pkg/compiler/lib/src/options.dart
index 25a334b..6c8d90d 100644
--- a/pkg/compiler/lib/src/options.dart
+++ b/pkg/compiler/lib/src/options.dart
@@ -105,6 +105,7 @@
   late final List<FeatureOption> shipping = [
     useContentSecurityPolicy,
     deferredSerialization,
+    internValues,
   ];
 
   /// [FeatureOption]s which default to disabled.
@@ -113,7 +114,6 @@
     newDumpInfo,
     simpleAsyncToFuture,
     cfeConstants,
-    internValues,
   ];
 
   /// Forces canary feature on. This must run after [Option].parse.

pkg/compiler/test/dump_info/data/deferred/main.dart

diff --git a/pkg/compiler/test/dump_info/data/deferred/main.dart b/pkg/compiler/test/dump_info/data/deferred/main.dart
index b562e90..b900353 100644
--- a/pkg/compiler/test/dump_info/data/deferred/main.dart
+++ b/pkg/compiler/test/dump_info/data/deferred/main.dart
@@ -104,7 +104,7 @@
   "id": "outputUnit/1",
   "kind": "outputUnit",
   "name": "1",
-  "size": 1087,
+  "size": 1112,
   "filename": "out_1.part.js",
   "imports": [
     "lib"

pkg/compiler/test/dump_info/data/deferred_future/main.dart

diff --git a/pkg/compiler/test/dump_info/data/deferred_future/main.dart b/pkg/compiler/test/dump_info/data/deferred_future/main.dart
index 0d5b68a..5cfb182 100644
--- a/pkg/compiler/test/dump_info/data/deferred_future/main.dart
+++ b/pkg/compiler/test/dump_info/data/deferred_future/main.dart
@@ -110,7 +110,7 @@
   "id": "outputUnit/1",
   "kind": "outputUnit",
   "name": "1",
-  "size": 870,
+  "size": 895,
   "filename": "out_1.part.js",
   "imports": [
     "lib1"