commit 47db18a2daced036f659ba23e8a75281796254c2
author Ryan Macnak <rmacnak@google.com> Wed May 11 19:31:04 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Wed May 11 19:31:04 2022 +0000
tree 167aeffa2adda516a0326c31a3ec8e10876dd503
parent 3c10e484c94fb71fe8f8c6822131db874c89e9cf

[vm] Fix default log filtering to include the vm-service.

This was probably broken by some refactoring related to isolate groups.

TEST=--disassemble-stubs
Change-Id: If46259836d2276d50fefc5598f8370bf935ec95e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244481
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>

runtime/vm/log.cc

diff --git a/runtime/vm/log.cc b/runtime/vm/log.cc
index 809df77..70669b3 100644
--- a/runtime/vm/log.cc
+++ b/runtime/vm/log.cc
@@ -161,8 +161,11 @@
 
 bool Log::ShouldLogForIsolateGroup(const IsolateGroup* isolate_group) {
   if (FLAG_isolate_log_filter == nullptr) {
+    // By default, do not log for the service or kernel isolates.
+    if (isolate_group == Dart::vm_isolate_group()) {
+      return true;
+    }
     if (IsolateGroup::IsSystemIsolateGroup(isolate_group)) {
-      // By default, do not log for the service or kernel isolates.
       return false;
     }
     return true;