commit 43166018a96181819905d292232b69df5e67aa3e
author Paul Berry <paulberry@google.com> Tue Oct 20 16:16:03 2020 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Tue Oct 20 16:16:03 2020 +0000
tree 357d7c18cc4dd9e70879cf695961471059caed0f
parent 48c73d82bfe98bd39a9e6cb57f70954f4f633e2d

Nomenclature fix: migration diff output is not a summary.

The output the migration tool generates when the web preview is
disabled shows a complete diff of all changes the tool will make, so
it's really a misnomer to call it a "summary".

Change-Id: I8c7d9f9870bf8beffb62f1d10d36a65b66c32657
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168381
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>

pkg/nnbd_migration/lib/migration_cli.dart

diff --git a/pkg/nnbd_migration/lib/migration_cli.dart b/pkg/nnbd_migration/lib/migration_cli.dart
index 6c83181..5d998c3 100644
--- a/pkg/nnbd_migration/lib/migration_cli.dart
+++ b/pkg/nnbd_migration/lib/migration_cli.dart
@@ -808,9 +808,9 @@
       await blockUntilSignalInterrupt();
       nonNullableFix.shutdownServer();
     } else {
-      logger.stdout(ansi.emphasized('Summary of changes:'));
+      logger.stdout(ansi.emphasized('Diff of changes:'));
 
-      _displayChangeSummary(_dartFixListener);
+      _displayChangeDiff(_dartFixListener);
 
       logger.stdout('');
       logger.stdout('To apply these changes, re-run the tool with '
@@ -879,7 +879,7 @@
     }
   }
 
-  void _displayChangeSummary(DartFixListener migrationResults) {
+  void _displayChangeDiff(DartFixListener migrationResults) {
     Map<String, List<DartFixSuggestion>> fileSuggestions = {};
     for (DartFixSuggestion suggestion in migrationResults.suggestions) {
       String file = suggestion.location.file;

pkg/nnbd_migration/test/migration_cli_test.dart

diff --git a/pkg/nnbd_migration/test/migration_cli_test.dart b/pkg/nnbd_migration/test/migration_cli_test.dart
index d07dd6d..febc90b 100644
--- a/pkg/nnbd_migration/test/migration_cli_test.dart
+++ b/pkg/nnbd_migration/test/migration_cli_test.dart
@@ -999,7 +999,7 @@
     assertNormalExit(cliRunner);
     // Check that a summary was printed
     var output = logger.stdoutBuffer.toString();
-    expect(output, contains('Summary'));
+    expect(output, contains('Diff of changes'));
     // And that it refers to test.dart and pubspec.yaml
     expect(output, contains('test.dart'));
     expect(output, contains('pubspec.yaml'));