| commit | 34e4a6d814c54fabdb209e5368b6d01bb55b8dd4 | [log] [tgz] |
|---|---|---|
| author | Jens Johansen <jensj@google.com> | Thu Oct 08 13:23:45 2020 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Thu Oct 08 13:23:45 2020 +0000 |
| tree | 463a4d30b07b234b592d2b5d860110e627a68372 | |
| parent | 87dd7c03e14856c8e089ca27a02af205b8d665f5 [diff] |
[CFE] Remove inconsistency where visitIsExpression called .accept directly Change-Id: I81d0e99e6908f24d082cfa57454db8fdc3b333be Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166625 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
diff --git a/pkg/front_end/lib/src/fasta/kernel/constant_evaluator.dart b/pkg/front_end/lib/src/fasta/kernel/constant_evaluator.dart index edb4a54..d237dcf 100644 --- a/pkg/front_end/lib/src/fasta/kernel/constant_evaluator.dart +++ b/pkg/front_end/lib/src/fasta/kernel/constant_evaluator.dart
@@ -2361,9 +2361,7 @@ @override Constant visitIsExpression(IsExpression node) { - // TODO(jensj): Why does this call .accept directly? - // (@askesc says it's probably an oversight) - final Constant constant = node.operand.accept(this); + final Constant constant = _evaluateSubexpression(node.operand); if (constant is AbortConstant) return constant; if (shouldBeUnevaluated) { return unevaluated(