Deprecate 'withInformative' in link()
Change-Id: I6da8baf8cbac140b20351b5b93fc6858603ba8d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217380
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
diff --git a/pkg/analyzer/lib/dart/sdk/build_sdk_summary.dart b/pkg/analyzer/lib/dart/sdk/build_sdk_summary.dart
index d2062c5..c87a35f 100644
--- a/pkg/analyzer/lib/dart/sdk/build_sdk_summary.dart
+++ b/pkg/analyzer/lib/dart/sdk/build_sdk_summary.dart
@@ -106,7 +106,7 @@
Reference.root(),
);
- var linkResult = link(elementFactory, inputLibraries, false);
+ var linkResult = link(elementFactory, inputLibraries);
var bundleBuilder = PackageBundleBuilder();
for (var library in inputLibraries) {
diff --git a/pkg/analyzer/lib/src/dart/analysis/library_context.dart b/pkg/analyzer/lib/src/dart/analysis/library_context.dart
index 72092ad..af4763e 100644
--- a/pkg/analyzer/lib/src/dart/analysis/library_context.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/library_context.dart
@@ -175,7 +175,7 @@
link2.LinkResult linkResult;
try {
timerLinking.start();
- linkResult = link2.link(elementFactory, inputLibraries, true);
+ linkResult = link2.link(elementFactory, inputLibraries);
librariesLinked += cycle.libraries.length;
counterLinkedLibraries += inputLibraries.length;
timerLinking.stop();
diff --git a/pkg/analyzer/lib/src/dart/micro/resolve_file.dart b/pkg/analyzer/lib/src/dart/micro/resolve_file.dart
index ab564f3..7ff94e7 100644
--- a/pkg/analyzer/lib/src/dart/micro/resolve_file.dart
+++ b/pkg/analyzer/lib/src/dart/micro/resolve_file.dart
@@ -877,7 +877,7 @@
}
inputsTimer.stop();
- var linkResult = link2.link(elementFactory, inputLibraries, true);
+ var linkResult = link2.link(elementFactory, inputLibraries);
librariesLinked += cycle.libraries.length;
resolutionBytes = linkResult.resolutionBytes;
diff --git a/pkg/analyzer/lib/src/summary2/link.dart b/pkg/analyzer/lib/src/summary2/link.dart
index db4d362..5665fb5 100644
--- a/pkg/analyzer/lib/src/summary2/link.dart
+++ b/pkg/analyzer/lib/src/summary2/link.dart
@@ -25,12 +25,10 @@
var timerLinkingLinkingBundle = Stopwatch();
/// Note that AST units and tokens of [inputLibraries] will be damaged.
-///
-/// TODO(scheglov) deprecate `withInformative`.
LinkResult link(
LinkedElementFactory elementFactory,
List<LinkInputLibrary> inputLibraries, [
- bool? withInformative,
+ @Deprecated('Not used anymore') bool? withInformative,
]) {
var linker = Linker(elementFactory);
linker.link(inputLibraries);
diff --git a/pkg/analyzer/test/src/summary/resynthesize_ast2_test.dart b/pkg/analyzer/test/src/summary/resynthesize_ast2_test.dart
index bc041e1..b1f2a75 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_ast2_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_ast2_test.dart
@@ -84,7 +84,7 @@
Reference.root(),
);
- var sdkLinkResult = link(elementFactory, inputLibraries, true);
+ var sdkLinkResult = link(elementFactory, inputLibraries);
return _sdkBundle = _SdkBundle(
resolutionBytes: sdkLinkResult.resolutionBytes,
@@ -128,7 +128,7 @@
),
);
- var linkResult = link(elementFactory, inputLibraries, true);
+ var linkResult = link(elementFactory, inputLibraries);
if (!keepLinkingLibraries) {
elementFactory.removeBundle(
