commit 2316c7291c82a6200b6e18da9876c1c6b9509e5d
author Sam Rawlins <srawlins@google.com> Mon May 02 03:37:59 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Mon May 02 03:37:59 2022 +0000
tree f8aedb0c98f1dc9c9a0878c5cd58d12e5a81957d
parent 5751410ad33f75a96d6b2fe69ea1919e8cd01cc5

Move existsSync into try/catch, to fix flake

Fixes https://github.com/dart-lang/sdk/issues/48271

Change-Id: Ie1eb59f0f5ba873822d9c277f00482a7d4cf74cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>

pkg/dartdev/test/utils.dart

diff --git a/pkg/dartdev/test/utils.dart b/pkg/dartdev/test/utils.dart
index e77686f..f159c9b 100644
--- a/pkg/dartdev/test/utils.dart
+++ b/pkg/dartdev/test/utils.dart
@@ -109,11 +109,15 @@
     await _process?.exitCode;
     _process = null;
     int deleteAttempts = 5;
-    while (dir.existsSync()) {
+    while (deleteAttempts >= 0) {
+      deleteAttempts--;
       try {
+        if (!dir.existsSync()) {
+          return;
+        }
         dir.deleteSync(recursive: true);
       } catch (e) {
-        if ((--deleteAttempts) <= 0) {
+        if (deleteAttempts <= 0) {
           rethrow;
         }
         await Future.delayed(Duration(milliseconds: 500));