commit 20e91760fda0ed4c2c5060284823a272c94e4596
author Clement Skau <cskau@google.com> Fri Oct 18 15:20:36 2019 +0000
committer Alexander Thomas <athom@google.com> Mon Oct 21 13:51:01 2019 +0200
tree 776b993f26160b9be68efe0184bbeb666f1e5f58
parent 0d3dc31595fa6aa996876ebe11bbdcb646971fb3

[SDK] Fixes run_appended_aotsnapshot_test on Windows.

Bug: https://github.com/dart-lang/sdk/issues/38974
Change-Id: I5fafb29252f20a536b5543d309ddeb4ccd3421ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122145
Auto-Submit: Clement Skau <cskau@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>

runtime/tests/vm/dart/run_appended_aot_snapshot_test.dart

diff --git a/runtime/tests/vm/dart/run_appended_aot_snapshot_test.dart b/runtime/tests/vm/dart/run_appended_aot_snapshot_test.dart
index da854d2..26b7a9c 100644
--- a/runtime/tests/vm/dart/run_appended_aot_snapshot_test.dart
+++ b/runtime/tests/vm/dart/run_appended_aot_snapshot_test.dart
@@ -63,7 +63,7 @@
       Map<String, String> environment = {'PATH': tmp};
       final runResult = await runBinary(
           'run appended aot snapshot from PATH', exeName, ['--child'],
-          environment: environment);
+          environment: environment, runInShell: true);
       expectOutput('Hello, Appended AOT', runResult);
     }
 
@@ -76,7 +76,8 @@
           'run appended aot snapshot without extension',
           exeNameWithoutExt,
           ['--child'],
-          environment: environment);
+          environment: environment,
+          runInShell: true);
       expectOutput('Hello, Appended AOT', runResult);
     }
   });

runtime/tests/vm/dart/snapshot_test_helper.dart

diff --git a/runtime/tests/vm/dart/snapshot_test_helper.dart b/runtime/tests/vm/dart/snapshot_test_helper.dart
index e3f8b6c..8ffd309 100644
--- a/runtime/tests/vm/dart/snapshot_test_helper.dart
+++ b/runtime/tests/vm/dart/snapshot_test_helper.dart
@@ -73,10 +73,10 @@
 }
 
 Future<Result> runBinary(String prefix, String binary, List<String> arguments,
-    {Map<String, String> environment}) async {
+    {Map<String, String> environment, bool runInShell: false}) async {
   print("+ $binary " + arguments.join(" "));
-  final processResult =
-      await Process.run(binary, arguments, environment: environment);
+  final processResult = await Process.run(binary, arguments,
+      environment: environment, runInShell: runInShell);
   final result =
       new Result('[$prefix] ${binary} ${arguments.join(' ')}', processResult);