commit 198450f53cdb1dd0ea17e9989decdc7d0b37ffb8
author Ryan Macnak <rmacnak@google.com> Mon Apr 19 20:18:28 2021 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Mon Apr 19 20:18:28 2021 +0000
tree 9218fbef58650bced7dd58c4625d80cbd4557d5e
parent 29c590dcd29a6ca7bc35de866b369ee81da6d107

[build] Note that x64c does not use a simulator.

Fixes gn.py to agree with dfe.cc that x64c uses app-jit snapshots instead of kernel files for kernel service (and snapshots included in the SDK).

TEST=vm/cc suite
Bug: https://github.com/dart-lang/sdk/issues/45696
Change-Id: Ib15cbf46e9d26a179539aa62675b0cb0342d29e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195541
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

tools/gn.py

diff --git a/tools/gn.py b/tools/gn.py
index dc355cf..f711dd3 100755
--- a/tools/gn.py
+++ b/tools/gn.py
@@ -163,7 +163,7 @@
         # Tell Crashpad's BUILD files which checkout layout to use.
         gn_args['crashpad_dependencies'] = 'dart'
 
-    if arch != HostCpuForArch(arch):
+    if DartTargetCpuForArch(arch) != HostCpuForArch(arch):
         # Training an app-jit snapshot under a simulator is slow. Use script
         # snapshots instead.
         gn_args['dart_snapshot_kind'] = 'kernel'