A few renames of TypeName to NamedType.
Change-Id: Ie0eae6906457a28665855eb16371ad2230d1104a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218743
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
diff --git a/pkg/analyzer/lib/src/dart/resolver/function_reference_resolver.dart b/pkg/analyzer/lib/src/dart/resolver/function_reference_resolver.dart
index da8742a..7c8bc9f 100644
--- a/pkg/analyzer/lib/src/dart/resolver/function_reference_resolver.dart
+++ b/pkg/analyzer/lib/src/dart/resolver/function_reference_resolver.dart
@@ -40,7 +40,7 @@
ErrorReporter get _errorReporter => _resolver.errorReporter;
- NullabilitySuffix get _nullabilitySuffixForTypeNames =>
+ NullabilitySuffix get _nullabilitySuffix =>
_isNonNullableByDefault ? NullabilitySuffix.none : NullabilitySuffix.star;
void resolve(FunctionReferenceImpl node) {
@@ -310,7 +310,7 @@
);
var type = element.instantiate(
typeArguments: typeArguments,
- nullabilitySuffix: _nullabilitySuffixForTypeNames,
+ nullabilitySuffix: _nullabilitySuffix,
);
_resolveTypeLiteral(node: node, instantiatedType: type, name: name);
}
@@ -783,8 +783,9 @@
CompileTimeErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS,
);
var type = element.instantiate(
- typeArguments: typeArguments,
- nullabilitySuffix: _nullabilitySuffixForTypeNames);
+ typeArguments: typeArguments,
+ nullabilitySuffix: _nullabilitySuffix,
+ );
_resolveTypeLiteral(node: node, instantiatedType: type, name: typeAlias);
}
diff --git a/pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart b/pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
index 0fb4f74..2e361ad 100644
--- a/pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
+++ b/pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
@@ -63,7 +63,7 @@
final bool _isNonNullableByDefault;
final ErrorReporter _errorReporter;
final AstRewriter _astRewriter;
- final NamedTypeResolver _typeNameResolver;
+ final NamedTypeResolver _namedTypeResolver;
/// This index is incremented every time we visit a [LibraryDirective].
/// There is just one [LibraryElement], so we can support only one node.
@@ -103,7 +103,7 @@
isNonNullableByDefault: isNonNullableByDefault,
);
- var typeNameResolver = NamedTypeResolver(
+ var namedTypeResolver = NamedTypeResolver(
libraryElement,
typeProvider,
isNonNullableByDefault,
@@ -117,7 +117,7 @@
isNonNullableByDefault,
errorReporter,
AstRewriter(errorReporter, typeProvider),
- typeNameResolver,
+ namedTypeResolver,
nameScope,
elementWalker,
ElementHolder(unitElement),
@@ -131,7 +131,7 @@
this._isNonNullableByDefault,
this._errorReporter,
this._astRewriter,
- this._typeNameResolver,
+ this._namedTypeResolver,
this._nameScope,
this._elementWalker,
this._elementHolder,
@@ -218,7 +218,7 @@
void visitClassDeclaration(covariant ClassDeclarationImpl node) {
ClassElementImpl element = _elementWalker!.getClass();
node.name.staticElement = element;
- _typeNameResolver.enclosingClass = element;
+ _namedTypeResolver.enclosingClass = element;
node.metadata.accept(this);
_setElementAnnotations(node.metadata, element.metadata);
@@ -247,14 +247,14 @@
});
});
- _typeNameResolver.enclosingClass = null;
+ _namedTypeResolver.enclosingClass = null;
}
@override
void visitClassTypeAlias(covariant ClassTypeAliasImpl node) {
ClassElementImpl element = _elementWalker!.getClass();
node.name.staticElement = element;
- _typeNameResolver.enclosingClass = element;
+ _namedTypeResolver.enclosingClass = element;
node.metadata.accept(this);
_setElementAnnotations(node.metadata, element.metadata);
@@ -275,7 +275,7 @@
});
});
- _typeNameResolver.enclosingClass = null;
+ _namedTypeResolver.enclosingClass = null;
}
@override
@@ -885,11 +885,11 @@
void visitNamedType(covariant NamedTypeImpl node) {
node.typeArguments?.accept(this);
- _typeNameResolver.nameScope = _nameScope;
- _typeNameResolver.resolve(node);
+ _namedTypeResolver.nameScope = _nameScope;
+ _namedTypeResolver.resolve(node);
- if (_typeNameResolver.rewriteResult != null) {
- _typeNameResolver.rewriteResult!.accept(this);
+ if (_namedTypeResolver.rewriteResult != null) {
+ _namedTypeResolver.rewriteResult!.accept(this);
}
}
@@ -1242,11 +1242,11 @@
if (redirectedConstructor == null) return;
var namedType = redirectedConstructor.type2;
- _typeNameResolver.redirectedConstructor_namedType = namedType;
+ _namedTypeResolver.redirectedConstructor_namedType = namedType;
redirectedConstructor.accept(this);
- _typeNameResolver.redirectedConstructor_namedType = null;
+ _namedTypeResolver.redirectedConstructor_namedType = null;
}
/// Return the [InterfaceType] of the given [namedType].
@@ -1258,11 +1258,11 @@
/// classes).
void _resolveType(NamedTypeImpl namedType, ErrorCode errorCode,
{bool asClass = false}) {
- _typeNameResolver.classHierarchy_namedType = namedType;
+ _namedTypeResolver.classHierarchy_namedType = namedType;
visitNamedType(namedType);
- _typeNameResolver.classHierarchy_namedType = null;
+ _namedTypeResolver.classHierarchy_namedType = null;
- if (_typeNameResolver.hasErrorReported) {
+ if (_namedTypeResolver.hasErrorReported) {
return;
}
@@ -1303,12 +1303,12 @@
if (clause == null) return;
for (var namedType in clause.mixinTypes2) {
- _typeNameResolver.withClause_namedType = namedType;
+ _namedTypeResolver.withClause_namedType = namedType;
_resolveType(
namedType as NamedTypeImpl,
CompileTimeErrorCode.MIXIN_OF_NON_CLASS,
);
- _typeNameResolver.withClause_namedType = null;
+ _namedTypeResolver.withClause_namedType = null;
}
}
diff --git a/pkg/analyzer/test/src/dart/analysis/driver_resolution_test.dart b/pkg/analyzer/test/src/dart/analysis/driver_resolution_test.dart
index 65e9392..d9bdc60 100644
--- a/pkg/analyzer/test/src/dart/analysis/driver_resolution_test.dart
+++ b/pkg/analyzer/test/src/dart/analysis/driver_resolution_test.dart
@@ -51,7 +51,7 @@
TypeArgumentList argumentList, List<DartType> expectedTypes) {
expect(argumentList.arguments, hasLength(expectedTypes.length));
for (int i = 0; i < expectedTypes.length; i++) {
- _assertTypeNameSimple(argumentList.arguments[i], expectedTypes[i]);
+ _assertNamedTypeSimple(argumentList.arguments[i], expectedTypes[i]);
}
}
@@ -1804,11 +1804,11 @@
expect(type.parameters[0].type, typeProvider.intType);
}
- _assertTypeNameSimple(p.returnType!, typeProvider.stringType);
+ _assertNamedTypeSimple(p.returnType!, typeProvider.stringType);
{
var a = p.parameters.parameters[0] as SimpleFormalParameter;
- _assertTypeNameSimple(a.type!, typeProvider.intType);
+ _assertNamedTypeSimple(a.type!, typeProvider.intType);
expect(a.identifier!.staticType, isNull);
}
}
@@ -1850,11 +1850,11 @@
expect(type.parameters[0].type, typeProvider.intType);
}
- _assertTypeNameSimple(p.type!, typeProvider.stringType);
+ _assertNamedTypeSimple(p.type!, typeProvider.stringType);
{
var a = p.parameters!.parameters[0] as SimpleFormalParameter;
- _assertTypeNameSimple(a.type!, typeProvider.intType);
+ _assertNamedTypeSimple(a.type!, typeProvider.intType);
expect(a.identifier!.staticType, isNull);
}
}
@@ -1912,7 +1912,7 @@
expect(parameterElement.field, same(fElement));
var parameterNode = parameters[0] as FieldFormalParameter;
- _assertTypeNameSimple(parameterNode.type!, typeProvider.intType);
+ _assertNamedTypeSimple(parameterNode.type!, typeProvider.intType);
expect(parameterNode.declaredElement, same(parameterElement));
expect(parameterNode.identifier.staticElement, same(parameterElement));
@@ -1980,7 +1980,7 @@
List<TypeAnnotation> typeArguments = invocation.typeArguments!.arguments;
expect(typeArguments, hasLength(1));
- _assertTypeNameSimple(typeArguments[0], typeProvider.stringType);
+ _assertNamedTypeSimple(typeArguments[0], typeProvider.stringType);
}
test_functionExpressionInvocation_namedArgument() async {
@@ -2307,7 +2307,7 @@
NamedType namedType = constructorName.type2;
expect(namedType.typeArguments!.arguments, hasLength(1));
- _assertTypeNameSimple(
+ _assertNamedTypeSimple(
namedType.typeArguments!.arguments[0], typeProvider.boolType);
var typeIdentifier = namedType.name as PrefixedIdentifier;
@@ -2384,7 +2384,7 @@
NamedType namedType = constructorName.type2;
expect(namedType.typeArguments!.arguments, hasLength(1));
- _assertTypeNameSimple(
+ _assertNamedTypeSimple(
namedType.typeArguments!.arguments[0], typeProvider.boolType);
var typeIdentifier = namedType.name as SimpleIdentifier;
@@ -2432,7 +2432,7 @@
NamedType namedType = constructorName.type2;
expect(namedType.typeArguments!.arguments, hasLength(1));
- _assertTypeNameSimple(
+ _assertNamedTypeSimple(
namedType.typeArguments!.arguments[0], typeProvider.boolType);
var typeIdentifier = namedType.name as SimpleIdentifier;
@@ -4906,10 +4906,10 @@
LocalVariableElement vElement = vNode.declaredElement!;
expect(vElement.type, typeProvider.numType);
- var vTypeName = vNode.type as NamedType;
- expect(vTypeName.type, typeProvider.numType);
+ var vNamedType = vNode.type as NamedType;
+ expect(vNamedType.type, typeProvider.numType);
- var vTypeIdentifier = vTypeName.name as SimpleIdentifier;
+ var vTypeIdentifier = vNamedType.name as SimpleIdentifier;
expect(vTypeIdentifier.staticElement, typeProvider.numType.element);
expect(vTypeIdentifier.staticType, isNull);
@@ -7439,7 +7439,7 @@
expect(bElement.type, typeProvider.doubleType);
var namedType = bDeclaration.variables.type as NamedType;
- _assertTypeNameSimple(namedType, typeProvider.doubleType);
+ _assertNamedTypeSimple(namedType, typeProvider.doubleType);
expect(bNode.name.staticElement, same(bElement));
expect(bNode.name.staticType, isNull);
@@ -7579,7 +7579,7 @@
expect(aliasElement, same(findElement.typeAlias('F')));
expect(function.returnType, typeProvider.intType);
- _assertTypeNameSimple(alias.returnType as NamedType, typeProvider.intType);
+ _assertNamedTypeSimple(alias.returnType as NamedType, typeProvider.intType);
_assertSimpleParameter(
alias.parameters.parameters[0] as SimpleFormalParameter,
@@ -7645,10 +7645,10 @@
expect(listIdentifier.staticElement, same(listElement));
expect(listIdentifier.staticType, isNull);
- var aTypeName = bound.typeArguments!.arguments[0] as NamedType;
- expect(aTypeName.type, interfaceTypeNone(aElement));
+ var aNamedType = bound.typeArguments!.arguments[0] as NamedType;
+ expect(aNamedType.type, interfaceTypeNone(aElement));
- var aIdentifier = aTypeName.name as SimpleIdentifier;
+ var aIdentifier = aNamedType.name as SimpleIdentifier;
expect(aIdentifier.staticElement, same(aElement));
expect(aIdentifier.staticType, isNull);
}
@@ -7717,7 +7717,7 @@
{
var statement = statements[1] as TryStatement;
CatchClause catchClause = statement.catchClauses[0];
- _assertTypeNameSimple(
+ _assertNamedTypeSimple(
catchClause.exceptionType as NamedType, typeProvider.intType);
var exceptionNode = catchClause.exceptionParameter as SimpleIdentifier;
@@ -7760,7 +7760,7 @@
{
var statement = statements[3] as TryStatement;
CatchClause catchClause = statement.catchClauses[0];
- _assertTypeNameSimple(catchClause.exceptionType!, typeProvider.intType);
+ _assertNamedTypeSimple(catchClause.exceptionType!, typeProvider.intType);
expect(catchClause.stackTraceParameter, isNull);
var exceptionNode = catchClause.exceptionParameter as SimpleIdentifier;
@@ -7773,7 +7773,7 @@
{
var statement = statements[4] as TryStatement;
CatchClause catchClause = statement.catchClauses[0];
- _assertTypeNameSimple(
+ _assertNamedTypeSimple(
catchClause.exceptionType as NamedType, typeProvider.intType);
expect(catchClause.exceptionParameter, isNull);
expect(catchClause.stackTraceParameter, isNull);
@@ -7821,7 +7821,7 @@
List<TypeAnnotation> typeArguments = namedType.typeArguments!.arguments;
expect(typeArguments, hasLength(1));
- _assertTypeNameSimple(typeArguments[0], typeProvider.intType);
+ _assertNamedTypeSimple(typeArguments[0], typeProvider.intType);
}
test_type_void() async {
@@ -8657,6 +8657,15 @@
}
}
+ void _assertNamedTypeSimple(TypeAnnotation namedType, DartType type) {
+ namedType as NamedType;
+ expect(namedType.type, type);
+
+ var identifier = namedType.name as SimpleIdentifier;
+ expect(identifier.staticElement, same(type.element));
+ expect(identifier.staticType, isNull);
+ }
+
void _assertParameterElement(ParameterElement element,
{String? name, int? offset, ParameterKind? kind, DartType? type}) {
expect(element, isNotNull);
@@ -8688,15 +8697,6 @@
}
}
- void _assertTypeNameSimple(TypeAnnotation namedType, DartType type) {
- namedType as NamedType;
- expect(namedType.type, type);
-
- var identifier = namedType.name as SimpleIdentifier;
- expect(identifier.staticElement, same(type.element));
- expect(identifier.staticType, isNull);
- }
-
List<Statement> _getMainStatements(ResolvedUnitResult result) {
for (var declaration in result.unit.declarations) {
if (declaration is FunctionDeclaration &&
