commit 03ba8c16aaeecdd3e73f1aa9129ef6d075cca344
author Zach Anderson <zra@google.com> Wed Jan 09 02:56:22 2019 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Wed Jan 09 02:56:22 2019 +0000
tree 4174793f73cb78717c38d81c54ecf64dfa598459
parent 5f59e42f9c8df105cfea3e4b4f7d128852e47f62

[vm,fuchsia] Disable safe-stack

When running with safe-stack, the interpreter's C++ stack gets
clobbered, but does not get clobbered when running without safe-stack.
Disabling while investigating further to avoid crashes in Fuchsia.

Change-Id: I8ea03ee0e243e878a6f01ce499ad2ff109501d8b
Reviewed-on: https://dart-review.googlesource.com/c/88747
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>

runtime/BUILD.gn

diff --git a/runtime/BUILD.gn b/runtime/BUILD.gn
index 3eb59b3..0e3e2e2 100644
--- a/runtime/BUILD.gn
+++ b/runtime/BUILD.gn
@@ -191,6 +191,11 @@
     if (defined(is_tsan) && is_tsan) {
       ldflags += [ "-fsanitize=thread" ]
     }
+
+    if (is_fuchsia) {
+      # safe-stack does not work with the interpreter.
+      cflags += [ "-fno-sanitize=safe-stack" ]
+    }
   }
 }