Improve stack traces in many tests (#2673)
Use less magic. Allows clean async stack traces on failure
diff --git a/test/test_pub.dart b/test/test_pub.dart
index 14986a7..f1d1010 100644
--- a/test/test_pub.dart
+++ b/test/test_pub.dart
@@ -312,23 +312,23 @@
args: args, workingDirectory: workingDirectory, environment: environment);
await pub.shouldExit(exitCode);
- expect(() async {
- var actualOutput = (await pub.stdoutStream().toList()).join('\n');
- var actualError = (await pub.stderrStream().toList()).join('\n');
- var actualSilent = (await pub.silentStream().toList()).join('\n');
+ var actualOutput = (await pub.stdoutStream().toList()).join('\n');
+ var actualError = (await pub.stderrStream().toList()).join('\n');
+ var actualSilent = (await pub.silentStream().toList()).join('\n');
- var failures = <String>[];
- if (outputJson == null) {
- _validateOutput(failures, 'stdout', output, actualOutput);
- } else {
- _validateOutputJson(failures, 'stdout', outputJson, actualOutput);
- }
+ var failures = <String>[];
+ if (outputJson == null) {
+ _validateOutput(failures, 'stdout', output, actualOutput);
+ } else {
+ _validateOutputJson(failures, 'stdout', outputJson, actualOutput);
+ }
- _validateOutput(failures, 'stderr', error, actualError);
- _validateOutput(failures, 'silent', silent, actualSilent);
+ _validateOutput(failures, 'stderr', error, actualError);
+ _validateOutput(failures, 'silent', silent, actualSilent);
- if (failures.isNotEmpty) test.fail(failures.join('\n'));
- }(), completes);
+ if (failures.isNotEmpty) {
+ test.fail(failures.join('\n'));
+ }
}
/// Like [startPub], but runs `pub lish` in particular with [server] used both
