commit c065e559070912942f5e12c04fae9fb0512b3b8b
author Sigurd Meldgaard <sigurdm@google.com> Mon Sep 05 10:38:00 2022 +0200
committer GitHub <noreply@github.com> Mon Sep 05 10:38:00 2022 +0200
tree d165b455a739e07a077e8bb5bd343f76e1d45a8c
parent 8e306f33daa291f8483af53e6da749cc11bacf7e

Remove unnecessary nullability (#3547)

lib/src/solver/package_lister.dart

diff --git a/lib/src/solver/package_lister.dart b/lib/src/solver/package_lister.dart
index 1198864..ce2b4c1 100644
--- a/lib/src/solver/package_lister.dart
+++ b/lib/src/solver/package_lister.dart
@@ -140,22 +140,22 @@
   ///
   /// Throws a [PackageNotFoundException] if this lister's package doesn't
   /// exist.
-  Future<PackageId?> bestVersion(VersionConstraint? constraint) async {
+  Future<PackageId?> bestVersion(VersionConstraint constraint) async {
     final locked = _locked;
-    if (locked != null && constraint!.allows(locked.version)) return locked;
+    if (locked != null && constraint.allows(locked.version)) return locked;
 
     var versions = await _versions;
 
     // If [constraint] has a minimum (or a maximum in downgrade mode), we can
     // bail early once we're past it.
-    var isPastLimit = (Version? _) => false;
+    var isPastLimit = (Version _) => false;
     if (constraint is VersionRange) {
       if (_isDowngrade) {
         var max = constraint.max;
-        if (max != null) isPastLimit = (version) => version! > max;
+        if (max != null) isPastLimit = (version) => version > max;
       } else {
         var min = constraint.min;
-        if (min != null) isPastLimit = (version) => version! < min;
+        if (min != null) isPastLimit = (version) => version < min;
       }
     }
 
@@ -166,7 +166,7 @@
     for (var id in _isDowngrade ? versions : versions.reversed) {
       if (isPastLimit(id.version)) break;
 
-      if (!constraint!.allows(id.version)) continue;
+      if (!constraint.allows(id.version)) continue;
       if (!id.version.isPreRelease) {
         return id;
       }