Elements. Centralize child fragment creation in ElementBuilder. This commit refactors the process of associating child fragments with their parent fragments within the summary2 element builder. The primary goal is to reduce code duplication and improve maintainability by centralizing the logic for creating these parent-child relationships. Previously, the logic for adding a child fragment to its parent was repeated in multiple locations throughout FragmentBuilder. This typically involved: 1. Retrieving the parent fragment from the current _enclosingContext. 2. Manually setting the enclosingFragment property on the child. 3. Calling _libraryBuilder.addFragmentChild to register the relationship. These scattered and repetitive blocks of code have been replaced with a single, unified helper method. Key changes: - A new private method _addChildFragment(FragmentImpl child) is introduced in FragmentBuilder. This method encapsulates the entire process of linking a child fragment to its parent, which is retrieved from the current context. - The responsibility for setting the child.enclosingFragment property has been moved into LibraryBuilder.addChildFragment(). This ensures that the enclosing fragment is always set consistently whenever a child is added, making the process more robust. - All call sites within FragmentBuilder (for constructors, enum constants, fields, methods, etc.) have been updated to use the new _addChildFragment() method, significantly simplifying the code in visitor methods. - visitEnumDeclaration now wraps creating children fragments with `_withEnclosing` so that `_addChildFragment` can rely on having enclosing enum fragment. - As part of this refactoring, the point at which a ConstructorFragment is added to its enclosing InterfaceFragment was moved from FragmentBuilder.visitConstructorDeclaration to ElementBuilder.buildConstructorElement. This is a more logical location for this operation, as it occurs during the final element construction phase. This refactoring does not change any analyzer behavior but improves the internal code quality, making it cleaner, more readable, and easier to maintain. Change-Id: I254a1fbc23fe9f27e72ed7d15b0661d6cfa47816 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/441836 Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> https://dart.googlesource.com/sdk/+/8acd5894e012d38b2ea3e58548a7f497c8e5dbf2
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.