| commit | be849bc2dfb37867b56f1ec3c4f140b546646719 | [log] [tgz] |
|---|---|---|
| author | Tess Strickland <sstrickl@google.com> | Mon Dec 04 16:20:50 2023 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Mon Dec 04 08:23:08 2023 -0800 |
| tree | 1a7f52f87a3dbaacfa02d379d04525fdebae2ccb | |
| parent | 91d535a5ea71755bed81e6b68e4f50c81b968cc1 [diff] |
[vm] Ensure element type is checked for typed data setRange calls. In c93f924c82, the separate setRange definitions in _TypedIntListMixin, _TypedDoubleListMixin, _Float32x4ListMixin, _Float64x2ListMixin, and _Int32x4ListMixin were replaced with a single definition in _TypedListBase. In doing so, the signature was changed: now the `from` argument is just an Iterable, instead of the more specific Iterable<int>/Iterable<double>/etc in the original definitions. setRange calls two helper methods, _fastSetRange, when from is also a _TypedListBase whose elements are the same size, and _slowSetRange, for all other cases. In _slowSetRange, various casts and checks ensure that the setRange method was called with a compatible element type, but _fastSetRange only checks the _size_ of the element type, not the element type itself, before doing a memory move between the two _TypedListBase objects. That means via upcasting, elements can be copied from an argument with an incompatible element type to the receiver, which would have resulted in a TypeError being thrown before. Change the unified setRange definition to _setRange and recreate the old separate setRange definitions with the more specific signatures, with the separate definitions delegating to _setRange. TEST=vm/dart/regress_53945 Fixes: https://github.com/dart-lang/sdk/issues/53945 Cq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-x64-try,vm-aot-linux-release-x64-try Change-Id: If7eef0b2e07c63aaf776de7b26b1c2cc8c57607d Fixed: 53945 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/334201 Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com> https://dart.googlesource.com/sdk/+/7ffb8574ee4a01fb542470a8d1af977f737432d1
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.